* [PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-06 17:36 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
linux-fbdev, linux-kernel
In-Reply-To: <1404566317-22987-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/sis/sis_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 22ad028..ab7e5e4 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void)
if(mydepth = 24) mydepth = 32;
- sprintf(mymode, "%ux%ux%u", screen_info.lfb_width,
+ sprintf(mymode, "%ux%ux%d", screen_info.lfb_width,
screen_info.lfb_height,
mydepth);
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: omap2: dss: display-sysfs.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-06 17:35 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
In-Reply-To: <1404566258-22901-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-sysfs.c
index 5a2095a..5928bc9 100644
--- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
+++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
@@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
if (!dssdev->driver->get_rotate)
return -ENOENT;
rotate = dssdev->driver->get_rotate(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
+ return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
}
static ssize_t display_rotate_store(struct device *dev,
@@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
if (!dssdev->driver->get_mirror)
return -ENOENT;
mirror = dssdev->driver->get_mirror(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
+ return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
}
static ssize_t display_mirror_store(struct device *dev,
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-06 17:34 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Daniel Vetter, Laurent Pinchart,
Arnd Bergmann, linux-fbdev, linux-kernel
In-Reply-To: <1404566552-23096-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Wrong type in sscanf format string, requires 'int *' but the
argument type is 'unsigned int *'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap/omapfb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index d8d028d..7df0764 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1371,7 +1371,7 @@ static ssize_t omapfb_store_bklight_level(struct device *dev,
if (fbdev->panel->set_bklight_level) {
unsigned int level;
- if (sscanf(buf, "%10d", &level) = 1) {
+ if (sscanf(buf, "%10u", &level) = 1) {
r = fbdev->panel->set_bklight_level(fbdev->panel,
level);
} else
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-06 17:27 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Stefano Stabellini, Konrad Rzeszutek Wilk,
Jingoo Han, Daniel Vetter, linux-fbdev, linux-kernel
In-Reply-To: <1404565829-22602-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Remove assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/xen-fbfront.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 901014b..e1207a1 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
red = CNVT_TOHW(red, info->var.red.length);
green = CNVT_TOHW(green, info->var.green.length);
blue = CNVT_TOHW(blue, info->var.blue.length);
- transp = CNVT_TOHW(transp, info->var.transp.length);
#undef CNVT_TOHW
v = (red << info->var.red.offset) |
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: vga16fb.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-06 17:26 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
Luis Henriques, linux-fbdev, linux-kernel
In-Reply-To: <1404565771-22515-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Remove assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 283d335..d92e4fd 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -275,7 +275,6 @@ static void vga16fb_clock_chip(struct vga16fb_par *par,
}
par->misc |= best->misc;
par->clkdiv = best->seq_clock_mode;
- pixclock = (best->pixclock * div) / mul;
}
#define FAIL(X) return -EINVAL
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-06 17:25 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Daniel Vetter, Laurent Pinchart,
Rob Clark, David Ung, linux-fbdev, linux-kernel
In-Reply-To: <1404565710-22433-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Remove assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/core/fbmon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 5b0e313..71ec1ab 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var)
}
void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
{
- specs = NULL;
}
void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs)
{
--
1.7.10.4
^ permalink raw reply related
* Re: [PATCH] video: fbdev: sis: init.c: Cleaning up variable that is never used
From: Dan Carpenter @ 2014-07-05 20:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rickard Strandqvist, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, Rickard Strandqvist, Jingoo Han, Daniel Vetter,
Mauro Carvalho Chehab, Laurent Pinchart, Chen, Gong,
Linux Fbdev development list, linux-kernel@vger.kernel.org
In-Reply-To: <20140705200430.GE25934@mwanda>
Verifying the email address is not 100% fool proof so it's not a massive
deal either way. The only reason I mentioned it here was because this
patch wasn't correct anyway and had to be redone regardless.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH] video: fbdev: sis: init.c: Cleaning up variable that is never used
From: Dan Carpenter @ 2014-07-05 20:04 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rickard Strandqvist, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, Rickard Strandqvist, Jingoo Han, Daniel Vetter,
Mauro Carvalho Chehab, Laurent Pinchart, Chen, Gong,
Linux Fbdev development list, linux-kernel@vger.kernel.org
In-Reply-To: <CAMuHMdVNgCFZ1Nu77ds62COtqMPRYw4p_fifoZnAQKjq_D+kOQ@mail.gmail.com>
On Sat, Jul 05, 2014 at 09:44:56PM +0200, Geert Uytterhoeven wrote:
> On Sat, Jul 5, 2014 at 9:23 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sat, Jul 05, 2014 at 02:48:27PM +0200, Rickard Strandqvist wrote:
> >> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
> >
> > These for lines are for when you are sending on someone else's behalf.
>
> Or for when you are sending the patches from a different email address
> than the one that should be recorded in git.
>
Yeah. But it's better to fix your email client so we can at least
verify that the signed off matches the author tag.
I know a lot of people have trouble configuring email but in the end
everyone pretty much manages when we ask them to.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH] video: fbdev: sis: init.c: Cleaning up variable that is never used
From: Geert Uytterhoeven @ 2014-07-05 19:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rickard Strandqvist, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, Rickard Strandqvist, Jingoo Han, Daniel Vetter,
Mauro Carvalho Chehab, Laurent Pinchart, Chen, Gong,
Linux Fbdev development list, linux-kernel@vger.kernel.org
In-Reply-To: <20140705192317.GD25934@mwanda>
On Sat, Jul 5, 2014 at 9:23 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, Jul 05, 2014 at 02:48:27PM +0200, Rickard Strandqvist wrote:
>> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> These for lines are for when you are sending on someone else's behalf.
Or for when you are sending the patches from a different email address
than the one that should be recorded in git.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH] video: fbdev: sis: init.c: Cleaning up variable that is never used
From: Dan Carpenter @ 2014-07-05 19:23 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter,
Mauro Carvalho Chehab, Laurent Pinchart, Chen, Gong, linux-fbdev,
linux-kernel
In-Reply-To: <1404564507-21718-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jul 05, 2014 at 02:48:27PM +0200, Rickard Strandqvist wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
These for lines are for when you are sending on someone else's behalf.
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/video/fbdev/sis/init.c | 21 +++++----------------
> 1 file changed, 5 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
> index bd40f5e..3ba446c 100644
> --- a/drivers/video/fbdev/sis/init.c
> +++ b/drivers/video/fbdev/sis/init.c
> @@ -2649,7 +2649,7 @@ static void
> SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
> unsigned short ModeIdIndex, unsigned short RRTI)
> {
> - unsigned short data, infoflag = 0, modeflag, resindex;
> + unsigned short data, infoflag = 0, modeflag;
> #ifdef CONFIG_FB_SIS_315
> unsigned char *ROMAddr = SiS_Pr->VirtualRomBase;
> unsigned short data2, data3;
> @@ -2660,7 +2660,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
> if(SiS_Pr->UseCustomMode) {
> infoflag = SiS_Pr->CInfoFlag;
> } else {
> - resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
> + SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
Remove this whole line.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH] video: fbdev: g364fb.c: Cleaning up variable that is never used
From: Geert Uytterhoeven @ 2014-07-05 17:09 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
Daniel Vetter, Linux Fbdev development list,
linux-kernel@vger.kernel.org
In-Reply-To: <1404562874-19440-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jul 5, 2014 at 2:21 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up removal variable thet is never used
From: Rickard Strandqvist @ 2014-07-05 16:24 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Daniel Vetter, Laurent Pinchart, Rob Clark, Arnd Bergmann,
linux-fbdev, linux-kernel
In-Reply-To: <1404566552-23096-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Removal of union member variable thet is never used
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap/omapfb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index d8d028d..557aaa3 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1096,7 +1096,6 @@ static int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd,
enum omapfb_update_mode update_mode;
struct omapfb_caps caps;
unsigned int mirror;
- int plane_out;
int enable_plane;
} p;
int r = 0;
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: omap2: dss: sdi.c: Cleaning up removal variable thet is never used
From: Rickard Strandqvist @ 2014-07-05 16:23 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Archit Taneja,
Jingoo Han, Daniel Vetter, Laurent Pinchart, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Removal of struct member variable thet is never used
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap2/dss/sdi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/dss/sdi.c b/drivers/video/fbdev/omap2/dss/sdi.c
index 911dcc9..c6491ac 100644
--- a/drivers/video/fbdev/omap2/dss/sdi.c
+++ b/drivers/video/fbdev/omap2/dss/sdi.c
@@ -34,7 +34,6 @@
static struct {
struct platform_device *pdev;
- bool update_enabled;
struct regulator *vdds_sdi_reg;
struct dss_lcd_mgr_config mgr_config;
--
1.7.10.4
^ permalink raw reply related
* Re: [PATCH] video: fbdev: aty: atyfb_base.c: Cleaning up variable that is never used
From: Mikulas Patocka @ 2014-07-05 14:41 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter, Randy Dunlap,
Dan Carpenter, Sachin Kamat, linux-fbdev, linux-kernel
In-Reply-To: <1404562522-18911-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, 5 Jul 2014, Rickard Strandqvist wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Mikulas Patocka <mpatocka@redhat.com>
> ---
> drivers/video/fbdev/aty/atyfb_base.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
> index c3d0074..46188a4 100644
> --- a/drivers/video/fbdev/aty/atyfb_base.c
> +++ b/drivers/video/fbdev/aty/atyfb_base.c
> @@ -3088,7 +3088,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> if (dp = of_console_device) {
> struct fb_var_screeninfo *var = &default_var;
> unsigned int N, P, Q, M, T, R;
> - u32 v_total, h_total;
> struct crtc crtc;
> u8 pll_regs[16];
> u8 clock_cntl;
> @@ -3104,9 +3103,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
> crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
> aty_crtc_to_var(&crtc, var);
>
> - h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
> - v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
> -
> /*
> * Read the PLL to figure actual Refresh Rate.
> */
> --
> 1.7.10.4
>
^ permalink raw reply
* Validating monitor timings (was: Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is nev
From: Geert Uytterhoeven @ 2014-07-05 14:06 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
Sachin Kamat, Linux Fbdev development list,
linux-kernel@vger.kernel.org
On Sat, Jul 5, 2014 at 4:04 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
>> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>>
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>> --- a/drivers/video/fbdev/amifb.c
>> +++ b/drivers/video/fbdev/amifb.c
>> @@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par,
>> {
>> u_short clk_shift, line_shift;
>> u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n;
>> - u_int htotal, vtotal;
>
> These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf
> Author: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Wed Dec 13 00:35:54 2006 -0800
>
> [PATCH] fbdev: remove references to non-existent fbmon_valid_timings()
>
> Remove references to non-existent fbmon_valid_timings()
These days there's fb_validate_mode(), but very few drivers call that.
Or perhaps this should be handled by the fbdev core instead?
But there's potential for regressions here, as monspecs may not be set at all
with some drivers, and the default assumptions in fb_validate_mode() may not
be valid.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used
From: Geert Uytterhoeven @ 2014-07-05 14:04 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
Sachin Kamat, Linux Fbdev development list,
linux-kernel@vger.kernel.org
In-Reply-To: <1404562393-18641-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par,
> {
> u_short clk_shift, line_shift;
> u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n;
> - u_int htotal, vtotal;
These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf
Author: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed Dec 13 00:35:54 2006 -0800
[PATCH] fbdev: remove references to non-existent fbmon_valid_timings()
Remove references to non-existent fbmon_valid_timings()
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: James Simmons <jsimmons@infradead.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH] video: fbdev: atafb.c: Cleaning up variable that is never used
From: Geert Uytterhoeven @ 2014-07-05 13:57 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
Michael Schmitz, Linux Fbdev development list,
linux-kernel@vger.kernel.org
In-Reply-To: <1404562464-18788-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jul 5, 2014 at 2:14 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH] video: fbdev: valkyriefb.c: Cleaning up variable that is never used
From: Geert Uytterhoeven @ 2014-07-05 13:56 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Rickard Strandqvist, Jingoo Han, Daniel Vetter, Joe Perches,
Linux Fbdev development list, linux-kernel@vger.kernel.org
In-Reply-To: <1404564740-22066-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jul 5, 2014 at 2:52 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* [PATCH] video: fbdev: omap: omapfb_main.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-05 13:22 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Daniel Vetter, Laurent Pinchart, Rob Clark, Arnd Bergmann,
linux-fbdev, linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Wrong type in sscanf format string, requires 'int *' but the
argument type is 'unsigned int *'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap/omapfb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index d8d028d..7df0764 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1371,7 +1371,7 @@ static ssize_t omapfb_store_bklight_level(struct device *dev,
if (fbdev->panel->set_bklight_level) {
unsigned int level;
- if (sscanf(buf, "%10d", &level) = 1) {
+ if (sscanf(buf, "%10u", &level) = 1) {
r = fbdev->panel->set_bklight_level(fbdev->panel,
level);
} else
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-05 13:18 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Daniel Vetter, Joe Perches, Laurent Pinchart, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/sis/sis_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 22ad028..ab7e5e4 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void)
if(mydepth = 24) mydepth = 32;
- sprintf(mymode, "%ux%ux%u", screen_info.lfb_width,
+ sprintf(mymode, "%ux%ux%d", screen_info.lfb_width,
screen_info.lfb_height,
mydepth);
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: omap2: dss: display-sysfs.c: Cleaning up wrong type in format string
From: Rickard Strandqvist @ 2014-07-05 13:17 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Laurent Pinchart, Rob Clark, Daniel Vetter, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-sysfs.c
index 5a2095a..5928bc9 100644
--- a/drivers/video/fbdev/omap2/dss/display-sysfs.c
+++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c
@@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev,
if (!dssdev->driver->get_rotate)
return -ENOENT;
rotate = dssdev->driver->get_rotate(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", rotate);
+ return snprintf(buf, PAGE_SIZE, "%d\n", rotate);
}
static ssize_t display_rotate_store(struct device *dev,
@@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev,
if (!dssdev->driver->get_mirror)
return -ENOENT;
mirror = dssdev->driver->get_mirror(dssdev);
- return snprintf(buf, PAGE_SIZE, "%u\n", mirror);
+ return snprintf(buf, PAGE_SIZE, "%d\n", mirror);
}
static ssize_t display_mirror_store(struct device *dev,
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-05 13:10 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Stefano Stabellini,
Konrad Rzeszutek Wilk, Jingoo Han, Daniel Vetter, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Removal of assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/xen-fbfront.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 901014b..e1207a1 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
red = CNVT_TOHW(red, info->var.red.length);
green = CNVT_TOHW(green, info->var.green.length);
blue = CNVT_TOHW(blue, info->var.blue.length);
- transp = CNVT_TOHW(transp, info->var.transp.length);
#undef CNVT_TOHW
v = (red << info->var.red.offset) |
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: vga16fb.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-05 13:09 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Daniel Vetter, Joe Perches, Laurent Pinchart, Luis Henriques,
linux-fbdev, linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Removal of assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 283d335..d92e4fd 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -275,7 +275,6 @@ static void vga16fb_clock_chip(struct vga16fb_par *par,
}
par->misc |= best->misc;
par->clkdiv = best->seq_clock_mode;
- pixclock = (best->pixclock * div) / mul;
}
#define FAIL(X) return -EINVAL
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter
From: Rickard Strandqvist @ 2014-07-05 13:08 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Daniel Vetter, Laurent Pinchart, Rob Clark, David Ung,
linux-fbdev, linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Removal of assignment of function parameter, that has no effect outside the function
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/core/fbmon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 5b0e313..71ec1ab 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var)
}
void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
{
- specs = NULL;
}
void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs)
{
--
1.7.10.4
^ permalink raw reply related
* [PATCH] video: fbdev: via: lcd.c: Cleaning up variable that is never used
From: Rickard Strandqvist @ 2014-07-05 12:53 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Laurent Pinchart, Rob Clark, Daniel Vetter, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/via/lcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
index 5d21ff4..c15ed30 100644
--- a/drivers/video/fbdev/via/lcd.c
+++ b/drivers/video/fbdev/via/lcd.c
@@ -551,11 +551,11 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
u32 clock;
struct via_display_timing timing;
struct fb_var_screeninfo panel_var;
- const struct fb_videomode *mode_crt_table, *panel_crt_table;
+ const struct fb_videomode, *panel_crt_table;
DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
/* Get mode table */
- mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
+ viafb_get_best_mode(set_hres, set_vres, 60);
/* Get panel table Pointer */
panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
viafb_fill_var_timing_info(&panel_var, panel_crt_table);
--
1.7.10.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox