From: Mario Limonciello <mario.limonciello@amd.com>
To: Josh Boyer <jwboyer@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-firmware@kernel.org
Subject: Re: [PATCH 00/20] Add preparations to be able to run in a CI/CD system
Date: Wed, 30 Aug 2023 10:51:02 -0500 [thread overview]
Message-ID: <2c9a6fcf-e4dd-4ba5-abf6-9f6d6f6dc3e1@amd.com> (raw)
In-Reply-To: <CA+5PVA4DjHCn_zDoFOimr7NW5GpN8+zTVWJEAmo+c6biCHEicg@mail.gmail.com>
On 8/28/2023 06:15, Josh Boyer wrote:
> On Fri, Aug 25, 2023 at 1:22 PM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> Helo,
>>
>> On 15/08/2023 20:59, Mario Limonciello wrote:
>>> If linux-firmware.git or a fork of it is hosted in Gitlab there is the
>>> ability to gate pull requests based on some CI checks.
>>>
>>> The basic ones that come to mind are:
>>> 1. Checking spelling.
>>
>> First, you are renaming a lot of 'licence' files to be named 'license'.
>> This is fine from the US English point of view. Other (e.g. UK) English
>> keep the difference between licence (noun) and license (verb). Not
>> everybody uses the US English, especially for the legal documents.
>>
>> Second, renaming licence files and/or changing their contents doesn't
>> sound right to me. They are legally binding documents, with all the
>> mistakes and typos. They are usually passed through the legal
>> departments, etc. I would not guarantee that one wouldn't consider
>> licence being void after these spelling corrections.
>
> I agree with Dmitry on these two points.
>
> We should be able to figure out a way to have any future CI checks
> scan MRs for typographical errors and catch them at that point, but
> doing a blanket rename and cleanup is something we should probably
> avoid for now.
>
> josh
Thanks for the feedback, understood.
>
>>
>>> 2. Checking WHENCE.
>>> 3. Checking for SoB.
>>> 4. Ensure that any python scripts pass style for 'black'.
>>>
>>> All of the checks can be triggered by `pre-commit` or by `make check`
>>>
>>> This series cleans up linux-firmware.git so all those would pass and
>>> adds some templates to that effect.
>>>
>>> Mario Limonciello (20):
>>> ath11k: update typographical errors in the Notice.txt files
>>> ath10k: correct typographical errors in the Notice.txt files
>>> i915: correct typographical errors caught by codespell
>>> adsp_sst: correct typographical errors caught by codespell
>>> agere: correct typographical errors in LICENSE caught by codespell
>>> qca: correct typographical errors in NOTICE.txt caught by codespell
>>> usbdux: correct typographical errors caught by codespell
>>> dsp56k: correct typographical error caught by codespell
>>> cxgb4: correct typographical errors caught by codespell
>>> cavium_liquidio: fix typographical errors caught by codespell
>>> kaweth: correct typographical errors caught by codespell
>>> xc5000c: correct typographical errors caught by codespell
>>> qcom: correct typographical errors caught by codespell
>>> keyspan_pda: correct typographical errors caught by codespell
>>> carl9170fw: correct typographical errors caught by codespell
>>> WHENCE: correct typographical errors caught by codespell
>>> check_whence: reformat using python black
>>> Add CI/CD with ci-fairy
>>> Wire up pre-commit to `make check`
>>> Rewrite README in markdown
>>>
>>> .codespell.cfg | 4 +
>>> .gitignore | 1 +
>>> .gitlab-ci.yml | 22 +
>>> .pre-commit-config.yaml | 33 ++
>>> LICENCE.Abilis => LICENSE.Abilis | 0
>>> LICENCE.IntcSST2 => LICENSE.IntcSST2 | 0
>>> LICENCE.Marvell => LICENSE.Marvell | 0
>>> LICENCE.NXP => LICENSE.NXP | 0
>>> LICENCE.Netronome => LICENSE.Netronome | 0
>>> LICENCE.OLPC => LICENSE.OLPC | 0
>>> LICENCE.adsp_sst => LICENSE.adsp_sst | 4 +-
>>> LICENCE.agere => LICENSE.agere | 2 +-
>>> ...heros_firmware => LICENSE.atheros_firmware | 0
>>> ...oadcom_bcm43xx => LICENSE.broadcom_bcm43xx | 0
>>> LICENCE.ca0132 => LICENSE.ca0132 | 0
>>> LICENCE.cadence => LICENSE.cadence | 0
>>> LICENCE.cavium => LICENSE.cavium | 0
>>> ...cavium_liquidio => LICENSE.cavium_liquidio | 4 +-
>>> ...elsio_firmware => LICENSE.chelsio_firmware | 0
>>> LICENCE.cnm => LICENSE.cnm | 0
>>> LICENCE.cw1200 => LICENSE.cw1200 | 0
>>> LICENCE.cypress => LICENSE.cypress | 0
>>> LICENCE.e100 => LICENSE.e100 | 0
>>> LICENCE.ene_firmware => LICENSE.ene_firmware | 0
>>> LICENCE.fw_sst_0f28 => LICENSE.fw_sst_0f28 | 0
>>> LICENCE.go7007 => LICENSE.go7007 | 0
>>> LICENSE.i915 | 78 ++--
>>> LICENCE.ibt_firmware => LICENSE.ibt_firmware | 0
>>> LICENCE.it913x => LICENSE.it913x | 0
>>> ...lwifi_firmware => LICENSE.iwlwifi_firmware | 0
>>> LICENCE.kaweth => LICENSE.kaweth | 2 +-
>>> LICENCE.linaro => LICENSE.linaro | 0
>>> LICENCE.mediatek => LICENSE.mediatek | 0
>>> LICENCE.microchip => LICENSE.microchip | 0
>>> LICENCE.moxa => LICENSE.moxa | 0
>>> ...10ge_firmware => LICENSE.myri10ge_firmware | 0
>>> LICENCE.nvidia => LICENSE.nvidia | 0
>>> ...irmware => LICENSE.open-ath9k-htc-firmware | 0
>>> LICENCE.phanfw => LICENSE.phanfw | 0
>>> LICENCE.qat_firmware => LICENSE.qat_firmware | 0
>>> LICENCE.qla1280 => LICENSE.qla1280 | 0
>>> LICENCE.qla2xxx => LICENSE.qla2xxx | 0
>>> LICENCE.r8a779x_usb3 => LICENSE.r8a779x_usb3 | 0
>>> ...irmware.txt => LICENSE.ralink-firmware.txt | 0
>>> ...LICENSE.ralink_a_mediatek_company_firmware | 0
>>> LICENCE.rockchip => LICENSE.rockchip | 0
>>> ...rmware.txt => LICENSE.rtlwifi_firmware.txt | 0
>>> LICENCE.siano => LICENSE.siano | 0
>>> ...ti-connectivity => LICENSE.ti-connectivity | 0
>>> LICENCE.ti-keystone => LICENSE.ti-keystone | 0
>>> LICENCE.ti-tspa => LICENSE.ti-tspa | 0
>>> ...4-firmware => LICENSE.ueagle-atm4-firmware | 0
>>> LICENCE.via_vt6656 => LICENSE.via_vt6656 | 0
>>> LICENCE.wl1251 => LICENSE.wl1251 | 0
>>> LICENCE.xc4000 => LICENSE.xc4000 | 0
>>> LICENCE.xc5000 => LICENSE.xc5000 | 0
>>> LICENCE.xc5000c => LICENSE.xc5000c | 2 +-
>>> Makefile | 6 +-
>>> README | 43 --
>>> README.md | 54 +++
>>> WHENCE | 432 +++++++++---------
>>> .../hw1.0/notice_ath10k_firmware-5.txt | 40 +-
>>> .../hw2.1/notice_ath10k_firmware-5.txt | 138 +++---
>>> .../hw3.0/notice_ath10k_firmware-4.txt | 144 +++---
>>> .../hw3.0/notice_ath10k_firmware-6.txt | 32 +-
>>> .../hw3.0/notice_ath10k_firmware-sdio-6.txt | 32 +-
>>> .../hw1.0/notice_ath10k_firmware-5.txt | 138 +++---
>>> .../hw1.0/notice_ath10k_firmware-6.txt | 32 +-
>>> .../hw1.0/notice_ath10k_firmware-sdio-5.txt | 138 +++---
>>> .../hw1.0/notice_ath10k_firmware-5.txt | 8 +-
>>> .../hw2.0/notice_ath10k_firmware-5.txt | 40 +-
>>> .../hw2.0/notice_ath10k_firmware-4.txt | 8 +-
>>> .../hw2.0/notice_ath10k_firmware-5.txt | 8 +-
>>> .../hw1.0/notice_ath10k_firmware-5.txt | 40 +-
>>> .../hw2.0/notice_ath10k_firmware-5.txt | 26 +-
>>> ath10k/WCN3990/hw1.0/notice.txt_wlanmdsp | 26 +-
>>> ath11k/IPQ5018/hw1.0/Notice.txt | 28 +-
>>> ath11k/IPQ6018/hw1.0/Notice.txt | 28 +-
>>> ath11k/IPQ8074/hw2.0/Notice.txt | 28 +-
>>> ath11k/QCA6390/hw2.0/Notice.txt | 100 ++--
>>> ath11k/QCN9074/hw1.0/Notice.txt | 28 +-
>>> ath11k/WCN6750/hw1.0/Notice.txt | 164 +++----
>>> ath11k/WCN6855/hw2.0/Notice.txt | 26 +-
>>> carl9170fw/carlfw/Kconfig | 2 +-
>>> carl9170fw/carlfw/carl9170.lds | 4 +-
>>> carl9170fw/carlfw/include/dma.h | 2 +-
>>> carl9170fw/carlfw/src/wlan.c | 4 +-
>>> carl9170fw/carlfw/src/wol.c | 2 +-
>>> carl9170fw/extra/FindGPERF.cmake | 2 +-
>>> .../extra/FindPackageHandleStandardArgs.cmake | 8 +-
>>> carl9170fw/include/shared/fwcmd.h | 2 +-
>>> carl9170fw/include/shared/phy.h | 2 +-
>>> carl9170fw/tools/carlu/src/fw.c | 2 +-
>>> carl9170fw/tools/carlu/src/test.c | 4 +-
>>> carl9170fw/tools/carlu/src/usb.c | 6 +-
>>> carl9170fw/tools/include/frame.h | 12 +-
>>> check_whence.py | 89 ++--
>>> cxgb4/configs/t4-config-default.txt | 6 +-
>>> cxgb4/configs/t5-config-default.txt | 6 +-
>>> cxgb4/configs/t5-config-hashfilter.txt | 6 +-
>>> cxgb4/configs/t6-config-default.txt | 6 +-
>>> cxgb4/configs/t6-config-hashfilter.txt | 8 +-
>>> dsp56k/concat-bootstrap.pl | 2 +-
>>> keyspan_pda/keyspan_pda.S | 4 +-
>>> keyspan_pda/xircom_pgs.S | 4 +-
>>> qca/NOTICE.txt | 6 +-
>>> qcom/NOTICE.txt | 16 +-
>>> usbdux/usbdux_firmware.asm | 16 +-
>>> usbdux/usbduxfast_firmware.asm | 6 +-
>>> usbdux/usbduxsigma_firmware.asm | 14 +-
>>> wfx/{LICENCE.wf200 => LICENSE.wf200} | 0
>>> 111 files changed, 1137 insertions(+), 1043 deletions(-)
>>> create mode 100644 .codespell.cfg
>>> create mode 100644 .gitignore
>>> create mode 100644 .gitlab-ci.yml
>>> create mode 100644 .pre-commit-config.yaml
>>> rename LICENCE.Abilis => LICENSE.Abilis (100%)
>>> rename LICENCE.IntcSST2 => LICENSE.IntcSST2 (100%)
>>> rename LICENCE.Marvell => LICENSE.Marvell (100%)
>>> rename LICENCE.NXP => LICENSE.NXP (100%)
>>> rename LICENCE.Netronome => LICENSE.Netronome (100%)
>>> rename LICENCE.OLPC => LICENSE.OLPC (100%)
>>> rename LICENCE.adsp_sst => LICENSE.adsp_sst (99%)
>>> rename LICENCE.agere => LICENSE.agere (98%)
>>> rename LICENCE.atheros_firmware => LICENSE.atheros_firmware (100%)
>>> rename LICENCE.broadcom_bcm43xx => LICENSE.broadcom_bcm43xx (100%)
>>> rename LICENCE.ca0132 => LICENSE.ca0132 (100%)
>>> rename LICENCE.cadence => LICENSE.cadence (100%)
>>> rename LICENCE.cavium => LICENSE.cavium (100%)
>>> rename LICENCE.cavium_liquidio => LICENSE.cavium_liquidio (97%)
>>> rename LICENCE.chelsio_firmware => LICENSE.chelsio_firmware (100%)
>>> rename LICENCE.cnm => LICENSE.cnm (100%)
>>> rename LICENCE.cw1200 => LICENSE.cw1200 (100%)
>>> rename LICENCE.cypress => LICENSE.cypress (100%)
>>> rename LICENCE.e100 => LICENSE.e100 (100%)
>>> rename LICENCE.ene_firmware => LICENSE.ene_firmware (100%)
>>> rename LICENCE.fw_sst_0f28 => LICENSE.fw_sst_0f28 (100%)
>>> rename LICENCE.go7007 => LICENSE.go7007 (100%)
>>> rename LICENCE.ibt_firmware => LICENSE.ibt_firmware (100%)
>>> rename LICENCE.it913x => LICENSE.it913x (100%)
>>> rename LICENCE.iwlwifi_firmware => LICENSE.iwlwifi_firmware (100%)
>>> rename LICENCE.kaweth => LICENSE.kaweth (97%)
>>> rename LICENCE.linaro => LICENSE.linaro (100%)
>>> rename LICENCE.mediatek => LICENSE.mediatek (100%)
>>> rename LICENCE.microchip => LICENSE.microchip (100%)
>>> rename LICENCE.moxa => LICENSE.moxa (100%)
>>> rename LICENCE.myri10ge_firmware => LICENSE.myri10ge_firmware (100%)
>>> rename LICENCE.nvidia => LICENSE.nvidia (100%)
>>> rename LICENCE.open-ath9k-htc-firmware => LICENSE.open-ath9k-htc-firmware (100%)
>>> rename LICENCE.phanfw => LICENSE.phanfw (100%)
>>> rename LICENCE.qat_firmware => LICENSE.qat_firmware (100%)
>>> rename LICENCE.qla1280 => LICENSE.qla1280 (100%)
>>> rename LICENCE.qla2xxx => LICENSE.qla2xxx (100%)
>>> rename LICENCE.r8a779x_usb3 => LICENSE.r8a779x_usb3 (100%)
>>> rename LICENCE.ralink-firmware.txt => LICENSE.ralink-firmware.txt (100%)
>>> rename LICENCE.ralink_a_mediatek_company_firmware => LICENSE.ralink_a_mediatek_company_firmware (100%)
>>> rename LICENCE.rockchip => LICENSE.rockchip (100%)
>>> rename LICENCE.rtlwifi_firmware.txt => LICENSE.rtlwifi_firmware.txt (100%)
>>> rename LICENCE.siano => LICENSE.siano (100%)
>>> rename LICENCE.ti-connectivity => LICENSE.ti-connectivity (100%)
>>> rename LICENCE.ti-keystone => LICENSE.ti-keystone (100%)
>>> rename LICENCE.ti-tspa => LICENSE.ti-tspa (100%)
>>> rename LICENCE.ueagle-atm4-firmware => LICENSE.ueagle-atm4-firmware (100%)
>>> rename LICENCE.via_vt6656 => LICENSE.via_vt6656 (100%)
>>> rename LICENCE.wl1251 => LICENSE.wl1251 (100%)
>>> rename LICENCE.xc4000 => LICENSE.xc4000 (100%)
>>> rename LICENCE.xc5000 => LICENSE.xc5000 (100%)
>>> rename LICENCE.xc5000c => LICENSE.xc5000c (93%)
>>> delete mode 100644 README
>>> create mode 100644 README.md
>>> rename wfx/{LICENCE.wf200 => LICENSE.wf200} (100%)
>>>
>>
>> --
>> With best wishes
>> Dmitry
>>
prev parent reply other threads:[~2023-08-30 15:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:59 [PATCH 00/20] Add preparations to be able to run in a CI/CD system Mario Limonciello
2023-08-15 17:59 ` [PATCH 01/20] ath11k: update typographical errors in the Notice.txt files Mario Limonciello
2023-08-15 18:00 ` [PATCH 02/20] ath10k: correct " Mario Limonciello
2023-08-15 18:00 ` [PATCH 03/20] i915: correct typographical errors caught by codespell Mario Limonciello
2023-08-15 18:00 ` [PATCH 04/20] adsp_sst: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 05/20] agere: correct typographical errors in LICENSE " Mario Limonciello
2023-08-15 18:00 ` [PATCH 06/20] qca: correct typographical errors in NOTICE.txt " Mario Limonciello
2023-08-15 18:00 ` [PATCH 07/20] usbdux: correct typographical errors " Mario Limonciello
2023-08-15 18:00 ` [PATCH 08/20] dsp56k: correct typographical error " Mario Limonciello
2023-08-15 18:00 ` [PATCH 09/20] cxgb4: correct typographical errors " Mario Limonciello
2023-08-15 18:00 ` [PATCH 10/20] cavium_liquidio: fix " Mario Limonciello
2023-08-15 18:00 ` [PATCH 11/20] kaweth: correct " Mario Limonciello
2023-08-15 18:00 ` [PATCH 12/20] xc5000c: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 13/20] qcom: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 14/20] keyspan_pda: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 15/20] carl9170fw: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 16/20] WHENCE: " Mario Limonciello
2023-08-15 18:00 ` [PATCH 17/20] check_whence: reformat using python black Mario Limonciello
2023-08-15 18:00 ` [PATCH 18/20] Add CI/CD with ci-fairy Mario Limonciello
2023-08-15 18:00 ` [PATCH 19/20] Wire up pre-commit to `make check` Mario Limonciello
2023-08-15 18:00 ` [PATCH 20/20] Rewrite README in markdown Mario Limonciello
2023-08-25 17:22 ` [PATCH 00/20] Add preparations to be able to run in a CI/CD system Dmitry Baryshkov
2023-08-28 11:15 ` Josh Boyer
2023-08-30 15:51 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c9a6fcf-e4dd-4ba5-abf6-9f6d6f6dc3e1@amd.com \
--to=mario.limonciello@amd.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=jwboyer@kernel.org \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox