public inbox for linux-fscrypt@vger.kernel.org
 help / color / mirror / Atom feed
* [fsverity-utils PATCH] Restore installation of public header via make install
@ 2020-10-29  9:18 luca.boccassi
  2020-10-29 15:46 ` Eric Biggers
  0 siblings, 1 reply; 2+ messages in thread
From: luca.boccassi @ 2020-10-29  9:18 UTC (permalink / raw)
  To: linux-fscrypt

From: Luca Boccassi <luca.boccassi@microsoft.com>

Fixes: 5ca4c55e3382 ("Makefile: generate libfsverity.pc during 'make install'")

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
I think this was removed by mistake? After the linked commit make install
does not install the header anymore

 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index a898ed4..bfe83c4 100644
--- a/Makefile
+++ b/Makefile
@@ -206,6 +206,7 @@ install:all
 	install -m644 libfsverity.a $(DESTDIR)$(LIBDIR)
 	install -m755 libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)
 	ln -sf libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)/libfsverity.so
+	install -m644 include/libfsverity.h $(DESTDIR)$(INCDIR)
 	sed -e "s|@PREFIX@|$(PREFIX)|" \
 		-e "s|@LIBDIR@|$(LIBDIR)|" \
 		-e "s|@INCDIR@|$(INCDIR)|" \
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [fsverity-utils PATCH] Restore installation of public header via make install
  2020-10-29  9:18 [fsverity-utils PATCH] Restore installation of public header via make install luca.boccassi
@ 2020-10-29 15:46 ` Eric Biggers
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2020-10-29 15:46 UTC (permalink / raw)
  To: luca.boccassi; +Cc: linux-fscrypt

On Thu, Oct 29, 2020 at 09:18:27AM +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Fixes: 5ca4c55e3382 ("Makefile: generate libfsverity.pc during 'make install'")
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> I think this was removed by mistake? After the linked commit make install
> does not install the header anymore
> 
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index a898ed4..bfe83c4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -206,6 +206,7 @@ install:all
>  	install -m644 libfsverity.a $(DESTDIR)$(LIBDIR)
>  	install -m755 libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)
>  	ln -sf libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)/libfsverity.so
> +	install -m644 include/libfsverity.h $(DESTDIR)$(INCDIR)
>  	sed -e "s|@PREFIX@|$(PREFIX)|" \
>  		-e "s|@LIBDIR@|$(LIBDIR)|" \
>  		-e "s|@INCDIR@|$(INCDIR)|" \

Applied, thanks.  Sorry about that.

- Eric

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-29 15:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-29  9:18 [fsverity-utils PATCH] Restore installation of public header via make install luca.boccassi
2020-10-29 15:46 ` Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox