Linux filesystem development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: intermezzo-devel@lists.sf.net
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] remove TCGETS
Date: Tue, 12 Aug 2003 22:48:02 +0100	[thread overview]
Message-ID: <20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk> (raw)


I see no reason to handle TCGETS in presto_ioctl, and even if you do get
it somehow, the action is the same as the default.  This happens to break
on PA-RISC and not on i386 due to i386 using an old-style definition of
TCGETS and PA-RISC using one which invovles sizeof().

diff -urpNX dontdiff linus-2.6/fs/intermezzo/dir.c parisc-2.6/fs/intermezzo/dir.c
--- linus-2.6/fs/intermezzo/dir.c	Tue Aug 12 13:11:17 2003
+++ parisc-2.6/fs/intermezzo/dir.c	Tue Aug 12 13:29:43 2003
@@ -1304,10 +1304,6 @@ int presto_ioctl(struct inode *inode, st
                 return rc;
         }
 
-        case TCGETS:
-                EXIT;
-                return -EINVAL;
-
         default:
                 EXIT;
                 return -EINVAL;

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

             reply	other threads:[~2003-08-12 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-12 21:48 Matthew Wilcox [this message]
2003-08-12 21:59 ` [PATCH] remove TCGETS Andreas Dilger
2003-08-13  1:42   ` Peter Braam
2003-08-13 12:12   ` David Woodhouse
2003-08-13 15:35     ` Andreas Dilger
2003-08-14  1:28       ` Peter Braam
2003-08-14  1:43         ` Matthew Wilcox
2003-08-14 15:54           ` Bryan Henderson
2003-10-28 15:56             ` David Woodhouse
2003-10-28 19:41               ` Bryan Henderson
2003-10-28 20:52               ` Andries Brouwer
2003-10-28 21:07               ` Linus Torvalds
2003-10-28 23:51                 ` Andrew Sharp
2003-10-29  1:54                   ` Linus Torvalds
2003-10-29  0:46                 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=intermezzo-devel@lists.sf.net \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox