Linux filesystem development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Peter Braam <braam@clusterfs.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Matthew Wilcox <willy@debian.org>,
	intermezzo-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] remove TCGETS
Date: Thu, 14 Aug 2003 02:43:45 +0100	[thread overview]
Message-ID: <20030814014345.GH10015@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030814012818.GD1918@localhost.localdomain>

On Wed, Aug 13, 2003 at 07:28:18PM -0600, Peter Braam wrote:
> In fact some part of POSIX says that ioctls should return EINVAL
> that's why I made that choice.  Anyway, the issue is moot.

Actually, it's an interesting point.  The relevant bit of SUSv3 says:

If an underlying device driver detects an error, then ioctl() shall fail if:

[EINVAL]
    The request or arg argument is not valid for this device.
[EIO]
    Some physical I/O error has occurred.
[ENOTTY]
    The fildes argument is not associated with a STREAMS device that
    accepts control functions.
[ENXIO]
    The request and arg arguments are valid for this device driver, but
    the service requested cannot be performed on this particular sub-device.
[ENODEV]
    The fildes argument refers to a valid STREAMS device, but the
    corresponding device driver does not support the ioctl() function.

SUSv2 agrees: http://www.opengroup.org/onlinepubs/007908799/xsh/ioctl.html

Maybe we need to start removing ENOTTY returns from ioctl handlers.
I know, we all find it funny when we're told that something isn't a
typewriter, but ...

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

  reply	other threads:[~2003-08-14  1:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-12 21:48 [PATCH] remove TCGETS Matthew Wilcox
2003-08-12 21:59 ` Andreas Dilger
2003-08-13  1:42   ` Peter Braam
2003-08-13 12:12   ` David Woodhouse
2003-08-13 15:35     ` Andreas Dilger
2003-08-14  1:28       ` Peter Braam
2003-08-14  1:43         ` Matthew Wilcox [this message]
2003-08-14 15:54           ` Bryan Henderson
2003-10-28 15:56             ` David Woodhouse
2003-10-28 19:41               ` Bryan Henderson
2003-10-28 20:52               ` Andries Brouwer
2003-10-28 21:07               ` Linus Torvalds
2003-10-28 23:51                 ` Andrew Sharp
2003-10-29  1:54                   ` Linus Torvalds
2003-10-29  0:46                 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030814014345.GH10015@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=braam@clusterfs.com \
    --cc=dwmw2@infradead.org \
    --cc=intermezzo-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox