From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm,
willy@infradead.org, jefflexu@linux.alibaba.com,
shakeel.butt@linux.dev, jlayton@kernel.org, kernel-team@meta.com
Subject: [PATCH v3 00/12] fuse: support large folios
Date: Fri, 13 Dec 2024 14:18:06 -0800 [thread overview]
Message-ID: <20241213221818.322371-1-joannelkoong@gmail.com> (raw)
This patchset adds support for folios larger than one page size in FUSE.
This patchset is rebased on top of the (unmerged) patchset that removes temp
folios in writeback [1]. This patchset was tested by running it through fstests
on passthrough_hp.
Please note that writes are still effectively one page size. Larger writes can
be enabled by setting the order on the fgp flag passed in to __filemap_get_folio()
but benchmarks show this significantly degrades performance. More investigation
needs to be done into this. As such, buffered writes will be optimized in a
future patchset.
Benchmarks show roughly a ~45% improvement in read throughput.
Benchmark setup:
-- Set up server --
./libfuse/build/example/passthrough_hp --bypass-rw=1 ~/libfuse
~/mounts/fuse/ --nopassthrough
(using libfuse patched with https://github.com/libfuse/libfuse/pull/807)
-- Run fio --
fio --name=read --ioengine=sync --rw=read --bs=1M --size=1G
--numjobs=2 --ramp_time=30 --group_reporting=1
--directory=mounts/fuse/
Machine 1:
No large folios: ~4400 MiB/s
Large folios: ~7100 MiB/s
Machine 2:
No large folios: ~3700 MiB/s
Large folios: ~6400 MiB/s
[1] https://lore.kernel.org/linux-fsdevel/20241122232359.429647-1-joannelkoong@gmail.com/
Changelog:
v2: https://lore.kernel.org/linux-fsdevel/20241125220537.3663725-1-joannelkoong@gmail.com/
v2 -> v3:
* Fix direct io parsing to check each extracted page instead of assuming all
pages in a large folio will be used (Matthew)
v1: https://lore.kernel.org/linux-fsdevel/20241109001258.2216604-1-joannelkoong@gmail.com/
v1 -> v2:
* Change naming from "non-writeback write" to "writethrough write"
* Fix deadlock for writethrough writes by calling fault_in_iov_iter_readable()
* first
before __filemap_get_folio() (Josef)
* For readahead, retain original folio_size() for descs.length (Josef)
* Use folio_zero_range() api in fuse_copy_folio() (Josef)
* Add Josef's reviewed-bys
Joanne Koong (12):
fuse: support copying large folios
fuse: support large folios for retrieves
fuse: refactor fuse_fill_write_pages()
fuse: support large folios for writethrough writes
fuse: support large folios for folio reads
fuse: support large folios for symlinks
fuse: support large folios for stores
fuse: support large folios for queued writes
fuse: support large folios for readahead
fuse: optimize direct io large folios processing
fuse: support large folios for writeback
fuse: enable large folios
fs/fuse/dev.c | 128 ++++++++++++++++++++++---------------------
fs/fuse/dir.c | 8 +--
fs/fuse/file.c | 144 +++++++++++++++++++++++++++++++++----------------
3 files changed, 166 insertions(+), 114 deletions(-)
--
2.43.5
next reply other threads:[~2024-12-13 22:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 22:18 Joanne Koong [this message]
2024-12-13 22:18 ` [PATCH v3 01/12] fuse: support copying large folios Joanne Koong
2024-12-13 22:18 ` [PATCH v3 02/12] fuse: support large folios for retrieves Joanne Koong
2024-12-13 22:18 ` [PATCH v3 03/12] fuse: refactor fuse_fill_write_pages() Joanne Koong
2024-12-13 22:18 ` [PATCH v3 04/12] fuse: support large folios for writethrough writes Joanne Koong
2024-12-19 18:08 ` Jeff Layton
2024-12-19 20:24 ` Matthew Wilcox
2024-12-13 22:18 ` [PATCH v3 05/12] fuse: support large folios for folio reads Joanne Koong
2024-12-13 22:18 ` [PATCH v3 06/12] fuse: support large folios for symlinks Joanne Koong
2024-12-13 22:18 ` [PATCH v3 07/12] fuse: support large folios for stores Joanne Koong
2024-12-13 22:18 ` [PATCH v3 08/12] fuse: support large folios for queued writes Joanne Koong
2024-12-13 22:18 ` [PATCH v3 09/12] fuse: support large folios for readahead Joanne Koong
2024-12-13 22:18 ` [PATCH v3 10/12] fuse: optimize direct io large folios processing Joanne Koong
2024-12-13 22:18 ` [PATCH v3 11/12] fuse: support large folios for writeback Joanne Koong
2024-12-13 22:18 ` [PATCH v3 12/12] fuse: enable large folios Joanne Koong
2024-12-19 18:12 ` [PATCH v3 00/12] fuse: support " Jeff Layton
2025-01-22 23:23 ` Joanne Koong
2025-01-23 1:24 ` Jingbo Xu
2025-01-23 18:05 ` Joanne Koong
2025-01-23 18:24 ` Matthew Wilcox
2025-01-23 18:42 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213221818.322371-1-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox