From: Matthew Wilcox <willy@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Joanne Koong <joannelkoong@gmail.com>,
miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
josef@toxicpanda.com, bernd.schubert@fastmail.fm,
jefflexu@linux.alibaba.com, shakeel.butt@linux.dev,
kernel-team@meta.com
Subject: Re: [PATCH v3 04/12] fuse: support large folios for writethrough writes
Date: Thu, 19 Dec 2024 20:24:09 +0000 [thread overview]
Message-ID: <Z2SA6Qi78hkNUmbw@casper.infradead.org> (raw)
In-Reply-To: <c1c8b8043f5b724bce86d5c84430d4dbf6c1c207.camel@kernel.org>
On Thu, Dec 19, 2024 at 01:08:15PM -0500, Jeff Layton wrote:
> > + tmp = copy_folio_from_iter_atomic(folio, folio_offset, bytes, ii);
>
> Just to save someone else going down the same rabbit hole:
>
> copy_folio_from_iter_atomic() is defined as:
>
> static inline size_t copy_folio_from_iter_atomic(struct folio *folio,
> size_t offset, size_t bytes, struct iov_iter *i)
> {
> return copy_page_from_iter_atomic(&folio->page, offset, bytes, i);
> }
>
> ...which _looks_ sort of like it's not fully baked yet and can't handle
> a large folio, but it turns out that copy_page_from_iter_atomic() can
> handle compound pages, so I think this is actually OK. Whew!
Yes, this is fine. I'd love to clean this up further. If someone wants
the kudos of doing that, ntfs_compress_write() is your challenge. It's
the only remaining caller of copy_page_from_iter_atomic() and
once it's converted to use folios, we can push folios deeper into
the iov_iter code.
next prev parent reply other threads:[~2024-12-19 20:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 22:18 [PATCH v3 00/12] fuse: support large folios Joanne Koong
2024-12-13 22:18 ` [PATCH v3 01/12] fuse: support copying " Joanne Koong
2024-12-13 22:18 ` [PATCH v3 02/12] fuse: support large folios for retrieves Joanne Koong
2024-12-13 22:18 ` [PATCH v3 03/12] fuse: refactor fuse_fill_write_pages() Joanne Koong
2024-12-13 22:18 ` [PATCH v3 04/12] fuse: support large folios for writethrough writes Joanne Koong
2024-12-19 18:08 ` Jeff Layton
2024-12-19 20:24 ` Matthew Wilcox [this message]
2024-12-13 22:18 ` [PATCH v3 05/12] fuse: support large folios for folio reads Joanne Koong
2024-12-13 22:18 ` [PATCH v3 06/12] fuse: support large folios for symlinks Joanne Koong
2024-12-13 22:18 ` [PATCH v3 07/12] fuse: support large folios for stores Joanne Koong
2024-12-13 22:18 ` [PATCH v3 08/12] fuse: support large folios for queued writes Joanne Koong
2024-12-13 22:18 ` [PATCH v3 09/12] fuse: support large folios for readahead Joanne Koong
2024-12-13 22:18 ` [PATCH v3 10/12] fuse: optimize direct io large folios processing Joanne Koong
2024-12-13 22:18 ` [PATCH v3 11/12] fuse: support large folios for writeback Joanne Koong
2024-12-13 22:18 ` [PATCH v3 12/12] fuse: enable large folios Joanne Koong
2024-12-19 18:12 ` [PATCH v3 00/12] fuse: support " Jeff Layton
2025-01-22 23:23 ` Joanne Koong
2025-01-23 1:24 ` Jingbo Xu
2025-01-23 18:05 ` Joanne Koong
2025-01-23 18:24 ` Matthew Wilcox
2025-01-23 18:42 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2SA6Qi78hkNUmbw@casper.infradead.org \
--to=willy@infradead.org \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox