Linux filesystem development
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org
Cc: josef@toxicpanda.com, bernd.schubert@fastmail.fm,
	willy@infradead.org, jefflexu@linux.alibaba.com,
	shakeel.butt@linux.dev, jlayton@kernel.org, kernel-team@meta.com
Subject: [PATCH v3 04/12] fuse: support large folios for writethrough writes
Date: Fri, 13 Dec 2024 14:18:10 -0800	[thread overview]
Message-ID: <20241213221818.322371-5-joannelkoong@gmail.com> (raw)
In-Reply-To: <20241213221818.322371-1-joannelkoong@gmail.com>

Add support for folios larger than one page size for writethrough
writes.

Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
 fs/fuse/file.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index c041bb328203..84e39426862a 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1135,6 +1135,7 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 				     struct iov_iter *ii, loff_t pos,
 				     unsigned int max_pages)
 {
+	size_t max_folio_size = mapping_max_folio_size(mapping);
 	struct fuse_args_pages *ap = &ia->ap;
 	struct fuse_conn *fc = get_fuse_conn(mapping->host);
 	unsigned offset = pos & (PAGE_SIZE - 1);
@@ -1146,17 +1147,17 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 	num = min(num, max_pages << PAGE_SHIFT);
 
 	ap->args.in_pages = true;
-	ap->descs[0].offset = offset;
 
 	while (num) {
 		size_t tmp;
 		struct folio *folio;
 		pgoff_t index = pos >> PAGE_SHIFT;
-		unsigned int bytes = min(PAGE_SIZE - offset, num);
+		unsigned int bytes;
+		unsigned int folio_offset;
 
  again:
 		err = -EFAULT;
-		if (fault_in_iov_iter_readable(ii, bytes))
+		if (fault_in_iov_iter_readable(ii, max_folio_size) == max_folio_size)
 			break;
 
 		folio = __filemap_get_folio(mapping, index, FGP_WRITEBEGIN,
@@ -1169,7 +1170,10 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 		if (mapping_writably_mapped(mapping))
 			flush_dcache_folio(folio);
 
-		tmp = copy_folio_from_iter_atomic(folio, offset, bytes, ii);
+		folio_offset = ((index - folio->index) << PAGE_SHIFT) + offset;
+		bytes = min(folio_size(folio) - folio_offset, num);
+
+		tmp = copy_folio_from_iter_atomic(folio, folio_offset, bytes, ii);
 		flush_dcache_folio(folio);
 
 		if (!tmp) {
@@ -1180,6 +1184,7 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 
 		err = 0;
 		ap->folios[ap->num_folios] = folio;
+		ap->descs[ap->num_folios].offset = folio_offset;
 		ap->descs[ap->num_folios].length = tmp;
 		ap->num_folios++;
 
@@ -1187,11 +1192,11 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 		pos += tmp;
 		num -= tmp;
 		offset += tmp;
-		if (offset == PAGE_SIZE)
+		if (offset == folio_size(folio))
 			offset = 0;
 
-		/* If we copied full page, mark it uptodate */
-		if (tmp == PAGE_SIZE)
+		/* If we copied full folio, mark it uptodate */
+		if (tmp == folio_size(folio))
 			folio_mark_uptodate(folio);
 
 		if (folio_test_uptodate(folio)) {
-- 
2.43.5


  parent reply	other threads:[~2024-12-13 22:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 22:18 [PATCH v3 00/12] fuse: support large folios Joanne Koong
2024-12-13 22:18 ` [PATCH v3 01/12] fuse: support copying " Joanne Koong
2024-12-13 22:18 ` [PATCH v3 02/12] fuse: support large folios for retrieves Joanne Koong
2024-12-13 22:18 ` [PATCH v3 03/12] fuse: refactor fuse_fill_write_pages() Joanne Koong
2024-12-13 22:18 ` Joanne Koong [this message]
2024-12-19 18:08   ` [PATCH v3 04/12] fuse: support large folios for writethrough writes Jeff Layton
2024-12-19 20:24     ` Matthew Wilcox
2024-12-13 22:18 ` [PATCH v3 05/12] fuse: support large folios for folio reads Joanne Koong
2024-12-13 22:18 ` [PATCH v3 06/12] fuse: support large folios for symlinks Joanne Koong
2024-12-13 22:18 ` [PATCH v3 07/12] fuse: support large folios for stores Joanne Koong
2024-12-13 22:18 ` [PATCH v3 08/12] fuse: support large folios for queued writes Joanne Koong
2024-12-13 22:18 ` [PATCH v3 09/12] fuse: support large folios for readahead Joanne Koong
2024-12-13 22:18 ` [PATCH v3 10/12] fuse: optimize direct io large folios processing Joanne Koong
2024-12-13 22:18 ` [PATCH v3 11/12] fuse: support large folios for writeback Joanne Koong
2024-12-13 22:18 ` [PATCH v3 12/12] fuse: enable large folios Joanne Koong
2024-12-19 18:12 ` [PATCH v3 00/12] fuse: support " Jeff Layton
2025-01-22 23:23 ` Joanne Koong
2025-01-23  1:24   ` Jingbo Xu
2025-01-23 18:05     ` Joanne Koong
2025-01-23 18:24   ` Matthew Wilcox
2025-01-23 18:42     ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213221818.322371-5-joannelkoong@gmail.com \
    --to=joannelkoong@gmail.com \
    --cc=bernd.schubert@fastmail.fm \
    --cc=jefflexu@linux.alibaba.com \
    --cc=jlayton@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@meta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=shakeel.butt@linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox