From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Neil Brown <neilb@suse.de>, Miklos Szeredi <miklos@szeredi.hu>,
Jan Kara <jack@suse.cz>
Subject: Re: [RFC] dentry->d_flags locking
Date: Mon, 24 Feb 2025 14:14:44 +0000 [thread overview]
Message-ID: <20250224141444.GX1977892@ZenIV> (raw)
In-Reply-To: <20250224-attribut-singen-e29c9a49ee56@brauner>
On Mon, Feb 24, 2025 at 11:35:47AM +0100, Christian Brauner wrote:
> I think it would be worthwhile to mark dentries of such filesystems as
> always unhashed and then add an assert into fs/dcache.c whenever such a
> dentry should suddenly become hashed.
>
> That would not just make it very easy to see for the reviewer that the
> dentries of this filesystem are always unhashed it would also make it
> possible to spot bugs.
Not sure that's useful, really... Details are tied into the tree-in-dcache
rework, and I'll need to finish resurrecting that; should post in a week
or so.
For this series, see viro/vfs.git#work.dcache - it's a WIP at the moment,
and it's going to get reordered (if nothing else, d_alloc_parallel()
side needs an audit of tree-walkers to prove that it won't get confused
by seeing DCACHE_PAR_LOOKUP on the stuff that hasn't yet reached in-lookup
hash chains, and that might add prereqs that would need to go early in
queue), but that at least fleshes out what I described upthread.
I'll post individual patches for review in a few hours.
next prev parent reply other threads:[~2025-02-24 14:14 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 1:06 [RFC] dentry->d_flags locking Al Viro
2025-02-24 1:38 ` Al Viro
2025-02-24 10:35 ` Christian Brauner
2025-02-24 14:14 ` Al Viro [this message]
2025-02-24 21:20 ` [PATCH 01/21] procfs: kill ->proc_dops Al Viro
2025-02-24 21:20 ` [PATCH 02/21] new helper: d_splice_alias_ops() Al Viro
2025-02-26 8:28 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 03/21] switch procfs from d_set_d_op() to d_splice_alias_ops() Al Viro
2025-02-26 8:29 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 04/21] fuse: no need for special dentry_operations for root dentry Al Viro
2025-02-26 8:29 ` Christian Brauner
2025-02-27 14:33 ` Miklos Szeredi
2025-02-24 21:20 ` [PATCH 05/21] new helper: set_default_d_op() Al Viro
2025-02-26 8:30 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 06/21] split d_flags calculation out of d_set_d_op() Al Viro
2025-02-26 8:31 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 07/21] set_default_d_op(): calculate the matching value for ->d_flags Al Viro
2025-02-26 8:33 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 08/21] simple_lookup(): just set DCACHE_DONTCACHE Al Viro
2025-02-26 8:34 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 09/21] make d_set_d_op() static Al Viro
2025-02-25 23:09 ` NeilBrown
2025-02-26 8:35 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 10/21] d_alloc_parallel(): set DCACHE_PAR_LOOKUP earlier Al Viro
2025-02-26 8:36 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 11/21] nsfs, pidfs: drop the pointless ->d_delete() Al Viro
2025-02-26 8:37 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 12/21] shmem: no dentry retention past the refcount reaching zero Al Viro
2025-02-26 8:38 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 13/21] devpts, sunrpc: don't bother with ->d_delete or ->d_op, for that matter Al Viro
2025-02-26 8:38 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 14/21] hostfs: don't bother with ->d_op Al Viro
2025-02-26 8:38 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 15/21] kill simple_dentry_operations Al Viro
2025-02-26 8:39 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 16/21] ramfs, hugetlbfs, mqueue: set DCACHE_DONTCACHE Al Viro
2025-02-25 23:25 ` NeilBrown
2025-02-25 23:36 ` Al Viro
2025-02-25 23:40 ` NeilBrown
2025-02-26 8:39 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 17/21] 9p: don't bother with always_delete_dentry Al Viro
2025-02-26 8:40 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 18/21] efivarfs: use DCACHE_DONTCACHE instead of always_delete_dentry() Al Viro
2025-02-26 8:40 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 19/21] debugfs: use DCACHE_DONTCACHE Al Viro
2025-02-26 8:40 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 20/21] configfs: " Al Viro
2025-02-26 8:40 ` Christian Brauner
2025-02-24 21:20 ` [PATCH 21/21] afs dynroot: " Al Viro
2025-02-26 8:41 ` Christian Brauner
2025-02-25 15:55 ` [PATCH 01/21] procfs: kill ->proc_dops Jan Kara
2025-02-25 23:30 ` NeilBrown
2025-02-25 23:56 ` Al Viro
2025-02-25 22:51 ` NeilBrown
2025-02-26 0:03 ` Al Viro
2025-02-26 8:25 ` Christian Brauner
2025-02-26 8:41 ` [RFC] dentry->d_flags locking Christian Brauner
2025-02-24 11:45 ` Christian Brauner
2025-06-11 7:50 ` [RFC][PATCHES v2] " Al Viro
2025-06-11 7:54 ` [PATCH v2 01/21] d_set_mounted(): we don't need to bump seqcount component of rename_lock Al Viro
2025-06-11 7:54 ` [PATCH v2 02/21] procfs: kill ->proc_dops Al Viro
2025-06-11 7:54 ` [PATCH v2 03/21] new helper: d_splice_alias_ops() Al Viro
2025-06-11 7:54 ` [PATCH v2 04/21] switch procfs from d_set_d_op() to d_splice_alias_ops() Al Viro
2025-06-11 7:54 ` [PATCH v2 05/21] fuse: no need for special dentry_operations for root dentry Al Viro
2025-06-11 7:54 ` [PATCH v2 06/21] new helper: set_default_d_op() Al Viro
2025-06-11 7:54 ` [PATCH v2 07/21] split d_flags calculation out of d_set_d_op() Al Viro
2025-06-11 7:54 ` [PATCH v2 08/21] correct the set of flags forbidden at d_set_d_op() time Al Viro
2025-06-11 9:49 ` Christian Brauner
2025-06-11 7:54 ` [PATCH v2 09/21] set_default_d_op(): calculate the matching value for ->d_flags Al Viro
2025-06-11 7:54 ` [PATCH v2 10/21] simple_lookup(): just set DCACHE_DONTCACHE Al Viro
2025-06-11 9:50 ` Christian Brauner
2025-06-11 7:54 ` [PATCH v2 11/21] make d_set_d_op() static Al Viro
2025-06-11 7:54 ` [PATCH v2 12/21] d_alloc_parallel(): set DCACHE_PAR_LOOKUP earlier Al Viro
2025-06-11 7:54 ` [PATCH v2 13/21] shmem: no dentry retention past the refcount reaching zero Al Viro
2025-06-11 7:54 ` [PATCH v2 14/21] devpts, sunrpc, hostfs: don't bother with ->d_op Al Viro
2025-06-11 9:50 ` Christian Brauner
2025-06-11 7:54 ` [PATCH v2 15/21] kill simple_dentry_operations Al Viro
2025-06-11 7:54 ` [PATCH v2 16/21] ramfs, hugetlbfs, mqueue: set DCACHE_DONTCACHE Al Viro
2025-06-11 7:54 ` [PATCH v2 17/21] 9p: don't bother with always_delete_dentry Al Viro
2025-06-11 7:54 ` [PATCH v2 18/21] efivarfs: use DCACHE_DONTCACHE instead of always_delete_dentry() Al Viro
2025-06-11 7:54 ` [PATCH v2 19/21] debugfs: use DCACHE_DONTCACHE Al Viro
2025-06-11 7:54 ` [PATCH v2 20/21] configfs: " Al Viro
2025-06-11 7:54 ` [PATCH v2 21/21] tracefs: set DCACHE_DONTCACHE Al Viro
2025-06-11 9:51 ` Christian Brauner
2025-06-11 9:47 ` [RFC][PATCHES v2] dentry->d_flags locking Christian Brauner
2025-02-24 14:07 ` [RFC] " Miklos Szeredi
2025-02-25 17:56 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224141444.GX1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).