* [PATCH] mm: remove wb_writeout_inc
@ 2026-07-10 5:10 Christoph Hellwig
2026-07-10 8:24 ` Anshuman Khandual
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-07-10 5:10 UTC (permalink / raw)
To: willy, jack; +Cc: akpm, linux-fsdevel, linux-mm
Remove this entirely unused but exported function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
include/linux/backing-dev.h | 2 --
mm/page-writeback.c | 10 ----------
2 files changed, 12 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 5b7d12b40d5e..c2284466e7aa 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -76,8 +76,6 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item)
return percpu_counter_sum_positive(&wb->stat[item]);
}
-extern void wb_writeout_inc(struct bdi_writeback *wb);
-
/*
* maximal error of a stat counter.
*/
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index e98748112d1e..47495be68598 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -584,16 +584,6 @@ static inline void __wb_writeout_add(struct bdi_writeback *wb, long nr)
wb->bdi->max_prop_frac, nr);
}
-void wb_writeout_inc(struct bdi_writeback *wb)
-{
- unsigned long flags;
-
- local_irq_save(flags);
- __wb_writeout_add(wb, 1);
- local_irq_restore(flags);
-}
-EXPORT_SYMBOL_GPL(wb_writeout_inc);
-
/*
* On idle system, we can be called long after we scheduled because we use
* deferred timers so count with missed periods.
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove wb_writeout_inc
2026-07-10 5:10 [PATCH] mm: remove wb_writeout_inc Christoph Hellwig
@ 2026-07-10 8:24 ` Anshuman Khandual
2026-07-10 16:29 ` David Hildenbrand (Arm)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Anshuman Khandual @ 2026-07-10 8:24 UTC (permalink / raw)
To: Christoph Hellwig, willy, jack; +Cc: akpm, linux-fsdevel, linux-mm
On 10/07/26 10:40 AM, Christoph Hellwig wrote:
> Remove this entirely unused but exported function.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> include/linux/backing-dev.h | 2 --
> mm/page-writeback.c | 10 ----------
> 2 files changed, 12 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 5b7d12b40d5e..c2284466e7aa 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -76,8 +76,6 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item)
> return percpu_counter_sum_positive(&wb->stat[item]);
> }
>
> -extern void wb_writeout_inc(struct bdi_writeback *wb);
> -
> /*
> * maximal error of a stat counter.
> */
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index e98748112d1e..47495be68598 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -584,16 +584,6 @@ static inline void __wb_writeout_add(struct bdi_writeback *wb, long nr)
> wb->bdi->max_prop_frac, nr);
> }
>
> -void wb_writeout_inc(struct bdi_writeback *wb)
> -{
> - unsigned long flags;
> -
> - local_irq_save(flags);
> - __wb_writeout_add(wb, 1);
> - local_irq_restore(flags);
> -}
> -EXPORT_SYMBOL_GPL(wb_writeout_inc);
> -
> /*
> * On idle system, we can be called long after we scheduled because we use
> * deferred timers so count with missed periods.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove wb_writeout_inc
2026-07-10 5:10 [PATCH] mm: remove wb_writeout_inc Christoph Hellwig
2026-07-10 8:24 ` Anshuman Khandual
@ 2026-07-10 16:29 ` David Hildenbrand (Arm)
2026-07-10 17:58 ` Jan Kara
2026-07-11 0:11 ` SJ Park
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand (Arm) @ 2026-07-10 16:29 UTC (permalink / raw)
To: Christoph Hellwig, willy, jack; +Cc: akpm, linux-fsdevel, linux-mm
On 7/10/26 07:10, Christoph Hellwig wrote:
> Remove this entirely unused but exported function.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove wb_writeout_inc
2026-07-10 5:10 [PATCH] mm: remove wb_writeout_inc Christoph Hellwig
2026-07-10 8:24 ` Anshuman Khandual
2026-07-10 16:29 ` David Hildenbrand (Arm)
@ 2026-07-10 17:58 ` Jan Kara
2026-07-11 0:11 ` SJ Park
3 siblings, 0 replies; 5+ messages in thread
From: Jan Kara @ 2026-07-10 17:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: willy, jack, akpm, linux-fsdevel, linux-mm
On Fri 10-07-26 07:10:52, Christoph Hellwig wrote:
> Remove this entirely unused but exported function.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Sure. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/backing-dev.h | 2 --
> mm/page-writeback.c | 10 ----------
> 2 files changed, 12 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 5b7d12b40d5e..c2284466e7aa 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -76,8 +76,6 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item)
> return percpu_counter_sum_positive(&wb->stat[item]);
> }
>
> -extern void wb_writeout_inc(struct bdi_writeback *wb);
> -
> /*
> * maximal error of a stat counter.
> */
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index e98748112d1e..47495be68598 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -584,16 +584,6 @@ static inline void __wb_writeout_add(struct bdi_writeback *wb, long nr)
> wb->bdi->max_prop_frac, nr);
> }
>
> -void wb_writeout_inc(struct bdi_writeback *wb)
> -{
> - unsigned long flags;
> -
> - local_irq_save(flags);
> - __wb_writeout_add(wb, 1);
> - local_irq_restore(flags);
> -}
> -EXPORT_SYMBOL_GPL(wb_writeout_inc);
> -
> /*
> * On idle system, we can be called long after we scheduled because we use
> * deferred timers so count with missed periods.
> --
> 2.53.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: remove wb_writeout_inc
2026-07-10 5:10 [PATCH] mm: remove wb_writeout_inc Christoph Hellwig
` (2 preceding siblings ...)
2026-07-10 17:58 ` Jan Kara
@ 2026-07-11 0:11 ` SJ Park
3 siblings, 0 replies; 5+ messages in thread
From: SJ Park @ 2026-07-11 0:11 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: SJ Park, willy, jack, akpm, linux-fsdevel, linux-mm
On Fri, 10 Jul 2026 07:10:52 +0200 Christoph Hellwig <hch@lst.de> wrote:
> Remove this entirely unused but exported function.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-11 0:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 5:10 [PATCH] mm: remove wb_writeout_inc Christoph Hellwig
2026-07-10 8:24 ` Anshuman Khandual
2026-07-10 16:29 ` David Hildenbrand (Arm)
2026-07-10 17:58 ` Jan Kara
2026-07-11 0:11 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox