From: Matthew Wilcox <willy@infradead.org>
To: Aurelien DESBRIERES <aurelien.desbrieres@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, brauner@kernel.org
Subject: Re: [RFC PATCH 05/10] ftrfs: add file operations
Date: Mon, 13 Apr 2026 18:41:55 +0100 [thread overview]
Message-ID: <ad0q46aPi-iV_2dD@casper.infradead.org> (raw)
In-Reply-To: <CAM=40tU5NppEZ9x07qDVkSxLw6Ga4nVg7sDCqcvhfQ51VbsS9Q@mail.gmail.com>
On Mon, Apr 13, 2026 at 07:17:30PM +0200, Aurelien DESBRIERES wrote:
> ... where is this? I only see file_operations and inode_operations. I don't
> see address_space_operations anywhere.
I think you need to fix your email client. Usually on kernel mailing
lists, who said what is indicated by a level of indentation. There's
no indication here that I asked this question.
> You are correct. address_space_operations was described in the commit
> message but never implemented in the patch. This is a bug in the RFC.
>
> Will add ftrfs_aops with readfolio and writepage in v2, and wire it into
> ftrfs_iget() via inode->i_mapping->a_ops.
When you're implementing the address_space_operations, I would recommend
using iomap rather than buffer heads. It's more modern infrastructure,
and there's strong aversion to merging new filesystems that use buffer
heads.
next prev parent reply other threads:[~2026-04-13 17:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 14:23 [RFC PATCH 0/10] ftrfs: Fault-Tolerant Radiation-Robust Filesystem Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 01/10] ftrfs: add on-disk format and in-memory data structures Aurelien DESBRIERES
2026-04-13 15:11 ` Darrick J. Wong
2026-04-13 17:26 ` Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 02/10] ftrfs: add superblock operations Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 03/10] ftrfs: add inode operations Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 04/10] ftrfs: add directory operations Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 05/10] ftrfs: add file operations Aurelien DESBRIERES
2026-04-13 15:09 ` Matthew Wilcox
[not found] ` <CAM=40tU5NppEZ9x07qDVkSxLw6Ga4nVg7sDCqcvhfQ51VbsS9Q@mail.gmail.com>
2026-04-13 17:41 ` Matthew Wilcox [this message]
2026-04-13 14:23 ` [RFC PATCH 06/10] ftrfs: add block and inode allocator Aurelien DESBRIERES
2026-04-13 15:21 ` Darrick J. Wong
2026-04-14 14:11 ` Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 07/10] ftrfs: add filename and directory entry operations Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 08/10] ftrfs: add CRC32 checksumming and Reed-Solomon FEC skeleton Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 09/10] ftrfs: add Kconfig, Makefile and fs/ tree integration Aurelien DESBRIERES
2026-04-13 14:23 ` [RFC PATCH 10/10] MAINTAINERS: add entry for FTRFS filesystem Aurelien DESBRIERES
2026-04-13 15:04 ` [RFC PATCH 0/10] ftrfs: Fault-Tolerant Radiation-Robust Filesystem Pedro Falcato
2026-04-13 18:03 ` Andreas Dilger
2026-04-14 2:56 ` Gao Xiang
2026-04-14 14:11 ` Aurelien DESBRIERES
2026-04-14 13:30 ` Aurelien DESBRIERES
2026-04-13 15:06 ` Matthew Wilcox
2026-04-13 18:11 ` Darrick J. Wong
2026-04-14 14:11 ` Aurelien DESBRIERES
2026-04-14 13:31 ` Aurelien DESBRIERES
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0q46aPi-iV_2dD@casper.infradead.org \
--to=willy@infradead.org \
--cc=aurelien.desbrieres@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox