* Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally
2025-03-17 8:06 [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally Geert Uytterhoeven
@ 2025-03-17 12:24 ` Alex Elder
2025-03-17 12:56 ` Javier Martinez Canillas
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alex Elder @ 2025-03-17 12:24 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Yixun Lan, Conor Dooley,
Javier Martinez Canillas
Cc: linux-gpio, linux-riscv, linux-kernel
On 3/17/25 3:06 AM, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This (now) makes sense to me. Looks good. I'll look for other
cases like this from now on.
Tested-by: Alex Elder <elder@riscstar.com>
And if you like:
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/pinctrl/spacemit/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index a2f98b3f8a75580d..d6f6017fd097d326 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,7 +7,7 @@ config PINCTRL_SPACEMIT_K1
> bool "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> - default y
> + default ARCH_SPACEMIT
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally
2025-03-17 8:06 [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally Geert Uytterhoeven
2025-03-17 12:24 ` Alex Elder
@ 2025-03-17 12:56 ` Javier Martinez Canillas
2025-03-17 13:23 ` Yixun Lan
2025-03-18 13:12 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2025-03-17 12:56 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Yixun Lan, Conor Dooley
Cc: linux-gpio, linux-riscv, linux-kernel, Geert Uytterhoeven
Geert Uytterhoeven <geert+renesas@glider.be> writes:
Hello Geert,
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Indeed.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally
2025-03-17 8:06 [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally Geert Uytterhoeven
2025-03-17 12:24 ` Alex Elder
2025-03-17 12:56 ` Javier Martinez Canillas
@ 2025-03-17 13:23 ` Yixun Lan
2025-03-18 13:12 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Yixun Lan @ 2025-03-17 13:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Conor Dooley, Javier Martinez Canillas, linux-gpio,
linux-riscv, linux-kernel
Hi Linus Walleij:
Can you also take this? thanks
On 09:06 Mon 17 Mar , Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
> drivers/pinctrl/spacemit/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/Kconfig b/drivers/pinctrl/spacemit/Kconfig
> index a2f98b3f8a75580d..d6f6017fd097d326 100644
> --- a/drivers/pinctrl/spacemit/Kconfig
> +++ b/drivers/pinctrl/spacemit/Kconfig
> @@ -7,7 +7,7 @@ config PINCTRL_SPACEMIT_K1
> bool "SpacemiT K1 SoC Pinctrl driver"
> depends on ARCH_SPACEMIT || COMPILE_TEST
> depends on OF
> - default y
> + default ARCH_SPACEMIT
> select GENERIC_PINCTRL_GROUPS
> select GENERIC_PINMUX_FUNCTIONS
> select GENERIC_PINCONF
> --
> 2.43.0
>
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally
2025-03-17 8:06 [PATCH] pinctrl: spacemit: PINCTRL_SPACEMIT_K1 should not default to y unconditionally Geert Uytterhoeven
` (2 preceding siblings ...)
2025-03-17 13:23 ` Yixun Lan
@ 2025-03-18 13:12 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2025-03-18 13:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yixun Lan, Conor Dooley, Javier Martinez Canillas, linux-gpio,
linux-riscv, linux-kernel
On Mon, Mar 17, 2025 at 9:06 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
>
> Fixes: 7ff4faba63571c51 ("pinctrl: spacemit: enable config option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread