Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Metehan Günen" <metehangnen@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver
Date: Sat, 18 Jul 2026 11:12:28 +0200	[thread overview]
Message-ID: <2026071832-nutmeg-prototype-7f53@gregkh> (raw)
In-Reply-To: <20260718081431.25456-3-metehangnen@gmail.com>

On Sat, Jul 18, 2026 at 11:14:29AM +0300, Metehan Günen wrote:
> +	gxfp_trace.dir = debugfs_create_dir("gxfp", NULL);
> +	if (!IS_ERR_OR_NULL(gxfp_trace.dir)) {

This is not how you use debugfs.

Also, this implements a custom trace function, again, use the built-in
kernel functions for this.

This implies that the driver came from an external company that does not
have much kernel development experience, or a LLM wrote this.  As there
is no copyright information on the code, which is it?

> +void gxfp_trace_exit(void)
> +{
> +	if (!READ_ONCE(gxfp_trace.inited))

That's an abuse of READ_ONCE()  :(

thanks,

greg k-h

  parent reply	other threads:[~2026-07-18  9:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18  8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18  8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18  9:07   ` Greg KH
2026-07-18  9:08   ` Greg KH
2026-07-18  8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18  9:09   ` Greg KH
2026-07-18  9:12   ` Greg KH [this message]
2026-07-18  8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18  9:06   ` Greg KH
2026-07-18  8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18  9:06   ` Greg KH
2026-07-18  9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071832-nutmeg-prototype-7f53@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metehangnen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox