From: "Metehan Günen" <metehangnen@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor
Date: Sun, 19 Jul 2026 03:53:10 -0700 (PDT) [thread overview]
Message-ID: <6a5cac96.b39440a8.65068.287a@mx.google.com> (raw)
In-Reply-To: <2026071801-headdress-gab-348e@gregkh>
On Sat, Jul 18, 2026 at 11:07:47AM +0200, Greg KH wrote:
> C variables do not start with _, this isn't rust :)
>
> And are you checking this for 0?
Will rename _rsvd0 to reserved and add a zero-check in v2:
if (hdr.reserved != 0)
return -EINVAL;
> Are you checking this for 0?
Same for _pad0: will rename to pad and add zero validation.
> No definition of what these flags are?
The flags field was placeholder code that was never wired up — there are
no flag values defined or used anywhere. I will remove the field entirely
in v2 to keep the ABI clean.
Thanks,
Metehan Günen
next prev parent reply other threads:[~2026-07-19 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18 9:07 ` Greg KH
2026-07-19 10:53 ` Metehan Günen [this message]
2026-07-18 9:08 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 9:09 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:12 ` Greg KH
2026-07-18 9:12 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
2026-07-18 9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5cac96.b39440a8.65068.287a@mx.google.com \
--to=metehangnen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox