From: "Metehan Günen" <metehangnen@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver
Date: Sun, 19 Jul 2026 03:53:08 -0700 (PDT) [thread overview]
Message-ID: <6a5cac94.b39440a8.65068.27ee@mx.google.com> (raw)
In-Reply-To: <2026071842-trillion-ogle-1f66@gregkh>
On Sat, Jul 18, 2026 at 11:06:04AM +0200, Greg KH wrote:
> I don't think this entry is doing what you think it is doing.
>
> Was it created by a LLM?
You are right — the patch script inserted the new block between the
GOODIX TOUCHSCREEN header line and its own M: line, breaking that
entry. The new GOODIX GXFP5130 block needs to appear as a standalone
section, not mid-block. Will fix in v2.
As noted in my reply to the cover letter, the reformatting work was done
with AI assistance, which caused this and the other style issues you
found. The original driver logic is from Void755's out-of-tree driver;
I am responsible for the mainline port and the mistakes in it.
Thanks,
Metehan Günen
next prev parent reply other threads:[~2026-07-19 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 8:14 [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 8:14 ` [PATCH 1/4] include/uapi/linux: add gxfp_ioctl.h for GXFP5130 fingerprint sensor Metehan Günen
2026-07-18 9:07 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 9:08 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver Metehan Günen
2026-07-18 9:09 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:12 ` Greg KH
2026-07-18 9:12 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 3/4] Documentation/misc-devices: add gxfp5130.rst Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-18 8:14 ` [PATCH 4/4] MAINTAINERS: add entry for GXFP5130 fingerprint sensor driver Metehan Günen
2026-07-18 9:06 ` Greg KH
2026-07-19 10:53 ` Metehan Günen [this message]
2026-07-19 11:10 ` Greg KH
2026-07-18 9:05 ` [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI " Greg KH
2026-07-19 10:53 ` Metehan Günen
2026-07-19 11:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5cac94.b39440a8.65068.27ee@mx.google.com \
--to=metehangnen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox