* [PATCH] gpio: altera: Fix build failure caused by undeclared 'irq'
@ 2026-09-03 3:07 phucduc.bui
2026-09-03 9:05 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: phucduc.bui @ 2026-09-03 3:07 UTC (permalink / raw)
To: Adrian Ng, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel
Cc: bui duc phuc, Mark Brown
From: bui duc phuc <phucduc.bui@gmail.com>
Use 'mapped_irq' instead of the undefined 'irq' variable in
altera_gpio_probe().
The incorrect variable name causes the driver to fail to build with
an 'irq' undeclared error.
Fixes: 6e6e585b603e4 ("gpio: altera: Handle errors from optional IRQ lookup")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/apgNYDiSiPmNZspF@sirena.org.uk/
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/gpio/gpio-altera.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index d22f5be00745..a6ac9356229c 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -221,8 +221,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
mapped_irq = platform_get_irq_optional(pdev, 0);
if (mapped_irq < 0) {
- if (irq != -ENXIO)
- return irq;
+ if (mapped_irq != -ENXIO)
+ return mapped_irq;
goto skip_irq;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: altera: Fix build failure caused by undeclared 'irq'
2026-09-03 3:07 [PATCH] gpio: altera: Fix build failure caused by undeclared 'irq' phucduc.bui
@ 2026-09-03 9:05 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2026-09-03 9:05 UTC (permalink / raw)
To: Adrian Ng, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel, phucduc.bui
Cc: Bartosz Golaszewski, Mark Brown
On Thu, 03 Sep 2026 10:07:00 +0700, phucduc.bui@gmail.com wrote:
> Use 'mapped_irq' instead of the undefined 'irq' variable in
> altera_gpio_probe().
>
> The incorrect variable name causes the driver to fail to build with
> an 'irq' undeclared error.
>
>
> [...]
Applied, thanks!
[1/1] gpio: altera: Fix build failure caused by undeclared 'irq'
https://git.kernel.org/brgl/c/a2cfc48fee416f0ea78e7dc38acbf2ce072574cc
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-03 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-03 3:07 [PATCH] gpio: altera: Fix build failure caused by undeclared 'irq' phucduc.bui
2026-09-03 9:05 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox