[PATCH v2] hte: tegra-194: Use proper includes

[PATCH v2] hte: tegra-194: Use proper includes

[Linus Walleij]

The test driver uses the gpiod consumer API so include the right
<linux/gpio/consumer.h> header. This may cause a problem with
struct of_device_id being implcitly pulled in by the legacy
header <linux/gpio.h> so include <linux/mod_devicetable.h>
explicitly as well.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Its mod_devicetable not mod_device_table oops.
---
 drivers/hte/hte-tegra194-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
index 5d776a185bd6..79eb866558d3 100644
--- a/drivers/hte/hte-tegra194-test.c
+++ b/drivers/hte/hte-tegra194-test.c
@@ -6,10 +6,11 @@
  */
 
 #include <linux/err.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/timer.h>
 #include <linux/platform_device.h>
 #include <linux/workqueue.h>
-- 
2.34.1

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Dipen Patel]

On 1/17/23 12:41 AM, Linus Walleij wrote:
> The test driver uses the gpiod consumer API so include the right
> <linux/gpio/consumer.h> header. This may cause a problem with
> struct of_device_id being implcitly pulled in by the legacy
> header <linux/gpio.h> so include <linux/mod_devicetable.h>
> explicitly as well.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Its mod_devicetable not mod_device_table oops.
> ---
>  drivers/hte/hte-tegra194-test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index 5d776a185bd6..79eb866558d3 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -6,10 +6,11 @@
>   */
>  
>  #include <linux/err.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/interrupt.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/timer.h>
>  #include <linux/platform_device.h>
>  #include <linux/workqueue.h>

I am not sure if I have followed up on this patchset. It seems this gives an error mod_devicetable.h not found. Perhaps you meant, linux/mod_devicetable.h instead?

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Linus Walleij]

On Thu, Apr 20, 2023 at 10:19 PM Dipen Patel <dipenp@nvidia.com> wrote:
> On 1/17/23 12:41 AM, Linus Walleij wrote:

> > ChangeLog v1->v2:
> > - Its mod_devicetable not mod_device_table oops.
(...)
> > +#include <linux/mod_devicetable.h>
(...)
>
> I am not sure if I have followed up on this patchset. It seems this gives an
> error mod_devicetable.h not found. Perhaps you meant,
> linux/mod_devicetable.h instead?

Hm are you using v1? That had <linux/mod_device_table.h> (one too
much underscore) by mistake, this v2 should work? What is
the output of the compiler?

Yours,
Linus Walleij

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Dipen Patel]

On 4/20/23 1:48 PM, Linus Walleij wrote:
> On Thu, Apr 20, 2023 at 10:19 PM Dipen Patel <dipenp@nvidia.com> wrote:
>> On 1/17/23 12:41 AM, Linus Walleij wrote:
> 
>>> ChangeLog v1->v2:
>>> - Its mod_devicetable not mod_device_table oops.
> (...)
>>> +#include <linux/mod_devicetable.h>
> (...)
>>
>> I am not sure if I have followed up on this patchset. It seems this gives an
>> error mod_devicetable.h not found. Perhaps you meant,
>> linux/mod_devicetable.h instead?
> 
> Hm are you using v1? That had <linux/mod_device_table.h> (one too
> much underscore) by mistake, this v2 should work? What is
> the output of the compiler?
> 
> Yours,
> Linus Walleij

Sorry I referenced v1. This however clash with Arnd's patch (https://www.spinics.net/lists/linux-tegra/msg70013.html) that adds the header.
I guess I should be able to pull your changes with some conflict resolutions. Thanks.

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Dipen Patel]

On 1/17/23 12:41 AM, Linus Walleij wrote:
> The test driver uses the gpiod consumer API so include the right
> <linux/gpio/consumer.h> header. This may cause a problem with
> struct of_device_id being implcitly pulled in by the legacy
> header <linux/gpio.h> so include <linux/mod_devicetable.h>
> explicitly as well.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
I will push this patch to HTE subsystem tree...

Acked-by: Dipen Patel <dipenp@nvidia.com>

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Dipen Patel]

On 4/20/23 2:22 PM, Dipen Patel wrote:
> On 1/17/23 12:41 AM, Linus Walleij wrote:
>> The test driver uses the gpiod consumer API so include the right
>> <linux/gpio/consumer.h> header. This may cause a problem with
>> struct of_device_id being implcitly pulled in by the legacy
>> header <linux/gpio.h> so include <linux/mod_devicetable.h>
>> explicitly as well.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> I will push this patch to HTE subsystem tree...
> 
> Acked-by: Dipen Patel <dipenp@nvidia.com>
> 
Sorry for spamming your inbox, it seems https://patchwork.kernel.org/project/linux-media/patch/20230208173343.37582-4-andriy.shevchenko@linux.intel.com/
is the latest version of the patch and its been there since Feb 2023. Do you want me to push that patch through HTE sub tree?

Re: [PATCH v2] hte: tegra-194: Use proper includes

[Linus Walleij]

On Thu, Apr 20, 2023 at 11:48 PM Dipen Patel <dipenp@nvidia.com> wrote:
> On 4/20/23 2:22 PM, Dipen Patel wrote:
> > On 1/17/23 12:41 AM, Linus Walleij wrote:
> >> The test driver uses the gpiod consumer API so include the right
> >> <linux/gpio/consumer.h> header. This may cause a problem with
> >> struct of_device_id being implcitly pulled in by the legacy
> >> header <linux/gpio.h> so include <linux/mod_devicetable.h>
> >> explicitly as well.
> >>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > I will push this patch to HTE subsystem tree...
> >
> > Acked-by: Dipen Patel <dipenp@nvidia.com>
> >
> Sorry for spamming your inbox, it seems
> https://patchwork.kernel.org/project/linux-media/patch/20230208173343.37582-4-andriy.shevchenko@linux.intel.com/
> is the latest version of the patch and its been there since Feb 2023.
> Do you want me to push that patch through HTE sub tree?

Yes please! :)

I think Andy's series is partially merged but indeed this one patch
isn't in linux-next. Also it definietly makes things easier with this
patch upstream.

Yours,
Linus Walleij