public inbox for linux-gpio@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] intel-gpio for 6.16-1
@ 2025-05-20 19:45 Andy Shevchenko
  2025-05-21  8:44 ` Bartosz Golaszewski
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-20 19:45 UTC (permalink / raw)
  To: Linux GPIO; +Cc: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko

Hi Linux GPIO  maintainers,

The GPIO ACPI code rework is in this PR. The patches are in Linux Next
for at least a few days. However, one regression was reported and fixed
immediately, which becomes the last patch in the PR. It wasn't in Linux Next
since there was no Linux Next on this week. Nonetheless, Randy Dunlap tested
it independently, that's why I include it into PR (without this the checkpatch
and make htmldocs warn).

Please, pull for v6.16-rc1.

Thanks,

With Best Regards,
Andy Shevchenko

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

  Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git tags/intel-gpio-v6.16-1

for you to fetch changes up to 6f09a17d60410e805ae112fbbfa3ed8ecd0636dd:

  gpiolib-acpi: Update file references in the Documentation and MAINTAINERS (2025-05-20 22:30:51 +0300)

----------------------------------------------------------------
intel-gpio for v6.16-1

* Converted two Intel GPIO drivers to use new value setters
* Split GPIO ACPI quirks to its own file
* Refactored GPIO ACPI library to shrink the code

The following is an automated git shortlog grouped by driver:

gpiolib:
 -  acpi: Update file references in the Documentation and MAINTAINERS
 -  acpi: Move quirks to a separate file
 -  acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
 -  acpi: Handle deferred list via new API
 -  acpi: Switch to use enum in acpi_gpio_in_ignore_list()
 -  acpi: Make sure we fill struct acpi_gpio_info
 -  acpi: Use temporary variable for struct acpi_gpio_info
 -  acpi: Deduplicate some code in __acpi_find_gpio()
 -  acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
 -  acpi: Rename par to params for better readability
 -  acpi: Reduce memory footprint for struct acpi_gpio_params
 -  acpi: Remove index parameter from acpi_gpio_property_lookup()
 -  acpi: Improve struct acpi_gpio_info memory footprint

graniterapids:
 -  use new line value setter callbacks

ich:
 -  use new line value setter callbacks

----------------------------------------------------------------
Andy Shevchenko (16):
      gpiolib: acpi: Improve struct acpi_gpio_info memory footprint
      gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup()
      gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params
      gpiolib: acpi: Rename par to params for better readability
      gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
      gpiolib: acpi: Deduplicate some code in __acpi_find_gpio()
      Merge patch series "gpiolib: acpi: Refactor to shrink the code by ~8%"
      gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
      gpiolib: acpi: Make sure we fill struct acpi_gpio_info
      Merge patch series "gpiolib: acpi: Fix missing info filling"
      gpiolib: acpi: Switch to use enum in acpi_gpio_in_ignore_list()
      gpiolib: acpi: Handle deferred list via new API
      gpiolib: acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
      gpiolib: acpi: Move quirks to a separate file
      Merge patch series "gpiolib: acpi: Split quirks to its own file"
      gpiolib-acpi: Update file references in the Documentation and MAINTAINERS

Bartosz Golaszewski (2):
      gpio: graniterapids: use new line value setter callbacks
      gpio: ich: use new line value setter callbacks

 Documentation/driver-api/gpio/index.rst            |   2 +-
 .../translations/zh_CN/driver-api/gpio/index.rst   |   2 +-
 MAINTAINERS                                        |   2 +-
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-graniterapids.c                  |   6 +-
 drivers/gpio/gpio-ich.c                            |  12 +-
 .../gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c}   | 522 ++++-----------------
 drivers/gpio/gpiolib-acpi-quirks.c                 | 363 ++++++++++++++
 drivers/gpio/gpiolib-acpi.h                        |  15 +
 drivers/platform/x86/intel/int0002_vgpio.c         |   2 +-
 include/linux/gpio/consumer.h                      |   2 +-
 11 files changed, 497 insertions(+), 432 deletions(-)
 rename drivers/gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c} (72%)
 create mode 100644 drivers/gpio/gpiolib-acpi-quirks.c

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-20 19:45 [GIT PULL] intel-gpio for 6.16-1 Andy Shevchenko
@ 2025-05-21  8:44 ` Bartosz Golaszewski
  2025-05-21  9:03   ` Andy Shevchenko
  0 siblings, 1 reply; 11+ messages in thread
From: Bartosz Golaszewski @ 2025-05-21  8:44 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linux GPIO, Linus Walleij

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Hi Linux GPIO  maintainers,
>
> The GPIO ACPI code rework is in this PR. The patches are in Linux Next
> for at least a few days. However, one regression was reported and fixed
> immediately, which becomes the last patch in the PR. It wasn't in Linux Next
> since there was no Linux Next on this week. Nonetheless, Randy Dunlap tested
> it independently, that's why I include it into PR (without this the checkpatch
> and make htmldocs warn).
>
> Please, pull for v6.16-rc1.
>
> Thanks,
>
> With Best Regards,
> Andy Shevchenko
>
> The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:
>
>   Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git tags/intel-gpio-v6.16-1
>
> for you to fetch changes up to 6f09a17d60410e805ae112fbbfa3ed8ecd0636dd:
>
>   gpiolib-acpi: Update file references in the Documentation and MAINTAINERS (2025-05-20 22:30:51 +0300)
>
> ----------------------------------------------------------------
> intel-gpio for v6.16-1
>
> * Converted two Intel GPIO drivers to use new value setters
> * Split GPIO ACPI quirks to its own file
> * Refactored GPIO ACPI library to shrink the code
>
> The following is an automated git shortlog grouped by driver:
>
> gpiolib:
>  -  acpi: Update file references in the Documentation and MAINTAINERS
>  -  acpi: Move quirks to a separate file
>  -  acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
>  -  acpi: Handle deferred list via new API
>  -  acpi: Switch to use enum in acpi_gpio_in_ignore_list()
>  -  acpi: Make sure we fill struct acpi_gpio_info
>  -  acpi: Use temporary variable for struct acpi_gpio_info
>  -  acpi: Deduplicate some code in __acpi_find_gpio()
>  -  acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
>  -  acpi: Rename par to params for better readability
>  -  acpi: Reduce memory footprint for struct acpi_gpio_params
>  -  acpi: Remove index parameter from acpi_gpio_property_lookup()
>  -  acpi: Improve struct acpi_gpio_info memory footprint
>
> graniterapids:
>  -  use new line value setter callbacks
>
> ich:
>  -  use new line value setter callbacks
>
> ----------------------------------------------------------------
> Andy Shevchenko (16):
>       gpiolib: acpi: Improve struct acpi_gpio_info memory footprint
>       gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup()
>       gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params
>       gpiolib: acpi: Rename par to params for better readability
>       gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
>       gpiolib: acpi: Deduplicate some code in __acpi_find_gpio()
>       Merge patch series "gpiolib: acpi: Refactor to shrink the code by ~8%"
>       gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
>       gpiolib: acpi: Make sure we fill struct acpi_gpio_info
>       Merge patch series "gpiolib: acpi: Fix missing info filling"
>       gpiolib: acpi: Switch to use enum in acpi_gpio_in_ignore_list()
>       gpiolib: acpi: Handle deferred list via new API
>       gpiolib: acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
>       gpiolib: acpi: Move quirks to a separate file
>       Merge patch series "gpiolib: acpi: Split quirks to its own file"
>       gpiolib-acpi: Update file references in the Documentation and MAINTAINERS
>
> Bartosz Golaszewski (2):
>       gpio: graniterapids: use new line value setter callbacks
>       gpio: ich: use new line value setter callbacks

Hi Andy,

These have been in my gpio/for-next branch for a long time and the
ones in your PR have different commit hashes. Please remove them. I
don't see any notification about you having picked those up neither in
my inbox.

Bart

>
>  Documentation/driver-api/gpio/index.rst            |   2 +-
>  .../translations/zh_CN/driver-api/gpio/index.rst   |   2 +-
>  MAINTAINERS                                        |   2 +-
>  drivers/gpio/Makefile                              |   1 +
>  drivers/gpio/gpio-graniterapids.c                  |   6 +-
>  drivers/gpio/gpio-ich.c                            |  12 +-
>  .../gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c}   | 522 ++++-----------------
>  drivers/gpio/gpiolib-acpi-quirks.c                 | 363 ++++++++++++++
>  drivers/gpio/gpiolib-acpi.h                        |  15 +
>  drivers/platform/x86/intel/int0002_vgpio.c         |   2 +-
>  include/linux/gpio/consumer.h                      |   2 +-
>  11 files changed, 497 insertions(+), 432 deletions(-)
>  rename drivers/gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c} (72%)
>  create mode 100644 drivers/gpio/gpiolib-acpi-quirks.c
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  8:44 ` Bartosz Golaszewski
@ 2025-05-21  9:03   ` Andy Shevchenko
  2025-05-21  9:12     ` Bartosz Golaszewski
  2025-05-21  9:12     ` Andy Shevchenko
  0 siblings, 2 replies; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-21  9:03 UTC (permalink / raw)
  To: Bartosz Golaszewski; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...

> > Bartosz Golaszewski (2):
> >       gpio: graniterapids: use new line value setter callbacks
> >       gpio: ich: use new line value setter callbacks
> 
> These have been in my gpio/for-next branch for a long time and the
> ones in your PR have different commit hashes. Please remove them. I
> don't see any notification about you having picked those up neither in
> my inbox.

Really? I though I commented a few weeks ago that I prefer to take them
when Stephen complained on dups. After that there were no dups noticed.
Since you haven't answered to that email, I (rightfully) assumed you are
okay with the proposed course of actions.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:03   ` Andy Shevchenko
@ 2025-05-21  9:12     ` Bartosz Golaszewski
  2025-05-21  9:12     ` Andy Shevchenko
  1 sibling, 0 replies; 11+ messages in thread
From: Bartosz Golaszewski @ 2025-05-21  9:12 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:03 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> ...
>
> > > Bartosz Golaszewski (2):
> > >       gpio: graniterapids: use new line value setter callbacks
> > >       gpio: ich: use new line value setter callbacks
> >
> > These have been in my gpio/for-next branch for a long time and the
> > ones in your PR have different commit hashes. Please remove them. I
> > don't see any notification about you having picked those up neither in
> > my inbox.
>
> Really? I though I commented a few weeks ago that I prefer to take them
> when Stephen complained on dups. After that there were no dups noticed.
> Since you haven't answered to that email, I (rightfully) assumed you are
> okay with the proposed course of actions.
>

Can you point me to this email? I have not seen anything and can't
find anything.

Bartosz

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:03   ` Andy Shevchenko
  2025-05-21  9:12     ` Bartosz Golaszewski
@ 2025-05-21  9:12     ` Andy Shevchenko
  2025-05-21  9:18       ` Bartosz Golaszewski
  1 sibling, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-21  9:12 UTC (permalink / raw)
  To: Bartosz Golaszewski; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 12:03:47PM +0300, Andy Shevchenko wrote:
> On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:

...

> > > Bartosz Golaszewski (2):
> > >       gpio: graniterapids: use new line value setter callbacks
> > >       gpio: ich: use new line value setter callbacks
> > 
> > These have been in my gpio/for-next branch for a long time and the
> > ones in your PR have different commit hashes. Please remove them. I
> > don't see any notification about you having picked those up neither in
> > my inbox.
> 
> Really? I though I commented a few weeks ago that I prefer to take them
> when Stephen complained on dups. After that there were no dups noticed.
> Since you haven't answered to that email, I (rightfully) assumed you are
> okay with the proposed course of actions.

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/Z_OUr5xvoXh-sFne@smile.fi.intel.com/
https://lore.kernel.org/linux-gpio/Z_OS4nx2E12yjL7_@smile.fi.intel.com/
https://lore.kernel.org/linux-gpio/Z__xUsSeYNQAvnNp@smile.fi.intel.com/
https://lore.kernel.org/linux-next/aAEkrx0P5LFj1r6a@smile.fi.intel.com/

Note the last one, you didn't respond. So?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:12     ` Andy Shevchenko
@ 2025-05-21  9:18       ` Bartosz Golaszewski
  2025-05-21  9:24         ` Andy Shevchenko
  0 siblings, 1 reply; 11+ messages in thread
From: Bartosz Golaszewski @ 2025-05-21  9:18 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 21, 2025 at 12:03:47PM +0300, Andy Shevchenko wrote:
> > On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
>
> ...
>
> > > > Bartosz Golaszewski (2):
> > > >       gpio: graniterapids: use new line value setter callbacks
> > > >       gpio: ich: use new line value setter callbacks
> > >
> > > These have been in my gpio/for-next branch for a long time and the
> > > ones in your PR have different commit hashes. Please remove them. I
> > > don't see any notification about you having picked those up neither in
> > > my inbox.
> >
> > Really? I though I commented a few weeks ago that I prefer to take them
> > when Stephen complained on dups. After that there were no dups noticed.
> > Since you haven't answered to that email, I (rightfully) assumed you are
> > okay with the proposed course of actions.
>
> FWIW, check your mailbox:
> https://lore.kernel.org/linux-gpio/Z_OUr5xvoXh-sFne@smile.fi.intel.com/
> https://lore.kernel.org/linux-gpio/Z_OS4nx2E12yjL7_@smile.fi.intel.com/
> https://lore.kernel.org/linux-gpio/Z__xUsSeYNQAvnNp@smile.fi.intel.com/
> https://lore.kernel.org/linux-next/aAEkrx0P5LFj1r6a@smile.fi.intel.com/
>
> Note the last one, you didn't respond. So?

I really don't have them. Neither of the three. Probably gmail spam
filter borked? Anyway, would you mind removing them from your PR?

Bartosz

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:18       ` Bartosz Golaszewski
@ 2025-05-21  9:24         ` Andy Shevchenko
  2025-05-21  9:29           ` Bartosz Golaszewski
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-21  9:24 UTC (permalink / raw)
  To: Bartosz Golaszewski; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:18:11AM +0200, Bartosz Golaszewski wrote:
> On Wed, May 21, 2025 at 11:12 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, May 21, 2025 at 12:03:47PM +0300, Andy Shevchenko wrote:
> > > On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > > > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:

...

> > > > > Bartosz Golaszewski (2):
> > > > >       gpio: graniterapids: use new line value setter callbacks
> > > > >       gpio: ich: use new line value setter callbacks
> > > >
> > > > These have been in my gpio/for-next branch for a long time and the
> > > > ones in your PR have different commit hashes. Please remove them. I
> > > > don't see any notification about you having picked those up neither in
> > > > my inbox.
> > >
> > > Really? I though I commented a few weeks ago that I prefer to take them
> > > when Stephen complained on dups. After that there were no dups noticed.
> > > Since you haven't answered to that email, I (rightfully) assumed you are
> > > okay with the proposed course of actions.
> >
> > FWIW, check your mailbox:
> > https://lore.kernel.org/linux-gpio/Z_OUr5xvoXh-sFne@smile.fi.intel.com/
> > https://lore.kernel.org/linux-gpio/Z_OS4nx2E12yjL7_@smile.fi.intel.com/
> > https://lore.kernel.org/linux-gpio/Z__xUsSeYNQAvnNp@smile.fi.intel.com/
> > https://lore.kernel.org/linux-next/aAEkrx0P5LFj1r6a@smile.fi.intel.com/
> >
> > Note the last one, you didn't respond. So?
> 
> I really don't have them. Neither of the three. Probably gmail spam
> filter borked? Anyway, would you mind removing them from your PR?

Okay for this. But let's talk *again* about maintainership of
the Intel GPIO drivers.  Last time we discussed that you have
agreed that I'm in charge of that. If you think otherwise,
let me know.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:24         ` Andy Shevchenko
@ 2025-05-21  9:29           ` Bartosz Golaszewski
  2025-05-21  9:31             ` Andy Shevchenko
  0 siblings, 1 reply; 11+ messages in thread
From: Bartosz Golaszewski @ 2025-05-21  9:29 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 21, 2025 at 11:18:11AM +0200, Bartosz Golaszewski wrote:
> > On Wed, May 21, 2025 at 11:12 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Wed, May 21, 2025 at 12:03:47PM +0300, Andy Shevchenko wrote:
> > > > On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > > > > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
>
> ...
>
> > > > > > Bartosz Golaszewski (2):
> > > > > >       gpio: graniterapids: use new line value setter callbacks
> > > > > >       gpio: ich: use new line value setter callbacks
> > > > >
> > > > > These have been in my gpio/for-next branch for a long time and the
> > > > > ones in your PR have different commit hashes. Please remove them. I
> > > > > don't see any notification about you having picked those up neither in
> > > > > my inbox.
> > > >
> > > > Really? I though I commented a few weeks ago that I prefer to take them
> > > > when Stephen complained on dups. After that there were no dups noticed.
> > > > Since you haven't answered to that email, I (rightfully) assumed you are
> > > > okay with the proposed course of actions.
> > >
> > > FWIW, check your mailbox:
> > > https://lore.kernel.org/linux-gpio/Z_OUr5xvoXh-sFne@smile.fi.intel.com/
> > > https://lore.kernel.org/linux-gpio/Z_OS4nx2E12yjL7_@smile.fi.intel.com/
> > > https://lore.kernel.org/linux-gpio/Z__xUsSeYNQAvnNp@smile.fi.intel.com/
> > > https://lore.kernel.org/linux-next/aAEkrx0P5LFj1r6a@smile.fi.intel.com/
> > >
> > > Note the last one, you didn't respond. So?
> >
> > I really don't have them. Neither of the three. Probably gmail spam
> > filter borked? Anyway, would you mind removing them from your PR?
>
> Okay for this. But let's talk *again* about maintainership of
> the Intel GPIO drivers.  Last time we discussed that you have
> agreed that I'm in charge of that. If you think otherwise,
> let me know.
>

Ok, sorry for the misunderstanding but if I were to drop them, then
I'd have to rebase tens of patches that came later, it just makes more
sense for you to do it.

Maybe we need to think about putting intel GPIO drivers under their
own directory in v6.16, that would make it very clear which ones are
your territory?

Bart

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:29           ` Bartosz Golaszewski
@ 2025-05-21  9:31             ` Andy Shevchenko
  2025-05-21  9:50               ` Andy Shevchenko
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-21  9:31 UTC (permalink / raw)
  To: Bartosz Golaszewski; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:29:41AM +0200, Bartosz Golaszewski wrote:
> On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, May 21, 2025 at 11:18:11AM +0200, Bartosz Golaszewski wrote:
> > > On Wed, May 21, 2025 at 11:12 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Wed, May 21, 2025 at 12:03:47PM +0300, Andy Shevchenko wrote:
> > > > > On Wed, May 21, 2025 at 10:44:16AM +0200, Bartosz Golaszewski wrote:
> > > > > > On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
> > > > > > <andriy.shevchenko@linux.intel.com> wrote:

...

> > > > > > > Bartosz Golaszewski (2):
> > > > > > >       gpio: graniterapids: use new line value setter callbacks
> > > > > > >       gpio: ich: use new line value setter callbacks
> > > > > >
> > > > > > These have been in my gpio/for-next branch for a long time and the
> > > > > > ones in your PR have different commit hashes. Please remove them. I
> > > > > > don't see any notification about you having picked those up neither in
> > > > > > my inbox.
> > > > >
> > > > > Really? I though I commented a few weeks ago that I prefer to take them
> > > > > when Stephen complained on dups. After that there were no dups noticed.
> > > > > Since you haven't answered to that email, I (rightfully) assumed you are
> > > > > okay with the proposed course of actions.
> > > >
> > > > FWIW, check your mailbox:
> > > > https://lore.kernel.org/linux-gpio/Z_OUr5xvoXh-sFne@smile.fi.intel.com/
> > > > https://lore.kernel.org/linux-gpio/Z_OS4nx2E12yjL7_@smile.fi.intel.com/
> > > > https://lore.kernel.org/linux-gpio/Z__xUsSeYNQAvnNp@smile.fi.intel.com/
> > > > https://lore.kernel.org/linux-next/aAEkrx0P5LFj1r6a@smile.fi.intel.com/
> > > >
> > > > Note the last one, you didn't respond. So?
> > >
> > > I really don't have them. Neither of the three. Probably gmail spam
> > > filter borked? Anyway, would you mind removing them from your PR?
> >
> > Okay for this. But let's talk *again* about maintainership of
> > the Intel GPIO drivers.  Last time we discussed that you have
> > agreed that I'm in charge of that. If you think otherwise,
> > let me know.
> 
> Ok, sorry for the misunderstanding but if I were to drop them, then
> I'd have to rebase tens of patches that came later, it just makes more
> sense for you to do it.

I understand that, but it's an exceptional situation. Shouldn't be like
this ideally... I'm about to send an updated PR.

> Maybe we need to think about putting intel GPIO drivers under their
> own directory in v6.16, that would make it very clear which ones are
> your territory?

Okay, let me cook the change.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:31             ` Andy Shevchenko
@ 2025-05-21  9:50               ` Andy Shevchenko
  2025-05-21 10:11                 ` Bartosz Golaszewski
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2025-05-21  9:50 UTC (permalink / raw)
  To: Bartosz Golaszewski; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 12:31:57PM +0300, Andy Shevchenko wrote:
> On Wed, May 21, 2025 at 11:29:41AM +0200, Bartosz Golaszewski wrote:
> > On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:

...

> > Ok, sorry for the misunderstanding but if I were to drop them, then
> > I'd have to rebase tens of patches that came later, it just makes more
> > sense for you to do it.
> 
> I understand that, but it's an exceptional situation. Shouldn't be like
> this ideally... I'm about to send an updated PR.

Here we are (in case you missed my email):
aC2gABILEj1yRCxF@black.fi.intel.com


-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [GIT PULL] intel-gpio for 6.16-1
  2025-05-21  9:50               ` Andy Shevchenko
@ 2025-05-21 10:11                 ` Bartosz Golaszewski
  0 siblings, 0 replies; 11+ messages in thread
From: Bartosz Golaszewski @ 2025-05-21 10:11 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Linux GPIO, Linus Walleij

On Wed, May 21, 2025 at 11:50 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 21, 2025 at 12:31:57PM +0300, Andy Shevchenko wrote:
> > On Wed, May 21, 2025 at 11:29:41AM +0200, Bartosz Golaszewski wrote:
> > > On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
>
> ...
>
> > > Ok, sorry for the misunderstanding but if I were to drop them, then
> > > I'd have to rebase tens of patches that came later, it just makes more
> > > sense for you to do it.
> >
> > I understand that, but it's an exceptional situation. Shouldn't be like
> > this ideally... I'm about to send an updated PR.
>
> Here we are (in case you missed my email):
> aC2gABILEj1yRCxF@black.fi.intel.com
>

Now you're just being mean. :P

Bart

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-05-21 10:11 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 19:45 [GIT PULL] intel-gpio for 6.16-1 Andy Shevchenko
2025-05-21  8:44 ` Bartosz Golaszewski
2025-05-21  9:03   ` Andy Shevchenko
2025-05-21  9:12     ` Bartosz Golaszewski
2025-05-21  9:12     ` Andy Shevchenko
2025-05-21  9:18       ` Bartosz Golaszewski
2025-05-21  9:24         ` Andy Shevchenko
2025-05-21  9:29           ` Bartosz Golaszewski
2025-05-21  9:31             ` Andy Shevchenko
2025-05-21  9:50               ` Andy Shevchenko
2025-05-21 10:11                 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox