[PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[Yao Qi]

The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
(Modern Standby) when suspended with an external HDMI display connected.

This issue is caused by spurious ACPI event signaling routed through
GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.

Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
unwanted wakeups. This has been runtime-tested and verified using the
`gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.

Signed-off-by: Yao Qi <xnorigc@gmail.com>
---
 drivers/gpio/gpiolib-acpi-quirks.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index a0116f004..8d7d18b62 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -392,6 +392,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "VEN_0488:00@355",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from s2idle when suspended with an
+		 * external HDMI display connected.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401GM"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "AMDI0030:00@24",
+		},
+	},
 	{} /* Terminating entry */
 };
 
-- 
2.55.0

Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[Andy Shevchenko]

On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> (Modern Standby) when suspended with an external HDMI display connected.
> 
> This issue is caused by spurious ACPI event signaling routed through
> GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> 
> Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> unwanted wakeups. This has been runtime-tested and verified using the
> `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.

If AMD people will be quick enough to tag this, I will include in my PR to
Linus W. on next week.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[Linus Walleij]

On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:

> > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > (Modern Standby) when suspended with an external HDMI display connected.
> >
> > This issue is caused by spurious ACPI event signaling routed through
> > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> >
> > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > unwanted wakeups. This has been runtime-tested and verified using the
> > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
>
> If AMD people will be quick enough to tag this, I will include in my PR to
> Linus W. on next week.

To Bartosz?

It's gpiolib...

Yours,
Linus Walleij

Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[Andy Shevchenko]

On Mon, Aug 10, 2026 at 12:17:06AM +0200, Linus Walleij wrote:
> On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> 
> > > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > > (Modern Standby) when suspended with an external HDMI display connected.
> > >
> > > This issue is caused by spurious ACPI event signaling routed through
> > > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> > >
> > > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > > unwanted wakeups. This has been runtime-tested and verified using the
> > > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
> >
> > If AMD people will be quick enough to tag this, I will include in my PR to
> > Linus W. on next week.
> 
> To Bartosz?
> It's gpiolib...

Oh, true, I have also pin control stuff to send!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM

[Andy Shevchenko]

On Mon, Aug 10, 2026 at 11:36:19AM +0300, Andy Shevchenko wrote:
> On Mon, Aug 10, 2026 at 12:17:06AM +0200, Linus Walleij wrote:
> > On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> > 
> > > > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > > > (Modern Standby) when suspended with an external HDMI display connected.
> > > >
> > > > This issue is caused by spurious ACPI event signaling routed through
> > > > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > > > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> > > >
> > > > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > > > unwanted wakeups. This has been runtime-tested and verified using the
> > > > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
> > >
> > > If AMD people will be quick enough to tag this, I will include in my PR to
> > > Linus W. on next week.
> > 
> > To Bartosz?
> > It's gpiolib...
> 
> Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with
pin control stuff. So, Bart, if you feel confident about this patch, you can
take it directly. Here is my formal tag for that

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko