Re: [PATCH v6 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM

[Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>]

On 6/10/2026 11:48 AM, Krzysztof Kozlowski wrote:
> On 22/05/2026 22:46, Ajay Kumar Nandam wrote:
>> Convert the LPASS LPI pinctrl driver to use the PM clock framework for
>> runtime power management.
>>
>> This allows the LPASS LPI pinctrl driver to drop clock votes when idle,
>> improves power efficiency on platforms using LPASS LPI island mode, and
>> aligns the driver with common runtime PM patterns used across Qualcomm
>> LPASS subsystems.
>>
>> Guard GPIO register read/write helpers and slew-rate register programming
>> with synchronous runtime PM calls so the device is active during MMIO
>> operations whenever autosuspend is enabled.
>>
>> Make PINCTRL_LPASS_LPI depend on PM_CLK, since this patch introduces
>> direct PM clock API use in the shared core.
>>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>> ---
>>   drivers/pinctrl/qcom/Kconfig             |   1 +
>>   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 144 +++++++++++++++--------
>>   2 files changed, 99 insertions(+), 46 deletions(-)
>>
> 
> 
> It looks this introduces new build warnings:
> https://krzk.eu/#/builders/151/builds/303/steps/11/logs/stdio
> 
> Which you might have been notified about more than two weeks ago:
> https://lore.kernel.org/all/202605241040.1av35pgK-lkp@intel.com/
> 
> Best regards,
> Krzysztof



Hi Krzysztof,

Thanks for the report.

You're right — this was introduced by the runtime PM refactor, and the
unused lpi_gpio_write() was also reported earlier by the Intel CI.

I've addressed this with a follow-up fix removing the unused helper:
https://lore.kernel.org/all/20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com/


>