Re: [PATCH 0/7] ROSE: Misc fixes

["Bernard, f6bvp" <f6bvp@free.fr>]

Hello Ralf,

All seven patch applied.
However there are compile errors in rose_route.c

f6bvp-8 linux]# make modules
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC [M] net/rose/af_rose.o
CC [M] net/rose/rose_dev.o
CC [M] net/rose/rose_in.o
CC [M] net/rose/rose_link.o
CC [M] net/rose/rose_loopback.o
CC [M] net/rose/rose_out.o
CC [M] net/rose/rose_route.o
net/rose/rose_route.c: In function ‘rose_add_node’:
net/rose/rose_route.c:104: erreur: incompatible type for argument 2 of 
‘atomic_add_return’
/usr/src/linux-2.6.39/arch/x86/include/asm/atomic.h:173: note: expected 
‘struct atomic_t *’ but argument is of type ‘atomic_t’
net/rose/rose_route.c: In function ‘rose_add_loopback_neigh’:
net/rose/rose_route.c:391: erreur: incompatible type for argument 2 of 
‘atomic_add_return’
/usr/src/linux-2.6.39/arch/x86/include/asm/atomic.h:173: note: expected 
‘struct atomic_t *’ but argument is of type ‘atomic_t’
make[2]: *** [net/rose/rose_route.o] Erreur 1
make[1]: *** [net/rose] Erreur 2
make: *** [net] Erreur 2

73 de Bernard, f6bvp



Le 20/07/2011 11:00, Ralf Baechle a écrit :
> DaveM's recent email regarding a crash triggered by the attempt to send
> IP over rose prompted me to review the ROSE code again.  I found four
> race conditions and from what Bernard writes in a recent email about
> wrong rose_neighbour->use counters one of these fixes may actually be a
> practical problem.
>
>   - Patch [1/7] fixes a race that is unlikely to hit in a typical system and
>     even if so the result would be a very small number of packets attempted
>     to be sent to the wrong destination.
>   - Patch [2/7] is a cleanup preparing for [3/7]
>   - Patch [3/7] fixes the kernel side of the rose_callsign access race by
>     protecting it with a spinlock.
>   - Patch [4/7] makes struct rose_neigh member use an atomic_t.  This was
>     noticed by code review but hopefully fixes the mismatching use counter
>     recently reported by Bernard Pidoux.
>   - Patch [5/7] converts rose_neigh_no into an atomic_t.  Previously there
>     was a race condition which may have resulted in multiple rose_route
>     structures using the same rose_neigh_no value and rose_neigh_no being
>     incremented by fewer than the number of racing accesses.
>   - Patch [6/7] and [7/7] fix some coding style issues.
>
> Test reports would be apreciated.
>
> Thanks,
>
>    Ralf
>
> Ralf Baechle (7):
>    NET: ROSE: Fix race in SIOCRSSL2CALL ioctl accessing userspace.
>    NET: ROSE: Factor our common code from functions.
>    NET: ROSE: Protect rose_callsign with a spinlock
>    NET: ROSE: Make neighbour->use atomic
>    NET: ROSE: Make rose_neigh_no atomic.
>    NET: ROSE: Move return statements hidden behind an if to their own line
>    NET: ROSE: Fix formatting.
>
>   include/net/rose.h    |    7 +++++--
>   net/rose/af_rose.c    |   30 +++++++++++++++++++++---------
>   net/rose/rose_in.c    |   13 +++++++------
>   net/rose/rose_link.c  |   38 ++++++++++++++++++++++++--------------
>   net/rose/rose_route.c |   32 +++++++++++++++++---------------
>   net/rose/rose_subr.c  |    3 ++-
>   net/rose/rose_timer.c |    3 ++-
>   7 files changed, 78 insertions(+), 48 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html