* [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences
@ 2018-08-14 9:12 Dan Carpenter
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-08-14 9:12 UTC (permalink / raw)
To: Jean Delvare, Tokunori Ikegami
Cc: Guenter Roeck, linux-hwmon, kernel-janitors
The adt7475_update_device() function returns error pointers. The
problem is that in show_pwmfreq() we dereference it before the check.
And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at
all. I don't know if it's required, but it silences a static checker
warning and it's doesn't hurt anything to check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 90837f7c7d0f..16045149f3db 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -962,13 +962,14 @@ static ssize_t show_pwmfreq(struct device *dev, struct device_attribute *attr,
{
struct adt7475_data *data = adt7475_update_device(dev);
struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
- int i = clamp_val(data->range[sattr->index] & 0xf, 0,
- ARRAY_SIZE(pwmfreq_table) - 1);
+ int idx;
if (IS_ERR(data))
return PTR_ERR(data);
+ idx = clamp_val(data->range[sattr->index] & 0xf, 0,
+ ARRAY_SIZE(pwmfreq_table) - 1);
- return sprintf(buf, "%d\n", pwmfreq_table[i]);
+ return sprintf(buf, "%d\n", pwmfreq_table[idx]);
}
static ssize_t set_pwmfreq(struct device *dev, struct device_attribute *attr,
@@ -1004,6 +1005,10 @@ static ssize_t pwm_use_point2_pwm_at_crit_show(struct device *dev,
char *buf)
{
struct adt7475_data *data = adt7475_update_device(dev);
+
+ if (IS_ERR(data))
+ return PTR_ERR(data);
+
return sprintf(buf, "%d\n", !!(data->config4 & CONFIG4_MAXDUTY));
}
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks
2018-08-14 9:12 [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences Dan Carpenter
@ 2018-08-14 9:14 ` Dan Carpenter
2018-08-14 9:34 ` IKEGAMI Tokunori
2018-08-14 9:32 ` [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences IKEGAMI Tokunori
2018-08-14 13:39 ` Guenter Roeck
2 siblings, 1 reply; 12+ messages in thread
From: Dan Carpenter @ 2018-08-14 9:14 UTC (permalink / raw)
To: Jean Delvare, Tokunori Ikegami
Cc: Guenter Roeck, linux-hwmon, kernel-janitors
The adt7475_read_word() returns u16 values, so it's impossible for
"ret" to be negative. The check is harmless, but static checkers
complain about it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 16045149f3db..9d3da8ea38ba 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1492,10 +1492,7 @@ static int adt7475_update_limits(struct i2c_client *client)
for (i = 0; i < ADT7475_TACH_COUNT; i++) {
if (i == 3 && !data->has_fan4)
continue;
- ret = adt7475_read_word(client, TACH_MIN_REG(i));
- if (ret < 0)
- return ret;
- data->tach[MIN][i] = ret;
+ data->tach[MIN][i] = adt7475_read_word(client, TACH_MIN_REG(i));
}
for (i = 0; i < ADT7475_PWM_COUNT; i++) {
@@ -1881,10 +1878,7 @@ static int adt7475_update_measure(struct device *dev)
for (i = 0; i < ADT7475_TACH_COUNT; i++) {
if (i == 3 && !data->has_fan4)
continue;
- ret = adt7475_read_word(client, TACH_REG(i));
- if (ret < 0)
- return ret;
- data->tach[INPUT][i] = ret;
+ data->tach[INPUT][i] = adt7475_read_word(client, TACH_REG(i));
}
/* Updated by hw when in auto mode */
^ permalink raw reply related [flat|nested] 12+ messages in thread* RE: [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
@ 2018-08-14 9:34 ` IKEGAMI Tokunori
2018-08-14 9:57 ` Dan Carpenter
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
0 siblings, 2 replies; 12+ messages in thread
From: IKEGAMI Tokunori @ 2018-08-14 9:34 UTC (permalink / raw)
To: Dan Carpenter, Jean Delvare
Cc: Guenter Roeck, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan-san,
Thank you so much for this fix also.
Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
By the way I will do try to change the adt7475_read_word() to return the error correctly in near future.
Regards,
Ikegami
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, August 14, 2018 6:15 PM
> To: Jean Delvare; IKEGAMI Tokunori
> Cc: Guenter Roeck; linux-hwmon@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks
>
> The adt7475_read_word() returns u16 values, so it's impossible for
> "ret" to be negative. The check is harmless, but static checkers
> complain about it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 16045149f3db..9d3da8ea38ba 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1492,10 +1492,7 @@ static int adt7475_update_limits(struct
> i2c_client *client)
> for (i = 0; i < ADT7475_TACH_COUNT; i++) {
> if (i == 3 && !data->has_fan4)
> continue;
> - ret = adt7475_read_word(client, TACH_MIN_REG(i));
> - if (ret < 0)
> - return ret;
> - data->tach[MIN][i] = ret;
> + data->tach[MIN][i] = adt7475_read_word(client,
> TACH_MIN_REG(i));
> }
>
> for (i = 0; i < ADT7475_PWM_COUNT; i++) {
> @@ -1881,10 +1878,7 @@ static int adt7475_update_measure(struct device
> *dev)
> for (i = 0; i < ADT7475_TACH_COUNT; i++) {
> if (i == 3 && !data->has_fan4)
> continue;
> - ret = adt7475_read_word(client, TACH_REG(i));
> - if (ret < 0)
> - return ret;
> - data->tach[INPUT][i] = ret;
> + data->tach[INPUT][i] = adt7475_read_word(client,
> TACH_REG(i));
> }
>
> /* Updated by hw when in auto mode */
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks
2018-08-14 9:34 ` IKEGAMI Tokunori
@ 2018-08-14 9:57 ` Dan Carpenter
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
1 sibling, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-08-14 9:57 UTC (permalink / raw)
To: IKEGAMI Tokunori
Cc: Jean Delvare, Guenter Roeck, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Tue, Aug 14, 2018 at 09:34:30AM +0000, IKEGAMI Tokunori wrote:
> Hi Dan-san,
>
> Thank you so much for this fix also.
>
> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>
> By the way I will do try to change the adt7475_read_word() to return the error correctly in near future.
>
I can do that. Drop this patch. I will resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-14 9:34 ` IKEGAMI Tokunori
2018-08-14 9:57 ` Dan Carpenter
@ 2018-08-14 10:07 ` Dan Carpenter
2018-08-14 10:12 ` IKEGAMI Tokunori
2018-08-14 13:40 ` Guenter Roeck
1 sibling, 2 replies; 12+ messages in thread
From: Dan Carpenter @ 2018-08-14 10:07 UTC (permalink / raw)
To: Jean Delvare, IKEGAMI Tokunori
Cc: Guenter Roeck, linux-hwmon, kernel-janitors
The adt7475_read_word() function was meant to return negative error
codes on failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: In my first patch I just removed the error handling in the callers
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 90837f7c7d0f..ec03359536aa 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -302,14 +302,18 @@ static inline u16 volt2reg(int channel, long volt, u8 bypass_attn)
return clamp_val(reg, 0, 1023) & (0xff << 2);
}
-static u16 adt7475_read_word(struct i2c_client *client, int reg)
+static int adt7475_read_word(struct i2c_client *client, int reg)
{
- u16 val;
+ int val1, val2;
- val = i2c_smbus_read_byte_data(client, reg);
- val |= (i2c_smbus_read_byte_data(client, reg + 1) << 8);
+ val1 = i2c_smbus_read_byte_data(client, reg);
+ if (val1 < 0)
+ return val1;
+ val2 = i2c_smbus_read_byte_data(client, reg + 1);
+ if (val2 < 0)
+ return val2;
- return val;
+ return val1 | (val2 << 8);
}
static void adt7475_write_word(struct i2c_client *client, int reg, u16 val)
^ permalink raw reply related [flat|nested] 12+ messages in thread* RE: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
@ 2018-08-14 10:12 ` IKEGAMI Tokunori
2018-08-14 13:40 ` Guenter Roeck
1 sibling, 0 replies; 12+ messages in thread
From: IKEGAMI Tokunori @ 2018-08-14 10:12 UTC (permalink / raw)
To: Dan Carpenter, Jean Delvare
Cc: Guenter Roeck, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan-san,
Thank you so much.
Looks good.
Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Regards,
Ikegami
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, August 14, 2018 7:08 PM
> To: Jean Delvare; IKEGAMI Tokunori
> Cc: Guenter Roeck; linux-hwmon@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return
> errors
>
> The adt7475_read_word() function was meant to return negative error
> codes on failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: In my first patch I just removed the error handling in the callers
>
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 90837f7c7d0f..ec03359536aa 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -302,14 +302,18 @@ static inline u16 volt2reg(int channel, long volt,
> u8 bypass_attn)
> return clamp_val(reg, 0, 1023) & (0xff << 2);
> }
>
> -static u16 adt7475_read_word(struct i2c_client *client, int reg)
> +static int adt7475_read_word(struct i2c_client *client, int reg)
> {
> - u16 val;
> + int val1, val2;
>
> - val = i2c_smbus_read_byte_data(client, reg);
> - val |= (i2c_smbus_read_byte_data(client, reg + 1) << 8);
> + val1 = i2c_smbus_read_byte_data(client, reg);
> + if (val1 < 0)
> + return val1;
> + val2 = i2c_smbus_read_byte_data(client, reg + 1);
> + if (val2 < 0)
> + return val2;
>
> - return val;
> + return val1 | (val2 << 8);
> }
>
> static void adt7475_write_word(struct i2c_client *client, int reg, u16
> val)
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
2018-08-14 10:12 ` IKEGAMI Tokunori
@ 2018-08-14 13:40 ` Guenter Roeck
2018-08-15 6:02 ` IKEGAMI Tokunori
1 sibling, 1 reply; 12+ messages in thread
From: Guenter Roeck @ 2018-08-14 13:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jean Delvare, IKEGAMI Tokunori, linux-hwmon, kernel-janitors
On Tue, Aug 14, 2018 at 01:07:47PM +0300, Dan Carpenter wrote:
> The adt7475_read_word() function was meant to return negative error
> codes on failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-14 13:40 ` Guenter Roeck
@ 2018-08-15 6:02 ` IKEGAMI Tokunori
2018-08-15 12:37 ` Guenter Roeck
0 siblings, 1 reply; 12+ messages in thread
From: IKEGAMI Tokunori @ 2018-08-15 6:02 UTC (permalink / raw)
To: Guenter Roeck, Dan Carpenter
Cc: Jean Delvare, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Guenter-san,
Could you please let me know the git repository that applied the fixes by Dan-san?
Regards,
Ikegami
> -----Original Message-----
> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter
> Roeck
> Sent: Tuesday, August 14, 2018 10:41 PM
> To: Dan Carpenter
> Cc: Jean Delvare; IKEGAMI Tokunori; linux-hwmon@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word()
> return errors
>
> On Tue, Aug 14, 2018 at 01:07:47PM +0300, Dan Carpenter wrote:
> > The adt7475_read_word() function was meant to return negative error
> > codes on failure.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>
> Applied.
>
> Thanks,
> Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-15 6:02 ` IKEGAMI Tokunori
@ 2018-08-15 12:37 ` Guenter Roeck
2018-08-21 2:40 ` IKEGAMI Tokunori
0 siblings, 1 reply; 12+ messages in thread
From: Guenter Roeck @ 2018-08-15 12:37 UTC (permalink / raw)
To: IKEGAMI Tokunori, Dan Carpenter
Cc: Jean Delvare, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
On 08/14/2018 11:02 PM, IKEGAMI Tokunori wrote:
> Hi Guenter-san,
>
> Could you please let me know the git repository that applied the fixes by Dan-san?
>
Series now uploaded. I'll send a pull request to Linus after -rc1 has been published.
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon
Guenter
> Regards,
> Ikegami
>
>> -----Original Message-----
>> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter
>> Roeck
>> Sent: Tuesday, August 14, 2018 10:41 PM
>> To: Dan Carpenter
>> Cc: Jean Delvare; IKEGAMI Tokunori; linux-hwmon@vger.kernel.org;
>> kernel-janitors@vger.kernel.org
>> Subject: Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word()
>> return errors
>>
>> On Tue, Aug 14, 2018 at 01:07:47PM +0300, Dan Carpenter wrote:
>>> The adt7475_read_word() function was meant to return negative error
>>> codes on failure.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
>>
>> Applied.
>>
>> Thanks,
>> Guenter
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors
2018-08-15 12:37 ` Guenter Roeck
@ 2018-08-21 2:40 ` IKEGAMI Tokunori
0 siblings, 0 replies; 12+ messages in thread
From: IKEGAMI Tokunori @ 2018-08-21 2:40 UTC (permalink / raw)
To: Guenter Roeck, Dan Carpenter
Cc: Jean Delvare, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Guenter-san,
Thank you so much for the mail and noted it.
(But sorry for too late to reply since the mail was automatically moved from the mail receiving folder.)
Regards,
Ikegami
> -----Original Message-----
> From: linux-hwmon-owner@vger.kernel.org
> [mailto:linux-hwmon-owner@vger.kernel.org] On Behalf Of Guenter Roeck
> Sent: Wednesday, August 15, 2018 9:37 PM
> To: IKEGAMI Tokunori; Dan Carpenter
> Cc: Jean Delvare; linux-hwmon@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word()
> return errors
>
> On 08/14/2018 11:02 PM, IKEGAMI Tokunori wrote:
> > Hi Guenter-san,
> >
> > Could you please let me know the git repository that applied the fixes
> by Dan-san?
> >
>
> Series now uploaded. I'll send a pull request to Linus after -rc1 has
> been published.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.g
> it hwmon
>
> Guenter
>
> > Regards,
> > Ikegami
> >
> >> -----Original Message-----
> >> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter
> >> Roeck
> >> Sent: Tuesday, August 14, 2018 10:41 PM
> >> To: Dan Carpenter
> >> Cc: Jean Delvare; IKEGAMI Tokunori; linux-hwmon@vger.kernel.org;
> >> kernel-janitors@vger.kernel.org
> >> Subject: Re: [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word()
> >> return errors
> >>
> >> On Tue, Aug 14, 2018 at 01:07:47PM +0300, Dan Carpenter wrote:
> >>> The adt7475_read_word() function was meant to return negative error
> >>> codes on failure.
> >>>
> >>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >>> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> >>
> >> Applied.
> >>
> >> Thanks,
> >> Guenter
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences
2018-08-14 9:12 [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences Dan Carpenter
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
@ 2018-08-14 9:32 ` IKEGAMI Tokunori
2018-08-14 13:39 ` Guenter Roeck
2 siblings, 0 replies; 12+ messages in thread
From: IKEGAMI Tokunori @ 2018-08-14 9:32 UTC (permalink / raw)
To: Dan Carpenter, Jean Delvare
Cc: Guenter Roeck, linux-hwmon@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan-san,
Thank you so much for the fixes.
But very sorry for the problem caused by my changes.
I have reviewed them and those look good.
Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Regards,
Ikegami
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, August 14, 2018 6:13 PM
> To: Jean Delvare; IKEGAMI Tokunori
> Cc: Guenter Roeck; linux-hwmon@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH 1/2] hwmon: (adt7475) Potential error pointer
> dereferences
>
> The adt7475_update_device() function returns error pointers. The
> problem is that in show_pwmfreq() we dereference it before the check.
> And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at
> all. I don't know if it's required, but it silences a static checker
> warning and it's doesn't hurt anything to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 90837f7c7d0f..16045149f3db 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -962,13 +962,14 @@ static ssize_t show_pwmfreq(struct device *dev,
> struct device_attribute *attr,
> {
> struct adt7475_data *data = adt7475_update_device(dev);
> struct sensor_device_attribute_2 *sattr =
> to_sensor_dev_attr_2(attr);
> - int i = clamp_val(data->range[sattr->index] & 0xf, 0,
> - ARRAY_SIZE(pwmfreq_table) - 1);
> + int idx;
>
> if (IS_ERR(data))
> return PTR_ERR(data);
> + idx = clamp_val(data->range[sattr->index] & 0xf, 0,
> + ARRAY_SIZE(pwmfreq_table) - 1);
>
> - return sprintf(buf, "%d\n", pwmfreq_table[i]);
> + return sprintf(buf, "%d\n", pwmfreq_table[idx]);
> }
>
> static ssize_t set_pwmfreq(struct device *dev, struct device_attribute
> *attr,
> @@ -1004,6 +1005,10 @@ static ssize_t
> pwm_use_point2_pwm_at_crit_show(struct device *dev,
> char *buf)
> {
> struct adt7475_data *data = adt7475_update_device(dev);
> +
> + if (IS_ERR(data))
> + return PTR_ERR(data);
> +
> return sprintf(buf, "%d\n", !!(data->config4 &
> CONFIG4_MAXDUTY));
> }
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences
2018-08-14 9:12 [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences Dan Carpenter
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
2018-08-14 9:32 ` [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences IKEGAMI Tokunori
@ 2018-08-14 13:39 ` Guenter Roeck
2 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2018-08-14 13:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jean Delvare, Tokunori Ikegami, linux-hwmon, kernel-janitors
On Tue, Aug 14, 2018 at 12:12:36PM +0300, Dan Carpenter wrote:
> The adt7475_update_device() function returns error pointers. The
> problem is that in show_pwmfreq() we dereference it before the check.
> And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at
> all. I don't know if it's required, but it silences a static checker
> warning and it's doesn't hurt anything to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-08-21 5:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-14 9:12 [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences Dan Carpenter
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
2018-08-14 9:34 ` IKEGAMI Tokunori
2018-08-14 9:57 ` Dan Carpenter
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
2018-08-14 10:12 ` IKEGAMI Tokunori
2018-08-14 13:40 ` Guenter Roeck
2018-08-15 6:02 ` IKEGAMI Tokunori
2018-08-15 12:37 ` Guenter Roeck
2018-08-21 2:40 ` IKEGAMI Tokunori
2018-08-14 9:32 ` [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences IKEGAMI Tokunori
2018-08-14 13:39 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox