Re: [PATCH v2] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API

[Guenter Roeck <linux@roeck-us.net>]

On Thu, Sep 15, 2022 at 05:06:27PM +0800, Liang He wrote:
> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
> the of_find_compatible_node() which will automatically call
> of_node_put() for the 'from' argument.
> 
> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
> Co-developed-by: Mengda Chen <chenmengda2009@163.com>
> Signed-off-by: Mengda Chen <chenmengda2009@163.com>
> Signed-off-by: Liang He <windhl@126.com>

Sigh. The first signer is supposed to be the author.

Guenter

> ---
> 
>  v2: use proper tags advised by Guenter and based on Kernel Doc
> 
>  drivers/hwmon/gsc-hwmon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c
> index d64be48f1ef6..b60ec95b5edb 100644
> --- a/drivers/hwmon/gsc-hwmon.c
> +++ b/drivers/hwmon/gsc-hwmon.c
> @@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
>  	pdata->nchannels = nchannels;
>  
>  	/* fan controller base address */
> +	of_node_get(dev->parent->of_node);
>  	fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
>  	if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
>  		of_node_put(fan);
> -- 
> 2.25.1
>