From: Guenter Roeck <linux@roeck-us.net>
To: Liang He <windhl@126.com>
Cc: tharvey@gateworks.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, chenmengda2009@163.com
Subject: Re: Re: [PATCH v2] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API
Date: Thu, 15 Sep 2022 09:43:46 -0700 [thread overview]
Message-ID: <20220915164346.GA2994323@roeck-us.net> (raw)
In-Reply-To: <34c8065f.783c.18341453f34.Coremail.windhl@126.com>
On Thu, Sep 15, 2022 at 09:10:00PM +0800, Liang He wrote:
>
>
> At 2022-09-15 20:25:36, "Guenter Roeck" <linux@roeck-us.net> wrote:
> >On Thu, Sep 15, 2022 at 05:06:27PM +0800, Liang He wrote:
> >> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
> >> the of_find_compatible_node() which will automatically call
> >> of_node_put() for the 'from' argument.
> >>
> >> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
> >> Co-developed-by: Mengda Chen <chenmengda2009@163.com>
> >> Signed-off-by: Mengda Chen <chenmengda2009@163.com>
> >> Signed-off-by: Liang He <windhl@126.com>
> >
> >Sigh. The first signer is supposed to be the author.
> >
> >Guenter
>
> Hi, Guenter
>
> I search the commit history and found several recent but different commits
>
> This one is same with mine: Co-developed-by: A & SOB First & SOB Author, following the kernel doc
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=7e97cfed9929eaabc41829c395eb0d1350fccb9d
>
> But, this one is consistent with your advise: SOB Author & Co-developed-by: A & SOB A
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=ef69aa3a986ef94f01ce8b5b619f550db54432fe
>
Yes, I know, one can always find an example for everything
in the Linux kernel.
I expect the first signer to be the author, and the last signer
to be the person who sent me the patch.
Guenter
next prev parent reply other threads:[~2022-09-15 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:06 [PATCH v2] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API Liang He
2022-09-15 12:25 ` Guenter Roeck
2022-09-15 13:10 ` Liang He
2022-09-15 16:43 ` Guenter Roeck [this message]
2022-09-16 1:33 ` Re:Re: " Liang He
2022-09-16 10:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915164346.GA2994323@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chenmengda2009@163.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox