Re:Re: Re: [PATCH v2] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API

["Liang He" <windhl@126.com>]

At 2022-09-16 00:43:46, "Guenter Roeck" <linux@roeck-us.net> wrote:
>On Thu, Sep 15, 2022 at 09:10:00PM +0800, Liang He wrote:
>> 
>> 
>> At 2022-09-15 20:25:36, "Guenter Roeck" <linux@roeck-us.net> wrote:
>> >On Thu, Sep 15, 2022 at 05:06:27PM +0800, Liang He wrote:
>> >> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
>> >> the of_find_compatible_node() which will automatically call
>> >> of_node_put() for the 'from' argument.
>> >> 
>> >> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
>> >> Co-developed-by: Mengda Chen <chenmengda2009@163.com>
>> >> Signed-off-by: Mengda Chen <chenmengda2009@163.com>
>> >> Signed-off-by: Liang He <windhl@126.com>
>> >
>> >Sigh. The first signer is supposed to be the author.
>> >
>> >Guenter
>> 
>> Hi, Guenter
>> 
>> I search the commit history and found several recent but different commits 
>> 
>> This one is same with mine: Co-developed-by: A & SOB First & SOB Author,  following the kernel doc 
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=7e97cfed9929eaabc41829c395eb0d1350fccb9d
>> 
>> But, this one is consistent with your advise: SOB Author & Co-developed-by: A & SOB A
>> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.0-rc5&id=ef69aa3a986ef94f01ce8b5b619f550db54432fe
>> 
>
>Yes, I know, one can always find an example for everything
>in the Linux kernel.
>
>I expect the first signer to be the author, and the last signer
>to be the person who sent me the patch.
>
>Guenter

Thanks for your advice, so following tag order is acceptable?

Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Liang He <windhl@126.com>
Co-developed-by: Mengda Chen <chenmengda2009@163.com>
Signed-off-by: Mengda Chen <chenmengda2009@163.com>

If there is no problem, I will send a new version patch.

Thanks again.

Liang