* [PATCH] hwmon/occ: OCC sensors aren't arch-specific
@ 2022-10-24 8:15 Jeremy Kerr
2022-10-24 11:32 ` Guenter Roeck
2022-10-26 15:01 ` Guenter Roeck
0 siblings, 2 replies; 5+ messages in thread
From: Jeremy Kerr @ 2022-10-24 8:15 UTC (permalink / raw)
To: linux-hwmon; +Cc: Jean Delvare, Guenter Roeck, Eddie James, Joel Stanley
Commit c112d75840fb ("hwmon: OCC drivers are ARM-only") made the OCC
sensor drivers not selectable on powerpc64:
These drivers are for a BMC inside PowerPC servers. The BMC runs on
ARM hardware, so only propose the drivers on this architecture, unless
build-testing.
... but we now have a powerpc64 BMC (still for a powerpc64 host), so
drop the `depends on` that excludes building for this platform.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
drivers/hwmon/occ/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
index 35a7070db827..348c21100a37 100644
--- a/drivers/hwmon/occ/Kconfig
+++ b/drivers/hwmon/occ/Kconfig
@@ -6,7 +6,6 @@
config SENSORS_OCC_P8_I2C
tristate "POWER8 OCC through I2C"
depends on I2C
- depends on ARM || ARM64 || COMPILE_TEST
select SENSORS_OCC
help
This option enables support for monitoring sensors provided by the
@@ -21,7 +20,6 @@ config SENSORS_OCC_P8_I2C
config SENSORS_OCC_P9_SBE
tristate "POWER9 OCC through SBE"
depends on FSI_OCC
- depends on ARM || ARM64 || COMPILE_TEST
select SENSORS_OCC
help
This option enables support for monitoring sensors provided by the
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon/occ: OCC sensors aren't arch-specific
2022-10-24 8:15 [PATCH] hwmon/occ: OCC sensors aren't arch-specific Jeremy Kerr
@ 2022-10-24 11:32 ` Guenter Roeck
2022-10-24 12:51 ` Jeremy Kerr
2022-10-26 15:01 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2022-10-24 11:32 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: linux-hwmon, Jean Delvare, Eddie James, Joel Stanley
On Mon, Oct 24, 2022 at 04:15:27PM +0800, Jeremy Kerr wrote:
> Commit c112d75840fb ("hwmon: OCC drivers are ARM-only") made the OCC
> sensor drivers not selectable on powerpc64:
>
> These drivers are for a BMC inside PowerPC servers. The BMC runs on
> ARM hardware, so only propose the drivers on this architecture, unless
> build-testing.
>
> ... but we now have a powerpc64 BMC (still for a powerpc64 host), so
> drop the `depends on` that excludes building for this platform.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Should the original patch be reverted instead, and should the revert
be backported ? In other words, is this a bug fix which needs to be
applied to v6.1, or is it needed for v6.2+ only ?
Thanks,
Guenter
> ---
> drivers/hwmon/occ/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
> index 35a7070db827..348c21100a37 100644
> --- a/drivers/hwmon/occ/Kconfig
> +++ b/drivers/hwmon/occ/Kconfig
> @@ -6,7 +6,6 @@
> config SENSORS_OCC_P8_I2C
> tristate "POWER8 OCC through I2C"
> depends on I2C
> - depends on ARM || ARM64 || COMPILE_TEST
> select SENSORS_OCC
> help
> This option enables support for monitoring sensors provided by the
> @@ -21,7 +20,6 @@ config SENSORS_OCC_P8_I2C
> config SENSORS_OCC_P9_SBE
> tristate "POWER9 OCC through SBE"
> depends on FSI_OCC
> - depends on ARM || ARM64 || COMPILE_TEST
> select SENSORS_OCC
> help
> This option enables support for monitoring sensors provided by the
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon/occ: OCC sensors aren't arch-specific
2022-10-24 11:32 ` Guenter Roeck
@ 2022-10-24 12:51 ` Jeremy Kerr
2022-10-25 3:07 ` Joel Stanley
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Kerr @ 2022-10-24 12:51 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, Jean Delvare, Eddie James, Joel Stanley
Hi Guenter,
> Should the original patch be reverted instead, and should the revert
> be backported ? In other words, is this a bug fix which needs to be
> applied to v6.1, or is it needed for v6.2+ only ?
This isn't a regression, we're just enabling this driver on a new
hardware implementation. No need to backport either.
I don't think that warrants a revert, as having a separate change means
we keep the rationale for both changes in the git history.
Cheers,
Jeremy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon/occ: OCC sensors aren't arch-specific
2022-10-24 12:51 ` Jeremy Kerr
@ 2022-10-25 3:07 ` Joel Stanley
0 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2022-10-25 3:07 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: Guenter Roeck, linux-hwmon, Jean Delvare, Eddie James
On Mon, 24 Oct 2022 at 12:51, Jeremy Kerr <jk@codeconstruct.com.au> wrote:
>
> Hi Guenter,
>
> > Should the original patch be reverted instead, and should the revert
> > be backported ? In other words, is this a bug fix which needs to be
> > applied to v6.1, or is it needed for v6.2+ only ?
>
> This isn't a regression, we're just enabling this driver on a new
> hardware implementation. No need to backport either.
>
> I don't think that warrants a revert, as having a separate change means
> we keep the rationale for both changes in the git history.
That makes sense to me.
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon/occ: OCC sensors aren't arch-specific
2022-10-24 8:15 [PATCH] hwmon/occ: OCC sensors aren't arch-specific Jeremy Kerr
2022-10-24 11:32 ` Guenter Roeck
@ 2022-10-26 15:01 ` Guenter Roeck
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2022-10-26 15:01 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: linux-hwmon, Jean Delvare, Eddie James, Joel Stanley
On Mon, Oct 24, 2022 at 04:15:27PM +0800, Jeremy Kerr wrote:
> Commit c112d75840fb ("hwmon: OCC drivers are ARM-only") made the OCC
> sensor drivers not selectable on powerpc64:
>
> These drivers are for a BMC inside PowerPC servers. The BMC runs on
> ARM hardware, so only propose the drivers on this architecture, unless
> build-testing.
>
> ... but we now have a powerpc64 BMC (still for a powerpc64 host), so
> drop the `depends on` that excludes building for this platform.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Acked-by: Joel Stanley <joel@jms.id.au>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/occ/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
> index 35a7070db827..348c21100a37 100644
> --- a/drivers/hwmon/occ/Kconfig
> +++ b/drivers/hwmon/occ/Kconfig
> @@ -6,7 +6,6 @@
> config SENSORS_OCC_P8_I2C
> tristate "POWER8 OCC through I2C"
> depends on I2C
> - depends on ARM || ARM64 || COMPILE_TEST
> select SENSORS_OCC
> help
> This option enables support for monitoring sensors provided by the
> @@ -21,7 +20,6 @@ config SENSORS_OCC_P8_I2C
> config SENSORS_OCC_P9_SBE
> tristate "POWER9 OCC through SBE"
> depends on FSI_OCC
> - depends on ARM || ARM64 || COMPILE_TEST
> select SENSORS_OCC
> help
> This option enables support for monitoring sensors provided by the
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-26 15:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 8:15 [PATCH] hwmon/occ: OCC sensors aren't arch-specific Jeremy Kerr
2022-10-24 11:32 ` Guenter Roeck
2022-10-24 12:51 ` Jeremy Kerr
2022-10-25 3:07 ` Joel Stanley
2022-10-26 15:01 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox