[groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head:   68ca2db26850ff7eb72388e237103c56db7b4a84
commit: 6652888f0379f01027bb1d7bbdb377710833b4f2 [13/34] hwmon: add fan speed monitoring driver for Surface devices
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240203/202402031253.JPVKEF5X-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240203/202402031253.JPVKEF5X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402031253.JPVKEF5X-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible' [-Wmissing-prototypes]
      22 | umode_t surface_fan_hwmon_is_visible(const void *drvdata,
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/surface_fan_hwmon_is_visible +22 drivers/hwmon/surface_fan.c

    20	
    21	// hwmon
  > 22	umode_t surface_fan_hwmon_is_visible(const void *drvdata,
    23					     enum hwmon_sensor_types type, u32 attr,
    24					     int channel)
    25	{
    26		return 0444;
    27	}
    28	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[Ivor Wanders]

> >> drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible' [-Wmissing-prototypes]
>      22 | umode_t surface_fan_hwmon_is_visible(const void *drvdata,

I tried reproducing this, but I think this issue is already fixed in the
most recent hwmon-next?
The function should've been marked `static`. It wasn't in the original v5
patch, but the current commit in the tree (216d66aa89f9fc882) already marks
the function static, resolving the issue.

~Ivor

Re: [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[Guenter Roeck]

On 2/3/24 04:52, Ivor Wanders wrote:
>>>> drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible' [-Wmissing-prototypes]
>>       22 | umode_t surface_fan_hwmon_is_visible(const void *drvdata,
> 
> I tried reproducing this, but I think this issue is already fixed in the
> most recent hwmon-next?
> The function should've been marked `static`. It wasn't in the original v5
> patch, but the current commit in the tree (216d66aa89f9fc882) already marks
> the function static, resolving the issue.
> 

Yes, I already fixed this up.

Guenter

Re: [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[Ivor Wanders]

> Yes, I already fixed this up.

Appreciate the confirmation, thank you for fixing this.

~Ivor

Re: [groeck-staging:hwmon-next 13/34] drivers/hwmon/surface_fan.c:22:9: warning: no previous prototype for 'surface_fan_hwmon_is_visible'

[Guenter Roeck]

On 2/3/24 06:16, Ivor Wanders wrote:
>> Yes, I already fixed this up.
> 
> Appreciate the confirmation, thank you for fixing this.
> 

No worries. Sorry, I should have added a note to the commit message,
but it was late last night and I forgot. I'll do that now.

Guenter