Linux Hardware Monitor development
 help / color / mirror / Atom feed
* [PATCH] hwmon: (shtc1) Fix property misspelling
@ 2024-05-30 15:23 Guenter Roeck
  2024-06-05  6:02 ` Chris Ruehl
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2024-05-30 15:23 UTC (permalink / raw)
  To: Hardware Monitoring; +Cc: Jean Delvare, Guenter Roeck, Chris Ruehl

The property name is "sensirion,low-precision", not
"sensicon,low-precision".

Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Fixes: be7373b60df5 ("hwmon: shtc1: add support for device tree bindings")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/shtc1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c
index 1f96e94967ee..439dd3dba5fc 100644
--- a/drivers/hwmon/shtc1.c
+++ b/drivers/hwmon/shtc1.c
@@ -238,7 +238,7 @@ static int shtc1_probe(struct i2c_client *client)
 
 	if (np) {
 		data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io");
-		data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision");
+		data->setup.high_precision = !of_property_read_bool(np, "sensirion,low-precision");
 	} else {
 		if (client->dev.platform_data)
 			data->setup = *(struct shtc1_platform_data *)dev->platform_data;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwmon: (shtc1) Fix property misspelling
  2024-05-30 15:23 [PATCH] hwmon: (shtc1) Fix property misspelling Guenter Roeck
@ 2024-06-05  6:02 ` Chris Ruehl
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Ruehl @ 2024-06-05  6:02 UTC (permalink / raw)
  To: Guenter Roeck, Hardware Monitoring; +Cc: Jean Delvare

On 30/5/2024 23:23, Guenter Roeck wrote:
> The property name is "sensirion,low-precision", not
> "sensicon,low-precision".
> 
> Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> Fixes: be7373b60df5 ("hwmon: shtc1: add support for device tree bindings")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/hwmon/shtc1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c
> index 1f96e94967ee..439dd3dba5fc 100644
> --- a/drivers/hwmon/shtc1.c
> +++ b/drivers/hwmon/shtc1.c
> @@ -238,7 +238,7 @@ static int shtc1_probe(struct i2c_client *client)
>   
>   	if (np) {
>   		data->setup.blocking_io = of_property_read_bool(np, "sensirion,blocking-io");
> -		data->setup.high_precision = !of_property_read_bool(np, "sensicon,low-precision");
> +		data->setup.high_precision = !of_property_read_bool(np, "sensirion,low-precision");
>   	} else {
>   		if (client->dev.platform_data)
>   			data->setup = *(struct shtc1_platform_data *)dev->platform_data;

Strange how that can happen!
Thank you catch this misspelled property.

Reviewed-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-05  6:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 15:23 [PATCH] hwmon: (shtc1) Fix property misspelling Guenter Roeck
2024-06-05  6:02 ` Chris Ruehl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox