* [PATCH] hwmon: ltc2991: fix register bits defines
@ 2024-08-30 11:13 Pawel Dembicki
2024-09-01 13:40 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Dembicki @ 2024-08-30 11:13 UTC (permalink / raw)
To: linux-hwmon
Cc: Pawel Dembicki, Antoniu Miclaus, Jean Delvare, Guenter Roeck,
linux-kernel
In the LTC2991, V5 and V6 channels use the low nibble of the
"V5, V6, V7, and V8 Control Register" for configuration, but currently,
the high nibble is defined.
This patch changes the defines to use the low nibble.
Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
drivers/hwmon/ltc2991.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
index 573cd8f5721b..7ca139e4b6af 100644
--- a/drivers/hwmon/ltc2991.c
+++ b/drivers/hwmon/ltc2991.c
@@ -42,9 +42,9 @@
#define LTC2991_V7_V8_FILT_EN BIT(7)
#define LTC2991_V7_V8_TEMP_EN BIT(5)
#define LTC2991_V7_V8_DIFF_EN BIT(4)
-#define LTC2991_V5_V6_FILT_EN BIT(7)
-#define LTC2991_V5_V6_TEMP_EN BIT(5)
-#define LTC2991_V5_V6_DIFF_EN BIT(4)
+#define LTC2991_V5_V6_FILT_EN BIT(3)
+#define LTC2991_V5_V6_TEMP_EN BIT(1)
+#define LTC2991_V5_V6_DIFF_EN BIT(0)
#define LTC2991_REPEAT_ACQ_EN BIT(4)
#define LTC2991_T_INT_FILT_EN BIT(3)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: ltc2991: fix register bits defines
2024-08-30 11:13 [PATCH] hwmon: ltc2991: fix register bits defines Pawel Dembicki
@ 2024-09-01 13:40 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-09-01 13:40 UTC (permalink / raw)
To: Pawel Dembicki; +Cc: linux-hwmon, Antoniu Miclaus, Jean Delvare, linux-kernel
On Fri, Aug 30, 2024 at 01:13:50PM +0200, Pawel Dembicki wrote:
> In the LTC2991, V5 and V6 channels use the low nibble of the
> "V5, V6, V7, and V8 Control Register" for configuration, but currently,
> the high nibble is defined.
>
> This patch changes the defines to use the low nibble.
>
> Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ltc2991.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/ltc2991.c b/drivers/hwmon/ltc2991.c
> index 573cd8f5721b..7ca139e4b6af 100644
> --- a/drivers/hwmon/ltc2991.c
> +++ b/drivers/hwmon/ltc2991.c
> @@ -42,9 +42,9 @@
> #define LTC2991_V7_V8_FILT_EN BIT(7)
> #define LTC2991_V7_V8_TEMP_EN BIT(5)
> #define LTC2991_V7_V8_DIFF_EN BIT(4)
> -#define LTC2991_V5_V6_FILT_EN BIT(7)
> -#define LTC2991_V5_V6_TEMP_EN BIT(5)
> -#define LTC2991_V5_V6_DIFF_EN BIT(4)
> +#define LTC2991_V5_V6_FILT_EN BIT(3)
> +#define LTC2991_V5_V6_TEMP_EN BIT(1)
> +#define LTC2991_V5_V6_DIFF_EN BIT(0)
>
> #define LTC2991_REPEAT_ACQ_EN BIT(4)
> #define LTC2991_T_INT_FILT_EN BIT(3)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-01 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 11:13 [PATCH] hwmon: ltc2991: fix register bits defines Pawel Dembicki
2024-09-01 13:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox