From: Akshay Gupta <akshay.gupta@amd.com>
To: <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <linux@roeck-us.net>, <gregkh@linuxfoundation.org>,
<arnd@arndb.de>, <shyam-sundar.s-k@amd.com>,
<gautham.shenoy@amd.com>, <mario.limonciello@amd.com>,
<naveenkrishna.chatradhi@amd.com>, <anand.umarji@amd.com>,
Akshay Gupta <akshay.gupta@amd.com>
Subject: [PATCH v7 00/10] misc: Move AMD side band interface(SBI) functionality
Date: Wed, 2 Apr 2025 05:58:30 +0000 [thread overview]
Message-ID: <20250402055840.1346384-1-akshay.gupta@amd.com> (raw)
At present, sbrmi driver under hwmon subsystem, is probed as an i2c driver,
fetches data using APML specified protocol and reports through hwmon power sensor.
AMD provides additional information using custom protocols, which cannot be
enumerated as hwmon sensors. Hence, move the existing functionality from hwmon/
to misc/ and add support for following custom protocols
- read Processor feature capabilities and configuration information
through side band.
- read Machine Check Architecture(MCA) registers over sideband.
The information is accessed for range of MCA registers by passing
register address and thread ID to the protocol.
NOTE: AMD defines Advanced Platform Management Link (APML) interface which provides
system management functionality access to the baseboard management
controller (BMC).
This patchset is an attempt to keep all APML core functionality in one place,
provide hwmon and IOCTL interface to user space
1. [Patch 1] Move the i2c client probe, hwmon sensors and sbrmi core functionality
from drivers/hwmon to drivers/misc/
2. [Patch 2] Move sbrmi core functionality to new core file to export core functionality
3. [Patch 3] Move hwmon device sensor as separate entity
4. [Patch 4] Convert i2c to regmap which provides multiple benefits
over direct smbus APIs.
a. i2c/i3c support and
b. 1 byte/2 byte RMI register size addressing
5. [Patch 5] Optimize wait condition with regmap API regmap_read_poll_timeout as per
suggestion from Arnd
6. [Patch 6, 7] Register a misc device which provides
a. An ioctl interface through node /dev/sbrmiX
b. Register sets is common across APML protocols. IOCTL is providing
synchronization among protocols as transactions may create
race condition.
7. [Subsequent patches 8, 9 and 10] add support for AMD custom protocols
a. CPUID
b. MCAMSR
c. Register xfer
8. [Patch 11] AMD side band description document
Open-sourced and widely used [1]_ will continue to provide user-space programmable API.
.. [1] https://github.com/amd/esmi_oob_library
Akshay Gupta (10):
hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc
misc: amd-sbi: Move protocol functionality to core file
misc: amd-sbi: Move hwmon device sensor as separate entity
misc: amd-sbi: Use regmap subsystem
misc: amd-sbi: Optimize the wait condition for mailbox command
completion
misc: amd-sbi: Add support for AMD_SBI IOCTL
misc: amd-sbi: Add support for CPUID protocol
misc: amd-sbi: Add support for read MCA register protocol
misc: amd-sbi: Add support for register xfer
misc: amd-sbi: Add document for AMD SB IOCTL description
Documentation/misc-devices/amd-sbi.rst | 87 ++++
Documentation/misc-devices/index.rst | 1 +
.../userspace-api/ioctl/ioctl-number.rst | 2 +
drivers/hwmon/Kconfig | 10 -
drivers/hwmon/sbrmi.c | 357 --------------
drivers/misc/Kconfig | 1 +
drivers/misc/Makefile | 1 +
drivers/misc/amd-sbi/Kconfig | 9 +
drivers/misc/amd-sbi/Makefile | 3 +
drivers/misc/amd-sbi/rmi-core.c | 446 ++++++++++++++++++
drivers/misc/amd-sbi/rmi-core.h | 67 +++
drivers/misc/amd-sbi/rmi-hwmon.c | 125 +++++
drivers/misc/amd-sbi/rmi-i2c.c | 134 ++++++
include/uapi/misc/amd-apml.h | 97 ++++
14 files changed, 973 insertions(+), 367 deletions(-)
create mode 100644 Documentation/misc-devices/amd-sbi.rst
delete mode 100644 drivers/hwmon/sbrmi.c
create mode 100644 drivers/misc/amd-sbi/Kconfig
create mode 100644 drivers/misc/amd-sbi/Makefile
create mode 100644 drivers/misc/amd-sbi/rmi-core.c
create mode 100644 drivers/misc/amd-sbi/rmi-core.h
create mode 100644 drivers/misc/amd-sbi/rmi-hwmon.c
create mode 100644 drivers/misc/amd-sbi/rmi-i2c.c
create mode 100644 include/uapi/misc/amd-apml.h
--
2.25.1
next reply other threads:[~2025-04-02 5:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 5:58 Akshay Gupta [this message]
2025-04-02 5:58 ` [PATCH v7 01/10] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 02/10] misc: amd-sbi: Move protocol functionality to core file Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 03/10] misc: amd-sbi: Move hwmon device sensor as separate entity Akshay Gupta
2025-04-02 11:03 ` Arnd Bergmann
2025-04-07 11:31 ` Gupta, Akshay
2025-04-02 5:58 ` [PATCH v7 04/10] misc: amd-sbi: Use regmap subsystem Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 05/10] misc: amd-sbi: Optimize the wait condition for mailbox command completion Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 06/10] misc: amd-sbi: Add support for AMD_SBI IOCTL Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 07/10] misc: amd-sbi: Add support for CPUID protocol Akshay Gupta
2025-04-02 12:13 ` Arnd Bergmann
2025-04-02 12:16 ` Greg Kroah-Hartman
2025-04-07 11:31 ` Gupta, Akshay
2025-04-02 5:58 ` [PATCH v7 08/10] misc: amd-sbi: Add support for read MCA register protocol Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 09/10] misc: amd-sbi: Add support for register xfer Akshay Gupta
2025-04-02 5:58 ` [PATCH v7 10/10] misc: amd-sbi: Add document for AMD SB IOCTL description Akshay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402055840.1346384-1-akshay.gupta@amd.com \
--to=akshay.gupta@amd.com \
--cc=anand.umarji@amd.com \
--cc=arnd@arndb.de \
--cc=gautham.shenoy@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mario.limonciello@amd.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=shyam-sundar.s-k@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox