Re: [PATCH v3 01/13] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA

[sashiko-bot@kernel.org]

Sashiko AI review found 3 potential issue(s):
- [Medium] The `mipi-i3c-static-method` schema incorrectly enforces `minimum: 0x1`, preventing devices from declaring no static address assignment support.
- [Low] The `assigned-address` property description is now inaccurate and contradicts the new capabilities.
- [Low] Missing macro definition for Bit 2 ('Other CCC') in `include/dt-bindings/i3c/i3c.h`.
--

commit dbfc3abafb12042fa0c42239f7ff49c55d30eb3d
Author: Akhil R <akhilrajeev@nvidia.com>

dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA

This commit adds the 'mipi-i3c-static-method' property to specify which
discovery method an I3C device supports during bus initialization. The
property serves as a bitmap where each bit indicates support for methods
like SETDASA or SETAASA.

[1] https://www.mipi.org/mipi-disco-for-i3c-download

> diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml
> index e25fa72fd7857..225844abdd1fd 100644
> --- a/Documentation/devicetree/bindings/i3c/i3c.yaml
> +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml
[ ... ]
> @@ -147,6 +149,27 @@ patternProperties:
>            through SETDASA. If static address is not present, this address is assigned
>            through SETNEWDA after assigning a temporary address via ENTDAA.

Does the description for assigned-address need an update here? It currently
states that if a static address is present, the address is assigned through
SETDASA. This seems to contradict the new capabilities allowing SETAASA.

>  
> +      mipi-i3c-static-method:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0x1

The description below states that "0 indicates lack of support", but this
minimum validation prevents setting the bitmap to 0. If an I3C target has a
static address but relies purely on ENTDAA, how can a developer override the
default value of 1 to specify that no static methods are supported?

> +        maximum: 0x7
> +        default: 1
> +        description: |
> +          Bitmap describing which methods of Dynamic Address Assignment from a
> +          static address are supported by this I3C Target. A bit value of 1
> +          indicates support for that method, and 0 indicates lack of support.
> +
> +            Bit 0: SETDASA CCC (Direct)
> +            Bit 1: SETAASA CCC (Broadcast)
> +            Bit 2: Other CCC (vendor / standards extension)
> +            All other bits are reserved.
[ ... ]
> diff --git a/include/dt-bindings/i3c/i3c.h b/include/dt-bindings/i3c/i3c.h
> index 373439218bba6..8409addff0115 100644
> --- a/include/dt-bindings/i3c/i3c.h
> +++ b/include/dt-bindings/i3c/i3c.h
> @@ -13,4 +13,7 @@
>  #define I2C_NO_FILTER_HIGH_FREQUENCY    (1 << 5)
>  #define I2C_NO_FILTER_LOW_FREQUENCY     (2 << 5)
>  
> +#define I3C_ADDR_METHOD_SETDASA     (1 << 0)
> +#define I3C_ADDR_METHOD_SETAASA     (1 << 1)

Since Bit 2 is documented as "Other CCC" in the binding and the maximum value
allows combinations up to 0x7, should there be a macro defined for Bit 2?
Adding one could prevent device tree authors from needing to use magic
numbers to represent this capability.

> +
>  #endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260423085718.70762-1-akhilrajeev@nvidia.com?part=1