Re: [PATCH v3 02/13] ACPICA: Read LVR from the I2C resource descriptor

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Medium] The newly added `lvr` field in `struct acpi_resource_i2c_serialbus` is omitted from the resource dumping mechanism in `rsdumpinfo.c`.
--

commit 06f9727bd6ba574a252f3ac9267b0193a2f50dd1
Author: Akhil R <akhilrajeev@nvidia.com>

ACPICA: Read LVR from the I2C resource descriptor

This patch updates the ACPICA I2C serial bus descriptor handling to read
the legacy virtual register (lvr) data. It adds the lvr field to struct
acpi_resource_i2c_serialbus and updates the conversion info to map it.

Link: https://github.com/acpica/acpica/commit/70082dc8
Link: https://github.com/acpica/acpica/commit/b3c38dc9

> diff --git a/drivers/acpi/acpica/rsserial.c b/drivers/acpi/acpica/rsserial.c
> index 279bfa27da94d..c06e918ab8895 100644
> --- a/drivers/acpi/acpica/rsserial.c
> +++ b/drivers/acpi/acpica/rsserial.c

[ ... ]

> diff --git a/include/acpi/acrestyp.h b/include/acpi/acrestyp.h
> index 842f932e2c2bc..38a19b1d19ace 100644
> --- a/include/acpi/acrestyp.h
> +++ b/include/acpi/acrestyp.h
> @@ -423,6 +423,7 @@ struct acpi_resource_i2c_serialbus {
>  	ACPI_RESOURCE_SERIAL_COMMON u8 access_mode;
>  	u16 slave_address;
>  	u32 connection_speed;
> +	u8 lvr;
>  };

Does this newly added lvr field also need to be included in the resource
dumping mechanism?

Looking at drivers/acpi/acpica/rsdumpinfo.c, acpi_rs_dump_i2c_serial_bus
lacks an entry for this new field:

struct acpi_rsdump_info acpi_rs_dump_i2c_serial_bus[14] = {
	{ACPI_RSD_TITLE, ACPI_RSD_TABLE_SIZE(acpi_rs_dump_i2c_serial_bus),
	 "I2C Serial Bus", NULL},
	ACPI_RS_DUMP_COMMON_SERIAL_BUS {ACPI_RSD_1BITFLAG,
					ACPI_RSD_OFFSET(i2c_serial_bus.
							access_mode),
					"AccessMode", acpi_gbl_am_decode},
	{ACPI_RSD_UINT32, ACPI_RSD_OFFSET(i2c_serial_bus.connection_speed),
	 "ConnectionSpeed", NULL},
	{ACPI_RSD_UINT16, ACPI_RSD_OFFSET(i2c_serial_bus.slave_address),
	 "SlaveAddress", NULL},
};

Without a corresponding ACPI_RSD_UINT8 entry here, will utilities like
acpidump or acpiexec ignore the lvr field when disassembling and printing
I2C Serial Bus Resource descriptors?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260423085718.70762-1-akhilrajeev@nvidia.com?part=2