Linux Hardware Monitor development
 help / color / mirror / Atom feed
* [PATCH] Documentation: hwmon: lm75: document sysfs interface
@ 2026-05-16 16:10 Chen-Shi-Hong
  2026-05-16 16:14 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Chen-Shi-Hong @ 2026-05-16 16:10 UTC (permalink / raw)
  To: linux; +Cc: corbet, skhan, linux-hwmon, linux-doc, linux-kernel,
	Chen-Shi-Hong

Document the sysfs attributes supported by the lm75 driver.

The driver exposes temp1_input, temp1_max, temp1_max_hyst, and the
standard update_interval attribute. Some chips also expose temp1_alarm.

Add a sysfs-Interface section to Documentation/hwmon/lm75.rst to
describe the supported attributes and clarify that temp1_alarm and the
write permissions of update_interval depend on the chip.

Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
---
 Documentation/hwmon/lm75.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/hwmon/lm75.rst b/Documentation/hwmon/lm75.rst
index 4269da04508e..cbf737948c1d 100644
--- a/Documentation/hwmon/lm75.rst
+++ b/Documentation/hwmon/lm75.rst
@@ -181,3 +181,21 @@ is supported by this driver, other specific enhancements are not.
 
 The LM77 is not supported, contrary to what we pretended for a long time.
 Both chips are simply not compatible, value encoding differs.
+
+sysfs-Interface
+---------------
+
+================ ============================================
+temp1_input      temperature input
+temp1_max        maximum temperature
+temp1_max_hyst   maximum temperature hysteresis
+================ ============================================
+
+If supported by the chip, the following attribute is also available:
+
+================ ============================================
+temp1_alarm      temperature alarm
+================ ============================================
+
+The standard update_interval attribute is also supported. Its write
+permissions depend on the chip.
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation: hwmon: lm75: document sysfs interface
  2026-05-16 16:10 [PATCH] Documentation: hwmon: lm75: document sysfs interface Chen-Shi-Hong
@ 2026-05-16 16:14 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-05-16 16:14 UTC (permalink / raw)
  To: Chen-Shi-Hong; +Cc: linux-hwmon

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added sysfs-Interface documentation omits the `temp1_label` attribute.
--

commit 9ea544e30685306c26501a73ae7941baf5244e12
Author: Chen-Shi-Hong <eric039eric@gmail.com>

Documentation: hwmon: lm75: document sysfs interface

This commit adds a new sysfs-Interface section to the lm75 driver
documentation to describe the supported sysfs attributes.

> diff --git a/Documentation/hwmon/lm75.rst b/Documentation/hwmon/lm75.rst
> index 4269da04508ef..cbf737948c1d8 100644
> --- a/Documentation/hwmon/lm75.rst
> +++ b/Documentation/hwmon/lm75.rst
> @@ -181,3 +181,21 @@ is supported by this driver, other specific enhancements are not.
>  
>  The LM77 is not supported, contrary to what we pretended for a long time.
>  Both chips are simply not compatible, value encoding differs.
> +
> +sysfs-Interface
> +---------------
> +
> +================ ============================================
> +temp1_input      temperature input
> +temp1_max        maximum temperature
> +temp1_max_hyst   maximum temperature hysteresis
> +================ ============================================

Should this section also document the temp1_label attribute?

Looking at drivers/hwmon/lm75.c, the driver exposes the temp1_label
attribute via HWMON_T_LABEL if a label device property is present.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516161037.1486-1-eric039eric@gmail.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-16 16:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-16 16:10 [PATCH] Documentation: hwmon: lm75: document sysfs interface Chen-Shi-Hong
2026-05-16 16:14 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox