Re: [PATCH v5 1/4] hwmon: it87: describe per-chip temperature resources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused macro NUM_TEMP_OFFSET.
--

commit 8f31c77fc165d2fa01f14da71c4de721a4613e71
Author: benoit.masson <yahoo@perenite.com>

hwmon: it87: describe per-chip temperature resources

Add per-chip temp limit/offset/map counts and wire the driver to use them.
This keeps existing chips on the previous defaults while allowing newer chips
to advertise larger resources.

> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 87edb1b6048bb..1c77f6c97fc36 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -282,7 +282,6 @@ static const u8 IT87_REG_AUTO_BASE[] = { 0x60, 0x68, 0x70, 0x78, 0xa0, 0xa8 };
>  #define NUM_VIN_LIMIT		8
>  #define NUM_TEMP		6
>  #define NUM_TEMP_OFFSET		ARRAY_SIZE(IT87_REG_TEMP_OFFSET)
> -#define NUM_TEMP_LIMIT		3
>  #define NUM_FAN			ARRAY_SIZE(IT87_REG_FAN)
>  #define NUM_FAN_DIV		3
>  #define NUM_PWM			ARRAY_SIZE(IT87_REG_PWM)

[Severity: Low]
Is NUM_TEMP_OFFSET still needed? It appears its only usage was replaced by the
dynamic data->num_temp_offset parameter in it87_update_device(). Should this
be removed along with NUM_TEMP_LIMIT?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260829170545.33401-1-jerome.tollet@gmail.com?part=1