Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Jerome Tollet <jerome.tollet@gmail.com>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Benoit Masson <yahoo@perenite.com>
Subject: [PATCH v7 0/3] hwmon: it87: add IT8613E support
Date: Sun, 30 Aug 2026 00:01:46 +0200	[thread overview]
Message-ID: <cover.1788040385.git.jerome.tollet@gmail.com> (raw)
In-Reply-To: <20260829210036.61136-1-jerome.tollet@gmail.com>

This is a respin of Benoit Masson's v4 series, with his permission.
It replaces my fan-input-only RFC with the broader hardware monitoring
support requested in review.

The v4 series was dropped after a NULL pointer dereference was reported.
The IT8613E device entry did not initialize reg_pwm, while the probe path
unconditionally dereferences it. It also advertised six temperature
offsets but the register table contained only three entries.

Changes in v7:
- Keep the existing three temperature limit and offset resources. Drop
  the unused per-chip limit and offset counts and the extended offset
  register table, so the driver no longer accesses unexposed resources.
- Limit the first patch to describing per-chip PWM temperature maps.
- Apply a deferred legacy temperature mapping when switching from manual
  to automatic PWM mode instead of clearing it.
- Leave the existing PWM polarity repair path unchanged. The first three
  PWM control register addresses are common to the register maps used by
  this series.
- Clarify that IT8613E has three known temperature inputs and six PWM
  temperature mapping sources.

Tested on an IT8613E at 0xa30, revision 12. Every intermediate commit and
the complete series build as external modules with W=1. All three patches
pass checkpatch --strict with no warnings or errors.

The module exposes fan2_input and PWM2, PWM4, and PWM5 on this system.
The PWM2 temperature mapping was changed from 4 to 1 in manual mode. It
remained 1 after a cache refresh and after switching back to automatic
mode. The original mapping, duty, and automatic mode were then restored.

The PWM2 write path was tested by switching from automatic control to
manual full duty (255). Fan2 increased from 2636 RPM to 6553 RPM. The
original duty (65), automatic mode, and temperature mapping were restored.

An S3 suspend/resume cycle with an RTC wakeup completed successfully. The
PWM configuration and sensor readings were preserved, with no it87 or
hwmon warnings in the kernel log. The legacy mapping correction was
compile-tested but could not be exercised on this newer controller.

Link: https://lore.kernel.org/linux-hwmon/20260114221210.98071-1-yahoo@perenite.com/
Link: https://lore.kernel.org/linux-hwmon/20260829210036.61136-1-jerome.tollet@gmail.com/

benoit.masson (3):
  hwmon: it87: describe per-chip PWM temperature maps
  hwmon: it87: prepare for extended PWM temp maps
  hwmon: it87: add IT8613E support

 Documentation/hwmon/it87.rst |   8 +
 drivers/hwmon/it87.c         | 308 +++++++++++++++++++++++++++++------
 2 files changed, 263 insertions(+), 53 deletions(-)


base-commit: 75f2c0b3690702c90863c2e138cb5520670845ea
-- 
2.55.0

  parent reply	other threads:[~2026-08-29 22:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 17:05 [PATCH v5 0/4] hwmon: it87: add IT8613E support Jerome Tollet
2026-08-29 17:05 ` [PATCH v5 1/4] hwmon: it87: describe per-chip temperature resources Jerome Tollet
2026-08-29 17:20   ` sashiko-bot
2026-08-29 17:05 ` [PATCH v5 2/4] hwmon: it87: prepare for extended PWM temp maps Jerome Tollet
2026-08-29 17:20   ` sashiko-bot
2026-08-29 17:05 ` [PATCH v5 3/4] hwmon: it87: expose additional temperature limits Jerome Tollet
2026-08-29 17:17   ` sashiko-bot
2026-08-29 17:05 ` [PATCH v5 4/4] hwmon: it87: add IT8613E support Jerome Tollet
2026-08-29 17:23   ` sashiko-bot
2026-08-29 21:00 ` [PATCH v6 0/3] " Jerome Tollet
2026-08-29 21:00   ` [PATCH v6 1/3] hwmon: it87: describe per-chip temperature resources Jerome Tollet
2026-08-29 21:17     ` sashiko-bot
2026-08-29 21:00   ` [PATCH v6 2/3] hwmon: it87: prepare for extended PWM temp maps Jerome Tollet
2026-08-29 21:14     ` sashiko-bot
2026-08-29 21:00   ` [PATCH v6 3/3] hwmon: it87: add IT8613E support Jerome Tollet
2026-08-29 21:15     ` sashiko-bot
2026-08-29 22:01   ` Jerome Tollet [this message]
2026-08-29 22:01     ` [PATCH v7 1/3] hwmon: it87: describe per-chip PWM temperature maps Jerome Tollet
2026-08-29 22:08       ` sashiko-bot
2026-08-30  0:01       ` Guenter Roeck
2026-08-29 22:01     ` [PATCH v7 2/3] hwmon: it87: prepare for extended PWM temp maps Jerome Tollet
2026-08-29 22:14       ` sashiko-bot
2026-08-30  0:01       ` Guenter Roeck
2026-08-29 22:01     ` [PATCH v7 3/3] hwmon: it87: add IT8613E support Jerome Tollet
2026-08-29 22:11       ` sashiko-bot
2026-08-30  0:02       ` Guenter Roeck
2026-08-29 22:53   ` [PATCH v6 0/3] " Guenter Roeck
2026-08-30  5:19     ` Jerome Tollet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1788040385.git.jerome.tollet@gmail.com \
    --to=jerome.tollet@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=yahoo@perenite.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox