[PATCH v2 0/2] Support RAA229639 and RAA229640

[PATCH v2 0/2] Support RAA229639 and RAA229640

[Colin Huang]

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
Changes in v2:
- Clarify why fallback compatibles are not added in the DT binding.
- Reword driver commit message to avoid implying DT-level compatibility.
- Link to v1: https://lore.kernel.org/r/20260907-add-raa229639-and-raa229640-v1-0-8f7218cba85d@gmail.com

---
Colin Huang (2):
      dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
      hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640

 Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
 drivers/hwmon/pmbus/isl68137.c                                   | 4 ++++
 2 files changed, 6 insertions(+)
---
base-commit: e18bc3c9ca90f7c5165c717e9338d687b71931df
change-id: 20260902-add-raa229639-and-raa229640-c72fa121df82

Best regards,
-- 
Colin Huang <u8813345@gmail.com>

[PATCH v2 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640

[Colin Huang]

From: Colin Huang <u8813345@gmail.com>

Add Device Tree compatible strings for Renesas RAA229639 and
RAA229640 PMBus devices.

A fallback compatible is not introduced because the available
documentation does not establish DT-level compatibility with
any existing supported device.

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
 Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index 8216cdf758d8..3537c7ddfb09 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -60,6 +60,8 @@ properties:
           - renesas,raa229001
           - renesas,raa229004
           - renesas,raa229621
+          - renesas,raa229639
+          - renesas,raa229640
 
       - items:
           - enum:

-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640

[sashiko-bot]

> From: Colin Huang <u8813345@gmail.com>
> 
> Add Device Tree compatible strings for Renesas RAA229639 and
> RAA229640 PMBus devices.
> 
> A fallback compatible is not introduced because the available
> documentation does not establish DT-level compatibility with
> any existing supported device.
> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-add-raa229639-and-raa229640-v2-0-83c75b61139d@gmail.com?part=1

Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Tue, Sep 08, 2026 at 03:04:26PM +0800, Colin Huang wrote:
> From: Colin Huang <u8813345@gmail.com>
> 
> Add Device Tree compatible strings for Renesas RAA229639 and
> RAA229640 PMBus devices.
> 
> A fallback compatible is not introduced because the available
> documentation does not establish DT-level compatibility with
> any existing supported device.

Please don't respin before people have a chance to actually respond to
the thread. Please see my commentary on V(this - 1) on the compatiblity
of the devices being added.
pw-bot: changes-requested

Thanks,
Conor.

> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>
> ---
>  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index 8216cdf758d8..3537c7ddfb09 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -60,6 +60,8 @@ properties:
>            - renesas,raa229001
>            - renesas,raa229004
>            - renesas,raa229621
> +          - renesas,raa229639
> +          - renesas,raa229640
>  
>        - items:
>            - enum:
> 
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640

[Colin Huang]

From: Colin Huang <u8813345@gmail.com>

Add support for the Renesas RAA229639 and RAA229640 PMBus
voltage regulator devices.

Both devices are supported by the existing raa_dmpvr2_2rail
driver variant, so no functional changes are required beyond
adding the corresponding device IDs and OF match entries.

Signed-off-by: Colin Huang <u8813345@gmail.com>
---
 drivers/hwmon/pmbus/isl68137.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 2f7f825bfb69..53b44775ba1e 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{ .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
 	{ .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
 	{ .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
+	{ .name = "raa229639", .driver_data = raa_dmpvr2_2rail },
+	{ .name = "raa229640", .driver_data = raa_dmpvr2_2rail },
 	{ }
 };
 
@@ -506,6 +508,8 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
+	{ .compatible = "renesas,raa229639", .data = (void *)raa_dmpvr2_2rail },
+	{ .compatible = "renesas,raa229640", .data = (void *)raa_dmpvr2_2rail },
 	{ },
 };
 

-- 
2.34.1

Re: [PATCH v2 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added devices RAA229639 and RAA229640 are not documented in the supported chips list.
--

commit 1702c94b50317002cdd0b95f06c65c3af4214d35
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640

This commit adds support for the Renesas RAA229639 and RAA229640 PMBus
voltage regulator devices. It updates the existing raa_dmpvr2_2rail driver
variant by adding the corresponding device IDs and OF match entries.

> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 2f7f825bfb69e..53b44775ba1e6 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>  	{ .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
>  	{ .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
>  	{ .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
> +	{ .name = "raa229639", .driver_data = raa_dmpvr2_2rail },
> +	{ .name = "raa229640", .driver_data = raa_dmpvr2_2rail },

[Severity: Low]
Since these new devices are being added to the driver, should they also be
documented in the "Supported chips" list within
Documentation/hwmon/isl68137.rst alongside the existing parts?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-add-raa229639-and-raa229640-v2-0-83c75b61139d@gmail.com?part=2