Re: [PATCH v2] hwmon: Add thermal sensor driver for Surface Aggregator Module

[Maximilian Luz <luzmaximilian@gmail.com>]

On 8/7/24 2:32 AM, Guenter Roeck wrote:
> On 8/4/24 16:08, Maximilian Luz wrote:

[...]

>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index b60fe2e58ad6..70c6385f0ed6 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -2080,6 +2080,16 @@ config SENSORS_SURFACE_FAN
>>         Select M or Y here, if you want to be able to read the fan's speed.
>> +config SENSORS_SURFACE_TEMP
>> +    tristate "Microsoft Surface Thermal Sensor Driver"
>> +    depends on SURFACE_AGGREGATOR
> 
> As the kernel test robot points out, this dependency is wrong.
> __ssam_device_driver_register() is only available
> if SURFACE_AGGREGATOR_BUS is enabled.

Right, I should have spotted this before submission, sorry. This should
be

   depends on SURFACE_AGGREGATOR
   depends on SURFACE_AGGREGATOR_BUS

I'll fix that for v3 and likely re-spin this weekend. Anything else I
should address for that?

Regards,
Max