Re: [PATCH v2] hwmon: Add thermal sensor driver for Surface Aggregator Module

[Konrad Dybcio <konradybcio@kernel.org>]

On 5.08.2024 1:08 AM, Maximilian Luz wrote:
> Some of the newer Microsoft Surface devices (such as the Surface Book
> 3 and Pro 9) have thermal sensors connected via the Surface Aggregator
> Module (the embedded controller on those devices). Add a basic driver
> to read out the temperature values of those sensors.
> 
> The EC can have up to 16 thermal sensors connected via a single
> sub-device, each providing temperature readings and a label string.
> 
> Link: https://github.com/linux-surface/surface-aggregator-module/issues/59
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Co-developed-by: Ivor Wanders <ivor@iwanders.net>
> Signed-off-by: Ivor Wanders <ivor@iwanders.net>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> 
> ---

Gave it a shot on SL7, some names are repeated and one sensor is
totally busted

/sys/class/hwmon/hwmon66/name:surface_thermal
/sys/class/hwmon/hwmon66/temp10_input:32200
/sys/class/hwmon/hwmon66/temp10_label:I_RTS2
/sys/class/hwmon/hwmon66/temp11_input:31600
/sys/class/hwmon/hwmon66/temp11_label:I_RTS3
/sys/class/hwmon/hwmon66/temp12_input:38000
/sys/class/hwmon/hwmon66/temp12_label:I_RTS4
/sys/class/hwmon/hwmon66/temp1_input:43900
/sys/class/hwmon/hwmon66/temp1_label:I_RTS1
/sys/class/hwmon/hwmon66/temp2_input:44000
/sys/class/hwmon/hwmon66/temp2_label:I_RTS2
/sys/class/hwmon/hwmon66/temp3_input:47300
/sys/class/hwmon/hwmon66/temp3_label:I_RTS3
/sys/class/hwmon/hwmon66/temp4_input:-273100
/sys/class/hwmon/hwmon66/temp4_label:I_RTS4
/sys/class/hwmon/hwmon66/temp5_input:31300
/sys/class/hwmon/hwmon66/temp5_label:I_RTS5
/sys/class/hwmon/hwmon66/temp9_input:37100
/sys/class/hwmon/hwmon66/temp9_label:I_RTS1

Konrad