[PATCH 0/2] Congatec Board Controller: Fix current sensor lookup and add new sensors

[PATCH 0/2] Congatec Board Controller: Fix current sensor lookup and add new sensors

[Thomas Richard (congatec GmbH)]

This two patches series fixes the unknown sensor warning on conga-sa7 board.

Patch 1 fixes current sensor lookup. With patch 1 the unknown sensor
warning is still there, but sensor type and sensor id are now correct.

Patch 2 adds new sensors and so it fixes the unknown sensor warning.

Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
---
Thomas Richard (congatec GmbH) (2):
      hwmon: (cgbc-hwmon): Fix current sensors ID lookup
      hwmon: (cgbc-hwmon): Add some temperature sensors

 Documentation/hwmon/cgbc-hwmon.rst |  42 ++++++++-----
 drivers/hwmon/cgbc-hwmon.c         | 126 +++++++++++++++++++++++--------------
 2 files changed, 104 insertions(+), 64 deletions(-)
---
base-commit: d2587340a8575100d9ddd10270c7a5c216766b5b
change-id: 20260806-cgbc-hwmon-fix-and-new-sensors-21a7ab5387b3

Best regards,
--  
Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>

[PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[Thomas Richard (congatec GmbH)]

Current sensors on the Congatec Board Controller don't use consecutive IDs,
unlike other sensor types (voltage, temperature, fan). The driver assumed
consecutive IDs and performed a simple lookup, which caused an unknown
sensor warning. Define current sensor IDs explicitly.

Changes the warning on conga-SA7 (type and channel are correct now).
Before:
  Board Controller returned an unknown sensor (type=2, channel=17), ignore it
After:
  Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it

Cc: stable@kernel.org
Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
---
 drivers/hwmon/cgbc-hwmon.c | 93 +++++++++++++++++++++++++++-------------------
 1 file changed, 54 insertions(+), 39 deletions(-)

diff --git a/drivers/hwmon/cgbc-hwmon.c b/drivers/hwmon/cgbc-hwmon.c
index 3aff4e092132..2effa0b56286 100644
--- a/drivers/hwmon/cgbc-hwmon.c
+++ b/drivers/hwmon/cgbc-hwmon.c
@@ -52,31 +52,36 @@ static const char * const cgbc_hwmon_labels_temp[] = {
 	"BOTTOMDIM Temperature",
 };
 
+static const char * const cgbc_hwmon_labels_in[] = {
+	"CPU Voltage",
+	"DC Runtime Voltage",
+	"DC Standby Voltage",
+	"CMOS Battery Voltage",
+	"Battery Voltage",
+	"AC Voltage",
+	"Other Voltage",
+	"5V Voltage",
+	"5V Standby Voltage",
+	"3V3 Voltage",
+	"3V3 Standby Voltage",
+	"VCore A Voltage",
+	"VCore B Voltage",
+	"12V Voltage",
+};
+
+/*
+ * Current sensors are a bit special, they don't have consecutive IDs like
+ * other types of sensors. So they need to be defined explicitly.
+ */
 static const struct {
-	enum hwmon_sensor_types type;
 	const char *label;
-} cgbc_hwmon_labels_in[] = {
-	{ hwmon_in, "CPU Voltage" },
-	{ hwmon_in, "DC Runtime Voltage" },
-	{ hwmon_in, "DC Standby Voltage" },
-	{ hwmon_in, "CMOS Battery Voltage" },
-	{ hwmon_in, "Battery Voltage" },
-	{ hwmon_in, "AC Voltage" },
-	{ hwmon_in, "Other Voltage" },
-	{ hwmon_in, "5V Voltage" },
-	{ hwmon_in, "5V Standby Voltage" },
-	{ hwmon_in, "3V3 Voltage" },
-	{ hwmon_in, "3V3 Standby Voltage" },
-	{ hwmon_in, "VCore A Voltage" },
-	{ hwmon_in, "VCore B Voltage" },
-	{ hwmon_in, "12V Voltage" },
-	{ hwmon_curr, "DC Current" },
-	{ hwmon_curr, "5V Current" },
-	{ hwmon_curr, "12V Current" },
+	int id;
+} cgbc_hwmon_labels_curr[] = {
+	{ "DC Current", 0x12 },
+	{ "5V Current", 0x18 },
+	{ "12V Current", 0x1E },
 };
 
-#define CGBC_HWMON_NB_IN_SENSORS	14
-
 static const char * const cgbc_hwmon_labels_fan[] = {
 	"CPU Fan",
 	"Box Fan",
@@ -114,7 +119,8 @@ static int cgbc_hwmon_probe_sensors(struct device *dev, struct cgbc_hwmon_data *
 
 	for (i = 0; i < nb_sensors; i++) {
 		enum cgbc_sensor_types type;
-		unsigned int channel;
+		unsigned int channel, id;
+		int j;
 
 		/*
 		 * No need to request data for the first sensor.
@@ -128,32 +134,49 @@ static int cgbc_hwmon_probe_sensors(struct device *dev, struct cgbc_hwmon_data *
 		}
 
 		type = FIELD_GET(CGBC_HWMON_TYPE_MASK, data[1]);
-		channel = FIELD_GET(CGBC_HWMON_ID_MASK, data[1]) - 1;
+		id = FIELD_GET(CGBC_HWMON_ID_MASK, data[1]);
+		channel = id - 1;
 
 		if (type == CGBC_HWMON_TYPE_TEMP && channel < ARRAY_SIZE(cgbc_hwmon_labels_temp)) {
 			sensor->type = hwmon_temp;
 			sensor->label = cgbc_hwmon_labels_temp[channel];
-		} else if (type == CGBC_HWMON_TYPE_IN &&
-			   channel < ARRAY_SIZE(cgbc_hwmon_labels_in)) {
+		} else if (type == CGBC_HWMON_TYPE_IN) {
 			/*
 			 * The Board Controller doesn't differentiate current and voltage sensors.
-			 * Get the sensor type from cgbc_hwmon_labels_in[channel].type instead.
+			 * First check if it is a current sensor.
 			 */
-			sensor->type = cgbc_hwmon_labels_in[channel].type;
-			sensor->label = cgbc_hwmon_labels_in[channel].label;
+			for (j = 0; j < ARRAY_SIZE(cgbc_hwmon_labels_curr); j++) {
+				if (id == cgbc_hwmon_labels_curr[j].id) {
+					sensor->type = hwmon_curr;
+					sensor->label = cgbc_hwmon_labels_curr[j].label;
+					channel = j;
+				}
+			}
+
+			/* If it's not a current sensor, it may be a voltage sensor. */
+			if (!sensor->label && channel < ARRAY_SIZE(cgbc_hwmon_labels_in)) {
+				sensor->type = hwmon_in;
+				sensor->label = cgbc_hwmon_labels_in[channel];
+			}
 		} else if (type == CGBC_HWMON_TYPE_FAN &&
 			   channel < ARRAY_SIZE(cgbc_hwmon_labels_fan)) {
 			sensor->type = hwmon_fan;
 			sensor->label = cgbc_hwmon_labels_fan[channel];
-		} else {
-			dev_warn(dev, "Board Controller returned an unknown sensor (type=%d, channel=%d), ignore it",
-				 type, channel);
+		}
+
+		if (!sensor->label) {
+			dev_warn(dev, "Board Controller returned an unknown sensor (bc_type=%d, bc_id=%d), ignore it",
+				 type, id);
 			continue;
 		}
 
 		sensor->active = FIELD_GET(CGBC_HWMON_ACTIVE_BIT, data[1]);
 		sensor->channel = channel;
 		sensor->index = i;
+
+		dev_dbg(dev, "Found sensor: bc_type=%d, bc_id=%d, hwmon_type=%d, hwmon_channel=%d, hwmon_label='%s', active=%d\n",
+			type, id, sensor->type, sensor->channel, sensor->label, sensor->active);
+
 		sensor++;
 		hwmon->nb_sensors++;
 	}
@@ -167,14 +190,6 @@ static struct cgbc_hwmon_sensor *cgbc_hwmon_find_sensor(struct cgbc_hwmon_data *
 	struct cgbc_hwmon_sensor *sensor = NULL;
 	int i;
 
-	/*
-	 * The Board Controller doesn't differentiate current and voltage sensors.
-	 * The channel value (from the Board Controller point of view) shall be computed for current
-	 * sensors.
-	 */
-	if (type == hwmon_curr)
-		channel += CGBC_HWMON_NB_IN_SENSORS;
-
 	for (i = 0; i < hwmon->nb_sensors; i++) {
 		if (hwmon->sensors[i].type == type && hwmon->sensors[i].channel == channel) {
 			sensor = &hwmon->sensors[i];

-- 
2.53.0

Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[sashiko-bot]

> Current sensors on the Congatec Board Controller don't use consecutive IDs,
> unlike other sensor types (voltage, temperature, fan). The driver assumed
> consecutive IDs and performed a simple lookup, which caused an unknown
> sensor warning. Define current sensor IDs explicitly.
> 
> Changes the warning on conga-SA7 (type and channel are correct now).
> Before:
>   Board Controller returned an unknown sensor (type=2, channel=17), ignore it
> After:
>   Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
> 
> Cc: stable@kernel.org
> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-cgbc-hwmon-fix-and-new-sensors-v1-0-ef13ae2fa147@bootlin.com?part=1

Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[Guenter Roeck]

On Thu, Sep 10, 2026 at 03:28:21PM +0200, Thomas Richard (congatec GmbH) wrote:
> Current sensors on the Congatec Board Controller don't use consecutive IDs,
> unlike other sensor types (voltage, temperature, fan). The driver assumed
> consecutive IDs and performed a simple lookup, which caused an unknown
> sensor warning. Define current sensor IDs explicitly.
> 
> Changes the warning on conga-SA7 (type and channel are correct now).
> Before:
>   Board Controller returned an unknown sensor (type=2, channel=17), ignore it
> After:
>   Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
> 
> Cc: stable@kernel.org
> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>

Applied.

Thanks,
Guenter

Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[Thomas Richard]

On 9/11/26 2:58 AM, Guenter Roeck wrote:
> On Thu, Sep 10, 2026 at 03:28:21PM +0200, Thomas Richard (congatec GmbH) wrote:
>> Current sensors on the Congatec Board Controller don't use consecutive IDs,
>> unlike other sensor types (voltage, temperature, fan). The driver assumed
>> consecutive IDs and performed a simple lookup, which caused an unknown
>> sensor warning. Define current sensor IDs explicitly.
>>
>> Changes the warning on conga-SA7 (type and channel are correct now).
>> Before:
>>   Board Controller returned an unknown sensor (type=2, channel=17), ignore it
>> After:
>>   Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
>>
>> Cc: stable@kernel.org
>> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
>> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
> 
> Applied.
> 

You pointed me that Sashiko reported a missing cgbc_hwmon_info array but
you applied the patch. Should I send a v2 or an other patch to fix it?

Best Regards,
Thomas

Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[Guenter Roeck]

On 9/11/26 00:23, Thomas Richard wrote:
> On 9/11/26 2:58 AM, Guenter Roeck wrote:
>> On Thu, Sep 10, 2026 at 03:28:21PM +0200, Thomas Richard (congatec GmbH) wrote:
>>> Current sensors on the Congatec Board Controller don't use consecutive IDs,
>>> unlike other sensor types (voltage, temperature, fan). The driver assumed
>>> consecutive IDs and performed a simple lookup, which caused an unknown
>>> sensor warning. Define current sensor IDs explicitly.
>>>
>>> Changes the warning on conga-SA7 (type and channel are correct now).
>>> Before:
>>>    Board Controller returned an unknown sensor (type=2, channel=17), ignore it
>>> After:
>>>    Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
>>>
>>> Cc: stable@kernel.org
>>> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
>>> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
>>
>> Applied.
>>
> 
> You pointed me that Sashiko reported a missing cgbc_hwmon_info array but
> you applied the patch. Should I send a v2 or an other patch to fix it?
> 
Sorry, too much going on. Either way is fine.

Thanks for the reminder.

Guenter

Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup

[Thomas Richard]

On 9/11/26 3:57 PM, Guenter Roeck wrote:
> On 9/11/26 00:23, Thomas Richard wrote:
>> On 9/11/26 2:58 AM, Guenter Roeck wrote:
>>> On Thu, Sep 10, 2026 at 03:28:21PM +0200, Thomas Richard (congatec
>>> GmbH) wrote:
>>>> Current sensors on the Congatec Board Controller don't use
>>>> consecutive IDs,
>>>> unlike other sensor types (voltage, temperature, fan). The driver
>>>> assumed
>>>> consecutive IDs and performed a simple lookup, which caused an unknown
>>>> sensor warning. Define current sensor IDs explicitly.
>>>>
>>>> Changes the warning on conga-SA7 (type and channel are correct now).
>>>> Before:
>>>>    Board Controller returned an unknown sensor (type=2, channel=17),
>>>> ignore it
>>>> After:
>>>>    Board Controller returned an unknown sensor (bc_type=1,
>>>> bc_id=11), ignore it
>>>>
>>>> Cc: stable@kernel.org
>>>> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller
>>>> monitoring driver")
>>>> Signed-off-by: Thomas Richard (congatec GmbH)
>>>> <thomas.richard@bootlin.com>
>>>
>>> Applied.
>>>
>>
>> You pointed me that Sashiko reported a missing cgbc_hwmon_info array but
>> you applied the patch. Should I send a v2 or an other patch to fix it?
>>
> Sorry, too much going on. Either way is fine.
No problem, I sent a v2.

Best Regards,
Thomas

[PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors

[Thomas Richard (congatec GmbH)]

Add the following temperature sensors:
- Alternate Board Temperature (temp11_input)
- Top DIMM 1-7 temperature (temp12_input to temp18_input)
- Bottom DIMM 1 temperature (temp19_input)

This fixes the following warning on conga-SA7:

  Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it

Also update existing labels to match Congatec documentation.

Cc: stable@kernel.org
Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
---
 Documentation/hwmon/cgbc-hwmon.rst | 42 +++++++++++++++++++-------------
 drivers/hwmon/cgbc-hwmon.c         | 49 +++++++++++++++++++++++++-------------
 2 files changed, 58 insertions(+), 33 deletions(-)

diff --git a/Documentation/hwmon/cgbc-hwmon.rst b/Documentation/hwmon/cgbc-hwmon.rst
index 3a5e6e6e8639..c6d09232392a 100644
--- a/Documentation/hwmon/cgbc-hwmon.rst
+++ b/Documentation/hwmon/cgbc-hwmon.rst
@@ -28,34 +28,44 @@ system.
 Name          Description
 ============= ======================
 temp1_input   CPU temperature
-temp2_input   Box temperature
+temp2_input   Case temperature
 temp3_input   Ambient temperature
-temp4_input   Board temperature
-temp5_input   Carrier temperature
-temp6_input   Chipset temperature
-temp7_input   Video temperature
+temp4_input   CPU Board temperature
+temp5_input   Carrier Board temperature
+temp6_input   System Chipset temperature
+temp7_input   Video Controller/Board temperature
 temp8_input   Other temperature
-temp9_input   TOPDIM temperature
-temp10_input  BOTTOMDIM temperature
-in0_input     CPU voltage
+temp9_input   Top DIMM 0 temperature
+temp10_input  Bottom DIMM 0 temperature
+temp11_input  Alternate Board temperature
+temp12_input  Top DIMM 1 temperature
+temp13_input  Top DIMM 2 temperature
+temp14_input  Top DIMM 3 temperature
+temp15_input  Top DIMM 4 temperature
+temp16_input  Top DIMM 5 temperature
+temp17_input  Top DIMM 6 temperature
+temp18_input  Top DIMM 7 temperature
+temp19_input  Bottom DIMM 1 temperature
+in0_input     CPU Core voltage
 in1_input     DC Runtime voltage
 in2_input     DC Standby voltage
 in3_input     CMOS Battery voltage
-in4_input     Battery voltage
+in4_input     Battery Supply voltage
 in5_input     AC voltage
 in6_input     Other voltage
-in7_input     5V voltage
+in7_input     5V Runtime voltage
 in8_input     5V Standby voltage
-in9_input     3V3 voltage
+in9_input     3V3 Runtime voltage
 in10_input    3V3 Standby voltage
 in11_input    VCore A voltage
 in12_input    VCore B voltage
-in13_input    12V voltage
-curr1_input   DC current
-curr2_input   5V current
-curr3_input   12V current
+in13_input    12V Runtime voltage
+in14_input    12V Standby voltage
+curr1_input   DC Runtime current
+curr2_input   5V Runtime current
+curr3_input   12V Runtime current
 fan1_input    CPU fan
-fan2_input    Box fan
+fan2_input    Case fan
 fan3_input    Ambient fan
 fan4_input    Chiptset fan
 fan5_input    Video fan
diff --git a/drivers/hwmon/cgbc-hwmon.c b/drivers/hwmon/cgbc-hwmon.c
index 2effa0b56286..098896ec8c6f 100644
--- a/drivers/hwmon/cgbc-hwmon.c
+++ b/drivers/hwmon/cgbc-hwmon.c
@@ -41,32 +41,42 @@ enum cgbc_sensor_types {
 
 static const char * const cgbc_hwmon_labels_temp[] = {
 	"CPU Temperature",
-	"Box Temperature",
+	"Case Temperature",
 	"Ambient Temperature",
-	"Board Temperature",
-	"Carrier Temperature",
-	"Chipset Temperature",
-	"Video Temperature",
+	"CPU Board Temperature",
+	"Carrier Board Temperature",
+	"System Chipset Temperature",
+	"Video Controller/Board Temperature",
 	"Other Temperature",
-	"TOPDIM Temperature",
-	"BOTTOMDIM Temperature",
+	"Top DIMM 0 Temperature",
+	"Bottom DIMM 0 Temperature",
+	"Alternate Board Temperature",
+	"Top DIMM 1 Temperature",
+	"Top DIMM 2 Temperature",
+	"Top DIMM 3 Temperature",
+	"Top DIMM 4 Temperature",
+	"Top DIMM 5 Temperature",
+	"Top DIMM 6 Temperature",
+	"Top DIMM 7 Temperature",
+	"Bottom DIMM 1 Temperature",
 };
 
 static const char * const cgbc_hwmon_labels_in[] = {
-	"CPU Voltage",
+	"CPU Core Voltage",
 	"DC Runtime Voltage",
 	"DC Standby Voltage",
 	"CMOS Battery Voltage",
-	"Battery Voltage",
+	"Battery Supply Voltage",
 	"AC Voltage",
 	"Other Voltage",
-	"5V Voltage",
+	"5V Runtime Voltage",
 	"5V Standby Voltage",
-	"3V3 Voltage",
+	"3V3 Runtime Voltage",
 	"3V3 Standby Voltage",
 	"VCore A Voltage",
 	"VCore B Voltage",
-	"12V Voltage",
+	"12V Runtime Voltage",
+	"12V Standby Voltage",
 };
 
 /*
@@ -77,14 +87,14 @@ static const struct {
 	const char *label;
 	int id;
 } cgbc_hwmon_labels_curr[] = {
-	{ "DC Current", 0x12 },
-	{ "5V Current", 0x18 },
-	{ "12V Current", 0x1E },
+	{ "DC Runtime Current", 0x12 },
+	{ "5V Runtime Current", 0x18 },
+	{ "12V Runtime Current", 0x1E },
 };
 
 static const char * const cgbc_hwmon_labels_fan[] = {
 	"CPU Fan",
-	"Box Fan",
+	"Case Fan",
 	"Ambient Fan",
 	"Chipset Fan",
 	"Video Fan",
@@ -255,7 +265,12 @@ static const struct hwmon_channel_info * const cgbc_hwmon_info[] = {
 			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
 			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
-			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL),
+			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
 	HWMON_CHANNEL_INFO(in,
 			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,
 			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,

-- 
2.53.0

Re: [PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch adds a 15th voltage sensor ('12V Standby Voltage', mapping to `in14_input`) to the driver's string labels and documentation, but fails to add its corresponding configuration entry to the `cgbc_hwmon_info` array. As a result, the hardware monitoring core will silently ignore the 15th channel and fail to expose it to sysfs.
--

commit 0d30ff3c376bb1134975af10205e094badb07304
Author: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>

hwmon: (cgbc-hwmon): Add some temperature sensors

This commit adds several new temperature sensors, updating documentation and
string labels to match the Congatec board controller documentation. It also
modifies existing labels.

> diff --git a/drivers/hwmon/cgbc-hwmon.c b/drivers/hwmon/cgbc-hwmon.c
> index 2effa0b562862..098896ec8c6f6 100644
> --- a/drivers/hwmon/cgbc-hwmon.c
> +++ b/drivers/hwmon/cgbc-hwmon.c
> @@ -41,32 +41,42 @@ enum cgbc_sensor_types {
[ ... ]
>  static const char * const cgbc_hwmon_labels_in[] = {
> -	"CPU Voltage",
> +	"CPU Core Voltage",
>  	"DC Runtime Voltage",
>  	"DC Standby Voltage",
>  	"CMOS Battery Voltage",
> -	"Battery Voltage",
> +	"Battery Supply Voltage",
>  	"AC Voltage",
>  	"Other Voltage",
> -	"5V Voltage",
> +	"5V Runtime Voltage",
>  	"5V Standby Voltage",
> -	"3V3 Voltage",
> +	"3V3 Runtime Voltage",
>  	"3V3 Standby Voltage",
>  	"VCore A Voltage",
>  	"VCore B Voltage",
> -	"12V Voltage",
> +	"12V Runtime Voltage",
> +	"12V Standby Voltage",
>  };

[ ... ]

> @@ -255,7 +265,12 @@ static const struct hwmon_channel_info * const cgbc_hwmon_info[] = {
>  			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>  			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>  			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> -			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL),
> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
> +			   HWMON_T_INPUT | HWMON_T_LABEL),
>  	HWMON_CHANNEL_INFO(in,
>  			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,
>  			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,

[Severity: Medium]
This patch adds a 15th voltage label ("12V Standby Voltage"), but is the
corresponding configuration entry missing from the cgbc_hwmon_info array?

Looking at the 'in' channel info array here, it only has 14 configuration
elements.

Since the hardware monitoring core iterates over the cgbc_hwmon_info
array and stops after 14 entries for 'in', will it silently ignore the 15th
channel and fail to expose it to sysfs?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-cgbc-hwmon-fix-and-new-sensors-v1-0-ef13ae2fa147@bootlin.com?part=2

Re: [PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors

[Guenter Roeck]

On 9/10/26 06:45, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch adds a 15th voltage sensor ('12V Standby Voltage', mapping to `in14_input`) to the driver's string labels and documentation, but fails to add its corresponding configuration entry to the `cgbc_hwmon_info` array. As a result, the hardware monitoring core will silently ignore the 15th channel and fail to expose it to sysfs.
> --
> 
> commit 0d30ff3c376bb1134975af10205e094badb07304
> Author: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
> 
> hwmon: (cgbc-hwmon): Add some temperature sensors
> 
> This commit adds several new temperature sensors, updating documentation and
> string labels to match the Congatec board controller documentation. It also
> modifies existing labels.
> 
>> diff --git a/drivers/hwmon/cgbc-hwmon.c b/drivers/hwmon/cgbc-hwmon.c
>> index 2effa0b562862..098896ec8c6f6 100644
>> --- a/drivers/hwmon/cgbc-hwmon.c
>> +++ b/drivers/hwmon/cgbc-hwmon.c
>> @@ -41,32 +41,42 @@ enum cgbc_sensor_types {
> [ ... ]
>>   static const char * const cgbc_hwmon_labels_in[] = {
>> -	"CPU Voltage",
>> +	"CPU Core Voltage",
>>   	"DC Runtime Voltage",
>>   	"DC Standby Voltage",
>>   	"CMOS Battery Voltage",
>> -	"Battery Voltage",
>> +	"Battery Supply Voltage",
>>   	"AC Voltage",
>>   	"Other Voltage",
>> -	"5V Voltage",
>> +	"5V Runtime Voltage",
>>   	"5V Standby Voltage",
>> -	"3V3 Voltage",
>> +	"3V3 Runtime Voltage",
>>   	"3V3 Standby Voltage",
>>   	"VCore A Voltage",
>>   	"VCore B Voltage",
>> -	"12V Voltage",
>> +	"12V Runtime Voltage",
>> +	"12V Standby Voltage",
>>   };
> 
> [ ... ]
> 
>> @@ -255,7 +265,12 @@ static const struct hwmon_channel_info * const cgbc_hwmon_info[] = {
>>   			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>>   			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>>   			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> -			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL),
>> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> +			   HWMON_T_INPUT | HWMON_T_LABEL, HWMON_T_INPUT | HWMON_T_LABEL,
>> +			   HWMON_T_INPUT | HWMON_T_LABEL),
>>   	HWMON_CHANNEL_INFO(in,
>>   			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,
>>   			   HWMON_I_INPUT | HWMON_I_LABEL, HWMON_I_INPUT | HWMON_I_LABEL,
> 
> [Severity: Medium]
> This patch adds a 15th voltage label ("12V Standby Voltage"), but is the
> corresponding configuration entry missing from the cgbc_hwmon_info array?
> 
> Looking at the 'in' channel info array here, it only has 14 configuration
> elements.
> 
> Since the hardware monitoring core iterates over the cgbc_hwmon_info
> array and stops after 14 entries for 'in', will it silently ignore the 15th
> channel and fail to expose it to sysfs?
> 
Sashiko has a point here. Maybe make the subject and description a bit more generic
("Add some sensors" or similar, document that a voltage sensor was added as well,
and add the missing channel info entry.

Thanks,
Guenter

Re: [PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors

[Guenter Roeck]

On Thu, Sep 10, 2026 at 03:28:22PM +0200, Thomas Richard (congatec GmbH) wrote:
> Add the following temperature sensors:
> - Alternate Board Temperature (temp11_input)
> - Top DIMM 1-7 temperature (temp12_input to temp18_input)
> - Bottom DIMM 1 temperature (temp19_input)
> 
> This fixes the following warning on conga-SA7:
> 
>   Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
> 
> Also update existing labels to match Congatec documentation.
> 
> Cc: stable@kernel.org
> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>

Applied.

Thanks,
Guenter