[PATCH v4 00/23] gpio: Improvements around device-id arrays

[PATCH v4 00/23] gpio: Improvements around device-id arrays

[Uwe Kleine-König (The Capable Hub)]

Hello,

the original motivation for this series are the patches that convert the
arrays to use named initializers, see
https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
for the idea behind it. Looking left and right a bit while implementing
that, the series grew a bit.

Changes since v3 (available at
https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com):

 - Picked up review tags (b4 even found some from v2)
 - Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-mpc5200.c
   (My grep didn't handle >1 driver per file well), noticed by Sashiko
 - New patch to use named initializers for auxiliary_device_id arrays
 - Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
   (My script doesn't handle of_device_id::name) and
   drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
   failed to notice that for v3)
 - Fix code style of auxiliary_device_id array in
   drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
   for auxiliary_device_id before.
 - Dropped a few broken email addresses from Cc:

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (23):
  gpio: Remove __maybe_unused annotations from acpi_device_id arrays
  gpio: fxl6408: Remove __maybe_unused annotations from of_device_id
    array
  gpio: Drop unused assignment of acpi_device_id driver data
  gpio: max7301: Drop unused assignment of spi_device_id driver data
  gpio: mmio: Drop unused assignment of platform_device_id driver data
  gpio: ljca: Drop unused assignment of auxiliary_device_id driver data
  gpio: xgene: Add missing ACPI module annotation
  gpio: sodaville: Add missing PCI module annotations
  gpio: Add missing OF module annotations
  gpio: pxa: Add missing platform module annotations
  gpio: pl061: Use empty initializer for amba_id terminator
  gpio: Use named initializers for acpi_device_id array
  gpio: Use named initializers for auxiliary_device_id arrays
  gpio: pcf857x: Use named initializers for of_device_id array
  gpio: bd73800: Use named initializers for platform_device_id array
  gpio: Use named initializers for spi_device_id array
  gpio: virtio: Use a named initializer for virtio_device_id array
  gpio: Unify style of acpi_device_id arrays
  gpio: Unify style of of_device_id arrays
  gpio: max77620: Unify style of platform_device_id array
  gpio: Unify style of spi_device_id arrays
  gpio: Unify style of pci_device_id arrays
  gpio: Unify style of various *_device_id arrays

 drivers/gpio/gpio-74x164.c          |  4 ++--
 drivers/gpio/gpio-adnp.c            |  4 ++--
 drivers/gpio/gpio-aggregator.c      |  2 +-
 drivers/gpio/gpio-altera-a10sr.c    |  2 +-
 drivers/gpio/gpio-altera.c          |  4 ++--
 drivers/gpio/gpio-amd8111.c         |  2 +-
 drivers/gpio/gpio-amdpt.c           |  8 ++++----
 drivers/gpio/gpio-aspeed-sgpio.c    | 10 ++++-----
 drivers/gpio/gpio-aspeed.c          | 10 ++++-----
 drivers/gpio/gpio-ath79.c           |  2 +-
 drivers/gpio/gpio-bcm-kona.c        |  1 +
 drivers/gpio/gpio-bd73800.c         |  4 ++--
 drivers/gpio/gpio-blzp1600.c        |  4 ++--
 drivers/gpio/gpio-brcmstb.c         |  2 +-
 drivers/gpio/gpio-bt8xx.c           |  2 +-
 drivers/gpio/gpio-cadence.c         |  6 +++---
 drivers/gpio/gpio-creg-snps.c       |  5 +++--
 drivers/gpio/gpio-davinci.c         |  8 ++++----
 drivers/gpio/gpio-dwapb.c           | 14 ++++++-------
 drivers/gpio/gpio-elkhartlake.c     |  2 +-
 drivers/gpio/gpio-em.c              |  4 ++--
 drivers/gpio/gpio-ep93xx.c          |  1 +
 drivers/gpio/gpio-ftgpio010.c       |  3 ++-
 drivers/gpio/gpio-fxl6408.c         |  2 +-
 drivers/gpio/gpio-graniterapids.c   |  4 ++--
 drivers/gpio/gpio-grgpio.c          |  6 +++---
 drivers/gpio/gpio-gw-pld.c          |  4 ++--
 drivers/gpio/gpio-hisi.c            |  6 +++---
 drivers/gpio/gpio-hlwd.c            |  4 ++--
 drivers/gpio/gpio-imx-scu.c         |  1 +
 drivers/gpio/gpio-ixp4xx.c          |  4 ++--
 drivers/gpio/gpio-ljca.c            |  4 ++--
 drivers/gpio/gpio-loongson-64bit.c  |  4 ++--
 drivers/gpio/gpio-lp3943.c          |  2 +-
 drivers/gpio/gpio-lpc32xx.c         |  4 ++--
 drivers/gpio/gpio-ltc4283.c         |  2 +-
 drivers/gpio/gpio-macsmc.c          |  4 ++--
 drivers/gpio/gpio-max3191x.c        | 12 +++++------
 drivers/gpio/gpio-max7301.c         |  2 +-
 drivers/gpio/gpio-max7360.c         |  8 ++++----
 drivers/gpio/gpio-max77620.c        |  4 ++--
 drivers/gpio/gpio-max77759.c        |  2 +-
 drivers/gpio/gpio-mb86s7x.c         |  2 +-
 drivers/gpio/gpio-ml-ioh.c          |  2 +-
 drivers/gpio/gpio-mlxbf.c           |  6 +++---
 drivers/gpio/gpio-mlxbf2.c          |  6 +++---
 drivers/gpio/gpio-mlxbf3.c          |  4 ++--
 drivers/gpio/gpio-mm-lantiq.c       |  2 +-
 drivers/gpio/gpio-mmio.c            |  3 +--
 drivers/gpio/gpio-mockup.c          |  4 ++--
 drivers/gpio/gpio-moxtet.c          |  4 ++--
 drivers/gpio/gpio-mpc5200.c         | 10 +++++----
 drivers/gpio/gpio-mpc8xxx.c         | 25 +++++++++++-----------
 drivers/gpio/gpio-mpfs.c            |  1 +
 drivers/gpio/gpio-mpsse.c           |  3 +--
 drivers/gpio/gpio-msc313.c          |  1 +
 drivers/gpio/gpio-mt7621.c          |  2 +-
 drivers/gpio/gpio-mvebu.c           | 13 ++++++------
 drivers/gpio/gpio-mxc.c             |  2 +-
 drivers/gpio/gpio-mxs.c             |  4 ++--
 drivers/gpio/gpio-nomadik.c         |  7 ++++---
 drivers/gpio/gpio-novalake-events.c |  4 ++--
 drivers/gpio/gpio-npcm-sgpio.c      |  6 +++---
 drivers/gpio/gpio-octeon.c          |  2 +-
 drivers/gpio/gpio-omap.c            |  2 +-
 drivers/gpio/gpio-palmas.c          | 10 ++++-----
 drivers/gpio/gpio-pca953x.c         |  4 ++--
 drivers/gpio/gpio-pca9570.c         |  2 +-
 drivers/gpio/gpio-pcf857x.c         | 26 +++++++++++------------
 drivers/gpio/gpio-pci-idio-16.c     |  3 ++-
 drivers/gpio/gpio-pcie-idio-24.c    |  8 +++++---
 drivers/gpio/gpio-pisosr.c          |  4 ++--
 drivers/gpio/gpio-pl061.c           |  2 +-
 drivers/gpio/gpio-pmic-eic-sprd.c   |  2 +-
 drivers/gpio/gpio-ppc44x.c          |  2 +-
 drivers/gpio/gpio-pxa.c             | 20 ++++++++++--------
 drivers/gpio/gpio-qixis-fpga.c      |  3 +--
 drivers/gpio/gpio-rcar.c            |  2 +-
 drivers/gpio/gpio-rda.c             |  2 +-
 drivers/gpio/gpio-realtek-otto.c    |  2 +-
 drivers/gpio/gpio-rockchip.c        |  4 ++--
 drivers/gpio/gpio-sama5d2-piobu.c   |  2 +-
 drivers/gpio/gpio-shared-proxy.c    |  2 +-
 drivers/gpio/gpio-sifive.c          |  2 +-
 drivers/gpio/gpio-sl28cpld.c        |  2 +-
 drivers/gpio/gpio-sodaville.c       |  3 ++-
 drivers/gpio/gpio-spear-spics.c     |  3 ++-
 drivers/gpio/gpio-sprd.c            |  2 +-
 drivers/gpio/gpio-stmpe.c           |  2 +-
 drivers/gpio/gpio-stp-xway.c        |  2 +-
 drivers/gpio/gpio-tc9563.c          |  2 +-
 drivers/gpio/gpio-tegra.c           |  6 +++---
 drivers/gpio/gpio-tegra186.c        | 32 ++++++++++++++---------------
 drivers/gpio/gpio-thunderx.c        |  3 +--
 drivers/gpio/gpio-tps65218.c        |  2 +-
 drivers/gpio/gpio-ts4800.c          |  4 ++--
 drivers/gpio/gpio-ts4900.c          |  2 +-
 drivers/gpio/gpio-twl4030.c         |  4 ++--
 drivers/gpio/gpio-usbio.c           | 14 ++++++-------
 drivers/gpio/gpio-vf610.c           |  4 ++--
 drivers/gpio/gpio-virtio.c          |  4 ++--
 drivers/gpio/gpio-visconti.c        |  2 +-
 drivers/gpio/gpio-waveshare-dsi.c   |  2 +-
 drivers/gpio/gpio-xgene-sb.c        |  6 +++---
 drivers/gpio/gpio-xgene.c           | 10 +++++----
 drivers/gpio/gpio-xgs-iproc.c       |  2 +-
 drivers/gpio/gpio-xilinx.c          |  4 ++--
 drivers/gpio/gpio-xlp.c             |  6 +++---
 drivers/gpio/gpio-xra1403.c         |  6 +++---
 drivers/gpio/gpio-zevio.c           |  5 +++--
 drivers/gpio/gpio-zynqmp-modepin.c  |  2 +-
 drivers/gpio/gpiolib-acpi-quirks.c  |  2 +-
 112 files changed, 278 insertions(+), 260 deletions(-)


base-commit: 20a33c6b6cbe7e4805dfb6cd68816937443aa148
-- 
2.56.0.rc1

[PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays

[Uwe Kleine-König (The Capable Hub)]

While being less compact, using named initializers allows to more easily
see which members of the structs are assigned which value without having
to lookup the declaration of the struct. And it's also more robust
against changes to the struct definition.

The mentioned robustness is relevant for a planned change to struct
auxiliary_device_id that replaces .driver_data by an anonymous union
(though none of these drivers uses .driver_data, so this patch isn't
strictly necessary for the plan, but still ok for consistency).

This patch doesn't modify the compiled arrays, only their representation
in source form benefits.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/gpio/gpio-elkhartlake.c | 2 +-
 drivers/gpio/gpio-ljca.c        | 2 +-
 drivers/gpio/gpio-ltc4283.c     | 2 +-
 drivers/gpio/gpio-tc9563.c      | 2 +-
 drivers/gpio/gpio-usbio.c       | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-elkhartlake.c b/drivers/gpio/gpio-elkhartlake.c
index b96e7928b6e5..d4ddb3d00b86 100644
--- a/drivers/gpio/gpio-elkhartlake.c
+++ b/drivers/gpio/gpio-elkhartlake.c
@@ -59,7 +59,7 @@ static int ehl_gpio_probe(struct auxiliary_device *adev, const struct auxiliary_
 }
 
 static const struct auxiliary_device_id ehl_gpio_ids[] = {
-	{ EHL_PSE_IO_NAME "." EHL_PSE_GPIO_NAME },
+	{ .name = EHL_PSE_IO_NAME "." EHL_PSE_GPIO_NAME },
 	{ }
 };
 MODULE_DEVICE_TABLE(auxiliary, ehl_gpio_ids);
diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c
index ad5dc9a3a119..f967feedb5d2 100644
--- a/drivers/gpio/gpio-ljca.c
+++ b/drivers/gpio/gpio-ljca.c
@@ -472,7 +472,7 @@ static void ljca_gpio_remove(struct auxiliary_device *auxdev)
 }
 
 static const struct auxiliary_device_id ljca_gpio_id_table[] = {
-	{ "usb_ljca.ljca-gpio" },
+	{ .name = "usb_ljca.ljca-gpio" },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(auxiliary, ljca_gpio_id_table);
diff --git a/drivers/gpio/gpio-ltc4283.c b/drivers/gpio/gpio-ltc4283.c
index 88aa6216006a..3295f159d83f 100644
--- a/drivers/gpio/gpio-ltc4283.c
+++ b/drivers/gpio/gpio-ltc4283.c
@@ -201,7 +201,7 @@ static int ltc4283_gpio_probe(struct auxiliary_device *adev,
 }
 
 static const struct auxiliary_device_id ltc4283_aux_id_table[] = {
-	{ "ltc4283.gpio" },
+	{ .name = "ltc4283.gpio" },
 	{ }
 };
 MODULE_DEVICE_TABLE(auxiliary, ltc4283_aux_id_table);
diff --git a/drivers/gpio/gpio-tc9563.c b/drivers/gpio/gpio-tc9563.c
index 68c20c8cba79..5ba9df2b6936 100644
--- a/drivers/gpio/gpio-tc9563.c
+++ b/drivers/gpio/gpio-tc9563.c
@@ -80,7 +80,7 @@ static int tc9563_gpio_probe(struct auxiliary_device *adev,
 };
 
 static const struct auxiliary_device_id tc9563_gpio_ids[] = {
-	{ "pci_pwrctrl_tc9563." TC9563_GPIO_DEV_NAME },
+	{ .name = "pci_pwrctrl_tc9563." TC9563_GPIO_DEV_NAME },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(auxiliary, tc9563_gpio_ids);
diff --git a/drivers/gpio/gpio-usbio.c b/drivers/gpio/gpio-usbio.c
index e34734aa4365..fe8f51f1a4b1 100644
--- a/drivers/gpio/gpio-usbio.c
+++ b/drivers/gpio/gpio-usbio.c
@@ -230,7 +230,7 @@ static int usbio_gpio_probe(struct auxiliary_device *adev,
 }
 
 static const struct auxiliary_device_id usbio_gpio_id_table[] = {
-	{ "usbio.usbio-gpio" },
+	{ .name = "usbio.usbio-gpio" },
 	{ }
 };
 MODULE_DEVICE_TABLE(auxiliary, usbio_gpio_id_table);
-- 
2.56.0.rc1

Re: [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays

[sashiko-bot]

> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
> 
> The mentioned robustness is relevant for a planned change to struct
> auxiliary_device_id that replaces .driver_data by an anonymous union
> (though none of these drivers uses .driver_data, so this patch isn't
> strictly necessary for the plan, but still ok for consistency).
> 
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793097104.git.u.kleine-koenig@baylibre.com?part=13

Re: [PATCH v4 13/23] gpio: Use named initializers for auxiliary_device_id arrays

[Sakari Ailus]

Hi Uwe,

On Tue, Oct 27, 2026 at 11:48:50AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
> 
> The mentioned robustness is relevant for a planned change to struct
> auxiliary_device_id that replaces .driver_data by an anonymous union
> (though none of these drivers uses .driver_data, so this patch isn't
> strictly necessary for the plan, but still ok for consistency).
> 
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> # gpio-usbio, gpio-ljca

-- 
Regards,

Sakari Ailus

Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays

[Alan Borzeszkowski]

Hi,

On Tue, 2026-10-27 at 11:48 +0100, Uwe Kleine-König (The Capable Hub)
wrote:
> Hello,
> 
> the original motivation for this series are the patches that convert
> the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while
> implementing
> that, the series grew a bit.
> 
> Changes since v3 (available at
> https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com
> ):
> 
>  - Picked up review tags (b4 even found some from v2)
>  - Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-
> mpc5200.c
>    (My grep didn't handle >1 driver per file well), noticed by
> Sashiko
>  - New patch to use named initializers for auxiliary_device_id arrays
>  - Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
>    (My script doesn't handle of_device_id::name) and
>    drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
>    failed to notice that for v3)
>  - Fix code style of auxiliary_device_id array in
>    drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
>    for auxiliary_device_id before.
>  - Dropped a few broken email addresses from Cc:
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (The Capable Hub) (23):
> [...]
>   gpio: Use named initializers for acpi_device_id array
> [...]
>   gpio: Unify style of acpi_device_id arrays
> [...]
> 
> [...]
>  drivers/gpio/gpio-novalake-events.c |  4 ++--
> [...]
> 

For gpio-novalake-events

Acked-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>