From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag
Date: Thu, 19 Sep 2024 08:30:28 +0000 [thread overview]
Message-ID: <ZuvhJHxfkycgUVN0@google.com> (raw)
In-Reply-To: <20240913003145.1931634-1-linux@roeck-us.net>
On Thu, Sep 12, 2024 at 05:31:44PM -0700, Guenter Roeck wrote:
> Add configuration flag indicating if the chip supports alerts and limits
> to prepare for adding INA260 support.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> @@ -155,6 +156,7 @@ static const struct ina2xx_config ina2xx_config[] = {
> .bus_voltage_shift = 3,
> .bus_voltage_lsb = 4000,
> .power_lsb_factor = 20,
> + .has_alerts = false,
No strong preference: or just don't set it.
next prev parent reply other threads:[~2024-09-19 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 0:31 [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag Guenter Roeck
2024-09-13 0:31 ` [PATCH 2/2] hwmon: (ina260) Add support for INA260 Guenter Roeck
2024-09-19 8:30 ` Tzung-Bi Shih
2024-09-19 8:30 ` Tzung-Bi Shih [this message]
2024-09-19 14:35 ` [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuvhJHxfkycgUVN0@google.com \
--to=tzungbi@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox