From: Guenter Roeck <linux@roeck-us.net>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag
Date: Thu, 19 Sep 2024 07:35:53 -0700 [thread overview]
Message-ID: <cc5d57ff-8c64-4bfe-a2e1-cdec6e4056f1@roeck-us.net> (raw)
In-Reply-To: <ZuvhJHxfkycgUVN0@google.com>
On 9/19/24 01:30, Tzung-Bi Shih wrote:
> On Thu, Sep 12, 2024 at 05:31:44PM -0700, Guenter Roeck wrote:
>> Add configuration flag indicating if the chip supports alerts and limits
>> to prepare for adding INA260 support.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
>
>> @@ -155,6 +156,7 @@ static const struct ina2xx_config ina2xx_config[] = {
>> .bus_voltage_shift = 3,
>> .bus_voltage_lsb = 4000,
>> .power_lsb_factor = 20,
>> + .has_alerts = false,
>
> No strong preference: or just don't set it.
In situations like this I prefer to explicitly set the value to indicate that
it wasn't forgotten.
Thanks a lot for the reviews!
Guenter
prev parent reply other threads:[~2024-09-19 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 0:31 [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag Guenter Roeck
2024-09-13 0:31 ` [PATCH 2/2] hwmon: (ina260) Add support for INA260 Guenter Roeck
2024-09-19 8:30 ` Tzung-Bi Shih
2024-09-19 8:30 ` [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag Tzung-Bi Shih
2024-09-19 14:35 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc5d57ff-8c64-4bfe-a2e1-cdec6e4056f1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox