Re: [PATCH 2/2] hwmon: (ina260) Add support for INA260

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Thu, Sep 12, 2024 at 05:31:45PM -0700, Guenter Roeck wrote:
> INA260 is similar to other chips of the series, except it has an internal
> shunt resistor. The calibration register is therefore not present. Also,
> the current register address was changed, though that does not matter for
> the driver since the shunt voltage register (which is now the current
> register) value is already used to read the current.
> 
> Cc: Loic Guegan <loic.guegan@mailbox.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

> @@ -157,6 +160,7 @@ static const struct ina2xx_config ina2xx_config[] = {
>  		.bus_voltage_lsb = 4000,
>  		.power_lsb_factor = 20,
>  		.has_alerts = false,
> +		.has_ishunt = false,
>  	},
>  	[ina226] = {
>  		.config_default = INA226_CONFIG_DEFAULT,
> @@ -166,6 +170,16 @@ static const struct ina2xx_config ina2xx_config[] = {
>  		.bus_voltage_lsb = 1250,
>  		.power_lsb_factor = 25,
>  		.has_alerts = true,
> +		.has_ishunt = false,

No strong preference: or just don't set them.