From: Guenter Roeck <linux@roeck-us.net>
To: Sung-Chi Li <lschyi@chromium.org>
Cc: "Thomas Weißschuh" <thomas@weissschuh.net>,
"Jean Delvare" <jdelvare@suse.com>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] hwmon: (cros_ec) Add set and get target fan RPM function
Date: Tue, 25 Mar 2025 05:55:07 -0700 [thread overview]
Message-ID: <aa034893-405e-4f71-8cb6-0ccb112c36da@roeck-us.net> (raw)
In-Reply-To: <Z-JYQyxJErCQKo4i@google.com>
On 3/25/25 00:16, Sung-Chi Li wrote:
>
> Currently, when sending the fan control setting to EC, EC will switch to manual
> fan control automatically. When system suspends or shuts down, fans are going
> back to automatic control (based on current EC implementation).
>
> Do you mean the driver should not change the fan control method if there is no
> pwmY_enable implemented, or it is the user that should first explicitly set the
> fan to manualy mode, then the user can specify the desired fan speed?
The user should first set the fan control method to manual mode.
Unless I am missing something, setting manual mode means that pwmY_enable does have
to be implemented.
Note that the suspend/resume behavior is unexpected. The user would assume that the fan
control method is still in the same mode after resume. If resume reverts to automatic mode,
there should be a suspend/resume handler which restores the mode on resume.
Thanks,
Guenter
next prev parent reply other threads:[~2025-03-25 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 7:45 [PATCH v3] hwmon: (cros_ec) Add set and get target fan RPM function Sung-Chi Li
2025-03-22 13:55 ` Thomas Weißschuh
2025-03-22 14:12 ` Guenter Roeck
2025-03-22 15:23 ` Thomas Weißschuh
2025-03-22 15:45 ` Guenter Roeck
2025-03-23 16:08 ` Thomas Weißschuh
2025-03-22 16:10 ` Guenter Roeck
2025-03-23 16:05 ` Thomas Weißschuh
2025-03-23 16:22 ` Guenter Roeck
2025-03-25 7:16 ` Sung-Chi Li
2025-03-25 12:55 ` Guenter Roeck [this message]
2025-03-26 2:44 ` Sung-Chi Li
2025-03-22 16:06 ` Guenter Roeck
2025-03-23 16:16 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa034893-405e-4f71-8cb6-0ccb112c36da@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lschyi@chromium.org \
--cc=thomas@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox