Re: [PATCH 05/10] hwmon: (ltc4245) Drop platform data support

["Nuno Sá" <nuno.sa@analog.com>]

On Tue, Nov 10, 2026 at 10:34:28AM -0800, Guenter Roeck wrote:
> There are no in-tree users of ltc4245_platform_data. Sampling all GPIO
> pins as analog voltages is already configurable via the
> "ltc4245,use-extra-gpios" devicetree property.
> 
> Drop platform data support from the driver, remove the unused
> platform_data header file, and update the driver documentation.
> 
> Cc: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Thanks!

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  Documentation/hwmon/ltc4245.rst       |  6 ++----
>  drivers/hwmon/ltc4245.c               | 21 +++------------------
>  include/linux/platform_data/ltc4245.h | 17 -----------------
>  3 files changed, 5 insertions(+), 39 deletions(-)
>  delete mode 100644 include/linux/platform_data/ltc4245.h
> 
> diff --git a/Documentation/hwmon/ltc4245.rst b/Documentation/hwmon/ltc4245.rst
> index 3dafd08a4e87..0c3b823169b9 100644
> --- a/Documentation/hwmon/ltc4245.rst
> +++ b/Documentation/hwmon/ltc4245.rst
> @@ -103,9 +103,7 @@ then they will be sampled in round-robin fashion. If userspace reads too
>  slowly, -EAGAIN will be returned when you read the sysfs attribute containing
>  the sensor reading.
>  
> -The LTC4245 chip can be configured to sample all GPIO pins with two methods:
> -
> -1) platform data -- see include/linux/platform_data/ltc4245.h
> -2) OF device tree -- add the "ltc4245,use-extra-gpios" property to each chip
> +The LTC4245 chip can be configured to sample all GPIO pins by adding the
> +"ltc4245,use-extra-gpios" OF device tree property to each chip.
>  
>  The default mode of operation is to sample a single GPIO pin.
> diff --git a/drivers/hwmon/ltc4245.c b/drivers/hwmon/ltc4245.c
> index e7fcf607a05e..7425c801cfe5 100644
> --- a/drivers/hwmon/ltc4245.c
> +++ b/drivers/hwmon/ltc4245.c
> @@ -19,7 +19,7 @@
>  #include <linux/i2c.h>
>  #include <linux/hwmon.h>
>  #include <linux/jiffies.h>
> -#include <linux/platform_data/ltc4245.h>
> +#include <linux/of.h>
>  
>  /* Here are names of the chip's registers (a.k.a. commands) */
>  enum ltc4245_cmd {
> @@ -418,22 +418,6 @@ static const struct hwmon_chip_info ltc4245_chip_info = {
>  	.info = ltc4245_info,
>  };
>  
> -static bool ltc4245_use_extra_gpios(struct i2c_client *client)
> -{
> -	struct ltc4245_platform_data *pdata = dev_get_platdata(&client->dev);
> -	struct device_node *np = client->dev.of_node;
> -
> -	/* prefer platform data */
> -	if (pdata)
> -		return pdata->use_extra_gpios;
> -
> -	/* fallback on OF */
> -	if (of_property_read_bool(np, "ltc4245,use-extra-gpios"))
> -		return true;
> -
> -	return false;
> -}
> -
>  static int ltc4245_probe(struct i2c_client *client)
>  {
>  	struct i2c_adapter *adapter = client->adapter;
> @@ -448,7 +432,8 @@ static int ltc4245_probe(struct i2c_client *client)
>  		return -ENOMEM;
>  
>  	data->client = client;
> -	data->use_extra_gpios = ltc4245_use_extra_gpios(client);
> +	data->use_extra_gpios = of_property_read_bool(client->dev.of_node,
> +						      "ltc4245,use-extra-gpios");
>  
>  	/* Initialize the LTC4245 chip */
>  	i2c_smbus_write_byte_data(client, LTC4245_FAULT1, 0x00);
> diff --git a/include/linux/platform_data/ltc4245.h b/include/linux/platform_data/ltc4245.h
> deleted file mode 100644
> index f07fa05ea6c4..000000000000
> --- a/include/linux/platform_data/ltc4245.h
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * Platform Data for LTC4245 hardware monitor chip
> - *
> - * Copyright (c) 2010 Ira W. Snyder <iws@ovro.caltech.edu>
> - */
> -
> -#ifndef LINUX_LTC4245_H
> -#define LINUX_LTC4245_H
> -
> -#include <linux/types.h>
> -
> -struct ltc4245_platform_data {
> -	bool use_extra_gpios;
> -};
> -
> -#endif /* LINUX_LTC4245_H */
> -- 
> 2.45.2
>