Re: [PATCH 10/10] hwmon: (ds620) Drop platform data support

["Nuno Sá" <nuno.sa@analog.com>]

On Tue, Nov 10, 2026 at 10:34:33AM -0800, Guenter Roeck wrote:
> There are no in-tree users of ds620_platform_data. Without platform
> data, the driver clears PO2 to keep the thermostat output pin low,
> which is the default valid configuration.
> 
> Drop platform data support from the driver, remove the unused
> platform_data header file, and update the driver documentation.
> 
> Cc: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

For whatever patch you end up applying...

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  Documentation/hwmon/ds620.rst       | 12 +-----------
>  drivers/hwmon/ds620.c               | 13 ++-----------
>  include/linux/platform_data/ds620.h | 22 ----------------------
>  3 files changed, 3 insertions(+), 44 deletions(-)
>  delete mode 100644 include/linux/platform_data/ds620.h
> 
> diff --git a/Documentation/hwmon/ds620.rst b/Documentation/hwmon/ds620.rst
> index e2d915a988a2..6a18ecea5c4f 100644
> --- a/Documentation/hwmon/ds620.rst
> +++ b/Documentation/hwmon/ds620.rst
> @@ -25,14 +25,4 @@ into non-volatile on-chip registers). Temperature range is -55 degree Celsius
>  to +125. Between 0 and 70 degree Celsius, accuracy is 0.5 Kelvin. The value
>  returned via sysfs displays post decimal positions.
>  
> -The thermostat function works as follows: When configured via platform_data
> -(struct ds620_platform_data) .pomode == 0 (default), the thermostat output pin
> -PO is always low. If .pomode == 1, the thermostat is in PO_LOW mode. I.e., the
> -output pin PO becomes active when the temperature falls below temp1_min and
> -stays active until the temperature goes above temp1_max.
> -
> -Likewise, with .pomode == 2, the thermostat is in PO_HIGH mode. I.e., the PO
> -output pin becomes active when the temperature goes above temp1_max and stays
> -active until the temperature falls below temp1_min.
> -
> -The PO output pin of the DS620 operates active-low.
> +The thermostat output pin PO is configured to be always low.
> diff --git a/drivers/hwmon/ds620.c b/drivers/hwmon/ds620.c
> index efb005bedabb..17ae9cc72761 100644
> --- a/drivers/hwmon/ds620.c
> +++ b/drivers/hwmon/ds620.c
> @@ -17,7 +17,6 @@
>  #include <linux/err.h>
>  #include <linux/mutex.h>
>  #include <linux/sysfs.h>
> -#include <linux/platform_data/ds620.h>
>  
>  /*
>   * Many DS620 constants specified below
> @@ -64,7 +63,6 @@ struct ds620_data {
>  
>  static void ds620_init_client(struct i2c_client *client)
>  {
> -	struct ds620_platform_data *ds620_info = dev_get_platdata(&client->dev);
>  	u16 conf, new_conf;
>  
>  	new_conf = conf =
> @@ -72,15 +70,8 @@ static void ds620_init_client(struct i2c_client *client)
>  
>  	/* switch to continuous conversion mode */
>  	new_conf &= ~DS620_REG_CONFIG_1SHOT;
> -	/* already high at power-on, but don't trust the BIOS! */
> -	new_conf |= DS620_REG_CONFIG_PO2;
> -	/* thermostat mode according to platform data */
> -	if (ds620_info && ds620_info->pomode == 1)
> -		new_conf &= ~DS620_REG_CONFIG_PO1; /* PO_LOW */
> -	else if (ds620_info && ds620_info->pomode == 2)
> -		new_conf |= DS620_REG_CONFIG_PO1; /* PO_HIGH */
> -	else
> -		new_conf &= ~DS620_REG_CONFIG_PO2; /* always low */
> +	/* thermostat output pin always low */
> +	new_conf &= ~DS620_REG_CONFIG_PO2;
>  	/* with highest precision */
>  	new_conf |= DS620_REG_CONFIG_R1 | DS620_REG_CONFIG_R0;
>  
> diff --git a/include/linux/platform_data/ds620.h b/include/linux/platform_data/ds620.h
> deleted file mode 100644
> index f0ce22a78bb8..000000000000
> --- a/include/linux/platform_data/ds620.h
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -#ifndef _LINUX_DS620_H
> -#define _LINUX_DS620_H
> -
> -#include <linux/types.h>
> -#include <linux/i2c.h>
> -
> -/* platform data for the DS620 temperature sensor and thermostat */
> -
> -struct ds620_platform_data {
> -	/*
> -	 *  Thermostat output pin PO mode:
> -	 *  0 = always low (default)
> -	 *  1 = PO_LOW
> -	 *  2 = PO_HIGH
> -	 *
> -	 * (see Documentation/hwmon/ds620.rst)
> -	 */
> -	int pomode;
> -};
> -
> -#endif /* _LINUX_DS620_H */
> -- 
> 2.45.2
>