Re: [PATCH v3 2/2] hwmon: (lm75) Fix configuration register writes.

[Guenter Roeck <linux@roeck-us.net>]

On Sat, May 02, 2026 at 07:32:07PM +0200, Markus Stockhausen wrote:
> Sensors configurations are defined by set and clear masks. These
> do not follow a consistent "clear mask is a superset of set mask"
> rule. This relaxed definition breaks lm75_write_config()
> 
> static inline int lm75_write_config(struct lm75_data *data, u16 set_mask,
> 				    u16 clr_mask)
> {
> 	return regmap_update_bits(data->regmap, LM75_REG_CONF,
> 				  clr_mask | LM75_SHUTDOWN, set_mask);
> }
> 
> Basically all bits from set_mask that are not defined in clr_mask are
> dropped. Fix that by enhancing the helper to always combine clr_mask
> and set_mask into the mask bits of regmap_update_bits().
> 
> Fixes: 6da24a25f766 ("hwmon: (lm75) Hide register size differences in regmap access functions")
> Suggested-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>

Applied, after fixing the Fixes: tag as seen above.

Thanks,
Guenter