* [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log
@ 2025-10-08 22:43 Stanislav Kinsburskii
2025-10-10 22:49 ` Nuno Das Neves
0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Kinsburskii @ 2025-10-08 22:43 UTC (permalink / raw)
To: kys, haiyangz, wei.liu, decui; +Cc: linux-hyperv, linux-kernel
Update the log message in hv_common_init to explicitly state that the
reported version is for the Microsoft Hypervisor, not the host OS.
Previously, this message was accurate for guests running on Windows
hosts, where the host and hypervisor versions matched. With support for
Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor
versions may differ.
This change avoids confusion by making it clear that the version refers to
the Microsoft Hypervisor regardless of the host operating system.
Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
---
drivers/hv/hv_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index e109a620c83fc..0289ee4ed5ebf 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -315,9 +315,9 @@ int __init hv_common_init(void)
int i;
union hv_hypervisor_version_info version;
- /* Get information about the Hyper-V host version */
+ /* Get information about the Microsoft Hypervisor version */
if (!hv_get_hypervisor_version(&version))
- pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
+ pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n",
version.major_version, version.minor_version,
version.build_number, version.service_number,
version.service_pack, version.service_branch);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log
2025-10-08 22:43 [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log Stanislav Kinsburskii
@ 2025-10-10 22:49 ` Nuno Das Neves
2025-10-31 18:32 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Nuno Das Neves @ 2025-10-10 22:49 UTC (permalink / raw)
To: Stanislav Kinsburskii, kys, haiyangz, wei.liu, decui
Cc: linux-hyperv, linux-kernel
On 10/8/2025 3:43 PM, Stanislav Kinsburskii wrote:
> Update the log message in hv_common_init to explicitly state that the
> reported version is for the Microsoft Hypervisor, not the host OS.
>
> Previously, this message was accurate for guests running on Windows
> hosts, where the host and hypervisor versions matched. With support for
> Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor
> versions may differ.
>
> This change avoids confusion by making it clear that the version refers to
> the Microsoft Hypervisor regardless of the host operating system.
>
> Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
> ---
> drivers/hv/hv_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index e109a620c83fc..0289ee4ed5ebf 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -315,9 +315,9 @@ int __init hv_common_init(void)
> int i;
> union hv_hypervisor_version_info version;
>
> - /* Get information about the Hyper-V host version */
> + /* Get information about the Microsoft Hypervisor version */
> if (!hv_get_hypervisor_version(&version))
> - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> + pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n",
> version.major_version, version.minor_version,
> version.build_number, version.service_number,
> version.service_pack, version.service_branch);
>
>
Looks like a good idea.
Reviewed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log
2025-10-10 22:49 ` Nuno Das Neves
@ 2025-10-31 18:32 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2025-10-31 18:32 UTC (permalink / raw)
To: Nuno Das Neves
Cc: Stanislav Kinsburskii, kys, haiyangz, wei.liu, decui,
linux-hyperv, linux-kernel
On Fri, Oct 10, 2025 at 03:49:17PM -0700, Nuno Das Neves wrote:
> On 10/8/2025 3:43 PM, Stanislav Kinsburskii wrote:
> > Update the log message in hv_common_init to explicitly state that the
> > reported version is for the Microsoft Hypervisor, not the host OS.
> >
> > Previously, this message was accurate for guests running on Windows
> > hosts, where the host and hypervisor versions matched. With support for
> > Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor
> > versions may differ.
> >
> > This change avoids confusion by making it clear that the version refers to
> > the Microsoft Hypervisor regardless of the host operating system.
> >
> > Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
> > ---
> > drivers/hv/hv_common.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> > index e109a620c83fc..0289ee4ed5ebf 100644
> > --- a/drivers/hv/hv_common.c
> > +++ b/drivers/hv/hv_common.c
> > @@ -315,9 +315,9 @@ int __init hv_common_init(void)
> > int i;
> > union hv_hypervisor_version_info version;
> >
> > - /* Get information about the Hyper-V host version */
> > + /* Get information about the Microsoft Hypervisor version */
> > if (!hv_get_hypervisor_version(&version))
> > - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> > + pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n",
> > version.major_version, version.minor_version,
> > version.build_number, version.service_number,
> > version.service_pack, version.service_branch);
> >
> >
>
> Looks like a good idea.
>
> Reviewed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Applied to hyperv-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-31 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 22:43 [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log Stanislav Kinsburskii
2025-10-10 22:49 ` Nuno Das Neves
2025-10-31 18:32 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox