From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: linux-omap@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
ben-linux@fluff.org, tony@atomide.com, w.sang@pengutronix.de,
Shubhrajyoti D <shubhrajyoti@ti.com>,
stable@vger.kernel.org
Subject: [PATCHv6 12/19] I2C: OMAP: Fix the crash in i2c remove
Date: Tue, 10 Apr 2012 16:26:30 +0530 [thread overview]
Message-ID: <1334055397-899-13-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1334055397-899-1-git-send-email-shubhrajyoti@ti.com>
In omap_i2c_remove we are accessing the I2C_CON register without
enabling the clocks. Fix the same by enabling the clocks and disabling
it.
This fixes the following crash.
[ 154.723022] ------------[ cut here ]------------
[ 154.725677] WARNING: at arch/arm/mach-omap2/omap_l3_noc.c:112 l3_interrupt_handler+0x1b4/0x1c4()
[ 154.725677] L3 custom error: MASTER:MPU TARGET:L4 PER2
[ 154.742614] Modules linked in: i2c_omap(-)
[ 154.746948] Backtrace:
[ 154.746948] [<c0013078>] (dump_backtrace+0x0/0x110) from [<c026c158>] (dump_stack+0x18/0x1c)
[ 154.752716] r6:00000070 r5:c002c43c r4:df9b9e98 r3:df9b8000
[ 154.764465] [<c026c140>] (dump_stack+0x0/0x1c) from [<c0041a2c>] (warn_slowpath_common+0x5c/0x6c)
[ 154.768341] [<c00419d0>] (warn_slowpath_common+0x0/0x6c) from [<c0041ae0>] (warn_slowpath_fmt+0x38/0x40)
[ 154.776153] r8:00000180 r7:c0361594 r6:c0379b48 r5:00080003 r4:e0838b00
[ 154.790771] r3:00000009
[ 154.791778] [<c0041aa8>] (warn_slowpath_fmt+0x0/0x40) from [<c002c43c>] (l3_interrupt_handler+0x1b4/0x1c4)
[ 154.803710] r3:c0361598 r2:c02ef74c
[ 154.807403] [<c002c288>] (l3_interrupt_handler+0x0/0x1c4) from [<c0085f44>] (handle_irq_event_percpu+0x58/0
[ 154.818237] r8:0000002a r7:00000000 r6:00000000 r5:df808054 r4:df8893c0
[ 154.825378] [<c0085eec>] (handle_irq_event_percpu+0x0/0x188) from [<c00860b8>] (handle_irq_event+0x44/0x64)
[ 154.835662] [<c0086074>] (handle_irq_event+0x0/0x64) from [<c0088ec0>] (handle_fasteoi_irq+0xa4/0x10c)
[ 154.845458] r6:0000002a r5:df808054 r4:df808000 r3:c034a150
[ 154.846466] [<c0088e1c>] (handle_fasteoi_irq+0x0/0x10c) from [<c0085ed0>] (generic_handle_irq+0x30/0x38)
[ 154.854278] r5:c034aa48 r4:0000002a
[ 154.862091] [<c0085ea0>] (generic_handle_irq+0x0/0x38) from [<c000fd38>] (handle_IRQ+0x60/0xc0)
[ 154.874450] r4:c034ea70 r3:000001f8
[ 154.878234] [<c000fcd8>] (handle_IRQ+0x0/0xc0) from [<c0008478>] (gic_handle_irq+0x20/0x5c)
[ 154.887023] r7:ffffff40 r6:df9b9fb0 r5:c034e2b4 r4:0000001a
[ 154.887054] [<c0008458>] (gic_handle_irq+0x0/0x5c) from [<c000ea80>] (__irq_usr+0x40/0x60)
[ 154.901153] Exception stack(0xdf9b9fb0 to 0xdf9b9ff8)
[ 154.907104] 9fa0: beaf1f04 4006be00 0000000f 0000000c
[ 154.915710] 9fc0: 4006c000 00000000 00008034 ffffff40 00000007 00000000 00000000 0007b8d7
[ 154.916778] 9fe0: 00000000 beaf1b68 0000d23c 4005baf0 80000010 ffffffff
[ 154.931335] r6:ffffffff r5:80000010 r4:4005baf0 r3:beaf1f04
[ 154.937316] ---[ end trace 1b75b31a2719ed21 ]--
Cc: <stable@vger.kernel.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 86be475..8258597 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1134,7 +1134,9 @@ static int __devexit omap_i2c_remove(struct platform_device *pdev)
free_irq(dev->irq, dev);
i2c_del_adapter(&dev->adapter);
+ pm_runtime_get_sync(&pdev->dev);
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
+ pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0;
}
--
1.7.4.1
next prev parent reply other threads:[~2012-04-10 10:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 10:56 [PATCH 00/19] I2C updates Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 02/19] I2C: OMAP: Remove reset at init Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 03/19] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 05/19] I2C: OMAP: Fix the interrupt clearing in OMAP4 Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 06/19] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 09/19] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 10/19] I2C: OMAP: Don't check if wait_for_completion_timeout() returns less than zero Shubhrajyoti D
2012-04-10 10:56 ` Shubhrajyoti D [this message]
2012-04-10 10:56 ` [PATCHv6 13/19] I2C: OMAP: Handle error check for pm runtime Shubhrajyoti D
[not found] ` <1334055397-899-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-04-10 10:56 ` [PATCHv6 01/19] I2C: OMAP: make omap_i2c_unidle/idle functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 04/19] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 07/19] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 08/19] I2C: OMAP: Fix the error handling Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 11/19] I2C: OMAP: use devm_* functions Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 14/19] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 15/19] I2C: OMAP: make the read ready processing a separate function Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 16/19] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153 Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 19/19] ARM: OMAP4: hwmod data: I2C: add flag for context restore Shubhrajyoti D
2012-04-10 18:13 ` Paul Walmsley
[not found] ` <alpine.DEB.2.00.1204101212530.20894-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2012-04-11 5:40 ` Shubhrajyoti
2012-04-10 11:31 ` [PATCH 00/19] I2C updates S, Venkatraman
2012-04-10 11:41 ` Felipe Balbi
[not found] ` <20120410114153.GR20616-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-04-10 14:56 ` Shubhrajyoti
2012-04-10 10:56 ` [PATCHv6 17/19] I2C: OMAP: Do not set the XUDF if the underflow is not reached Shubhrajyoti D
2012-04-10 10:56 ` [PATCHv6 18/19] I2C: OMAP: Rename the 1p153 to the erratum id i462 Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334055397-899-13-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox