public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23
@ 2012-11-17 19:48 Fabio Estevam
       [not found] ` <1353181734-13253-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2012-11-17 19:48 UTC (permalink / raw)
  To: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ
  Cc: f.koliqi-Re5JQEeQqe8AvxtiuMwx3w, marex-ynQEQJNshbs,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam

From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

With the recent DMA support addition to the i2c-mxs driver, it is now possible 
to also run it on mx23, so update the Kconfig entry accordingly.

Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/i2c/busses/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index e9df461..34f48f3 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -482,12 +482,12 @@ config I2C_MV64XXX
 	  will be called i2c-mv64xxx.
 
 config I2C_MXS
-	tristate "Freescale i.MX28 I2C interface"
-	depends on SOC_IMX28
+	tristate "Freescale MXS I2C interface"
+	depends on ARCH_MXS
 	select STMP_DEVICE
 	help
 	  Say Y here if you want to use the I2C bus controller on
-	  the Freescale i.MX28 processors.
+	  the Freescale MXS processors.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-mxs.
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23
       [not found] ` <1353181734-13253-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-11-18  5:23   ` Marek Vasut
       [not found]     ` <201211180623.29126.marex-ynQEQJNshbs@public.gmane.org>
  2012-11-19  8:49   ` Wolfram Sang
  1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2012-11-18  5:23 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ, f.koliqi-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> With the recent DMA support addition to the i2c-mxs driver, it is now
> possible to also run it on mx23, so update the Kconfig entry accordingly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/i2c/busses/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index e9df461..34f48f3 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -482,12 +482,12 @@ config I2C_MV64XXX
>  	  will be called i2c-mv64xxx.
> 
>  config I2C_MXS
> -	tristate "Freescale i.MX28 I2C interface"
> -	depends on SOC_IMX28
> +	tristate "Freescale MXS I2C interface"
> +	depends on ARCH_MXS
>  	select STMP_DEVICE
>  	help
>  	  Say Y here if you want to use the I2C bus controller on
> -	  the Freescale i.MX28 processors.
> +	  the Freescale MXS processors.
> 
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called i2c-mxs.

Won't i.MX23/i.MX28 instead of MXS be less confusing? Either way:

Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23
       [not found]     ` <201211180623.29126.marex-ynQEQJNshbs@public.gmane.org>
@ 2012-11-18  6:31       ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2012-11-18  6:31 UTC (permalink / raw)
  To: Marek Vasut
  Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ, f.koliqi-Re5JQEeQqe8AvxtiuMwx3w,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam

On Sun, Nov 18, 2012 at 3:23 AM, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:

>
> Won't i.MX23/i.MX28 instead of MXS be less confusing? Either way:
>
> Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

I kept MXS to let it consistent with other Kconfig files, such as
spi-mxs, mmcmxs, etc.

Thanks,

Fabio Estevam

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23
       [not found] ` <1353181734-13253-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2012-11-18  5:23   ` Marek Vasut
@ 2012-11-19  8:49   ` Wolfram Sang
       [not found]     ` <20121119084958.GB7775-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2012-11-19  8:49 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: f.koliqi-Re5JQEeQqe8AvxtiuMwx3w, marex-ynQEQJNshbs,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

On Sat, Nov 17, 2012 at 05:48:54PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> With the recent DMA support addition to the i2c-mxs driver, it is now possible 
> to also run it on mx23, so update the Kconfig entry accordingly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Did you test it?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23
       [not found]     ` <20121119084958.GB7775-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2012-11-19 11:30       ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2012-11-19 11:30 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: f.koliqi-Re5JQEeQqe8AvxtiuMwx3w, marex-ynQEQJNshbs,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam

Hi Wolfram,

On Mon, Nov 19, 2012 at 6:49 AM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> On Sat, Nov 17, 2012 at 05:48:54PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> With the recent DMA support addition to the i2c-mxs driver, it is now possible
>> to also run it on mx23, so update the Kconfig entry accordingly.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Did you test it?

I don't have the I2C connector board for mx23-olinuxino, but I have
been helping Fadil Berisha (on Cc) to get I2C to work on mx23.

He managed to get I2C working on his mx23 board and posted the results at:
https://www.olimex.com/forum/index.php?topic=283.msg1086#msg1086

He has already sent the dts patches to the ARM kernel list.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-11-19 11:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-17 19:48 [PATCH] i2c: Kconfig: Allow I2C_MXS to be selected by MX23 Fabio Estevam
     [not found] ` <1353181734-13253-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-18  5:23   ` Marek Vasut
     [not found]     ` <201211180623.29126.marex-ynQEQJNshbs@public.gmane.org>
2012-11-18  6:31       ` Fabio Estevam
2012-11-19  8:49   ` Wolfram Sang
     [not found]     ` <20121119084958.GB7775-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-19 11:30       ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox